New issue
Advanced search Search tips

Issue 918942 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 18
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 917555
issue 918993

Blocking:
issue dawn:79



Sign in to add a comment

dawn_end2end_tests failing on Linux FYI Experimental Release (NVIDIA)

Project Member Reported by kbr@chromium.org, Jan 3

Issue description

Bot:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Experimental%20Release%20(NVIDIA)

Example failure:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Experimental%20Release%20%28NVIDIA%29/7314

Failure excerpt:

[----------] 3 tests from BindGroupTests
[ RUN      ] BindGroupTests.ReusedUBO/Vulkan
Device initialization error: vkCreateInstance failed
Assertion failure at ../../third_party/dawn/src/dawn_native/vulkan/DeviceVk.cpp:94 (Device): false
[15858:15861:0103/103503.308320:7804615392:ERROR:kill_posix.cc(84)] Unable to terminate process group 15862: No such process (3)
[1/87] BasicTests.BufferSetSubData/OpenGL (153 ms)
[2/87] BindGroupTests.ReusedUBO/Vulkan (CRASHED)


I think the Vulkan driver's not properly installed on these machines, which contain NVIDIA's latest driver.

Going to remove these tests from this machine temporarily while this is fixed.

 
Duplicate of issue dawn:79 . ANGLE has a similar problem but isn't erroring because of how the ANGLE test harness works.
Blocking: dawn:79
OK, thanks for pointing that out. Still need to disable this suite on this bot temporarily to get it green.

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cf42b4511dd460234fed559a0cfe6ea9400e883

commit 2cf42b4511dd460234fed559a0cfe6ea9400e883
Author: Kenneth Russell <kbr@chromium.org>
Date: Thu Jan 03 21:31:54 2019

Remove dawn_end2end_tests from Linux NVIDIA experimental bot.

The Vulkan driver doesn't seem properly installed on these machines.
Will re-enable once it is.

Bug:  918942 
Change-Id: I0f3ceeead53d10ce0ffbbb1ed017dcc521172cba
No-Try: True
Reviewed-on: https://chromium-review.googlesource.com/c/1394917
Reviewed-by: Kai Ninomiya <kainino@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619761}
[modify] https://crrev.com/2cf42b4511dd460234fed559a0cfe6ea9400e883/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/2cf42b4511dd460234fed559a0cfe6ea9400e883/testing/buildbot/test_suite_exceptions.pyl

Owner: cwallez@chromium.org
Corentin, could you take this over and re-enable the tests once they're expected to work? Thanks.

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6297d41003f9140232dd7f9e0325516bfa3a6ef0

commit 6297d41003f9140232dd7f9e0325516bfa3a6ef0
Author: Corentin Wallez <cwallez@chromium.org>
Date: Wed Jan 09 13:29:44 2019

Reenable dawn_end2end_tests from Linux NVIDIA experimental bot

This is equivalent to a revert of
2cf42b4511dd460234fed559a0cfe6ea9400e883

NOTRY=true
BUG= chromium:918942 

Change-Id: I2821f8e7683be1bf7c2f6521fed72d894fabe26b
Reviewed-on: https://chromium-review.googlesource.com/c/1400807
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621126}
[modify] https://crrev.com/6297d41003f9140232dd7f9e0325516bfa3a6ef0/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/6297d41003f9140232dd7f9e0325516bfa3a6ef0/testing/buildbot/test_suite_exceptions.pyl

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a6808d5e2619451f322692d3e22c12b57821608

commit 4a6808d5e2619451f322692d3e22c12b57821608
Author: Corentin Wallez <cwallez@chromium.org>
Date: Wed Jan 09 14:10:09 2019

Revert "Reenable dawn_end2end_tests from Linux NVIDIA experimental bot"

This reverts commit 6297d41003f9140232dd7f9e0325516bfa3a6ef0.

Reason for revert: Still fails with Device initialization error: vkCreateInstance failed with VK_ERROR_INCOMPATIBLE_DRIVER

Original change's description:
> Reenable dawn_end2end_tests from Linux NVIDIA experimental bot
> 
> This is equivalent to a revert of
> 2cf42b4511dd460234fed559a0cfe6ea9400e883
> 
> NOTRY=true
> BUG= chromium:918942 
> 
> Change-Id: I2821f8e7683be1bf7c2f6521fed72d894fabe26b
> Reviewed-on: https://chromium-review.googlesource.com/c/1400807
> Commit-Queue: Corentin Wallez <cwallez@chromium.org>
> Reviewed-by: Kenneth Russell <kbr@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#621126}

TBR=kbr@chromium.org,cwallez@chromium.org

Change-Id: I23d5610748cafe3eff1865a91a4c2c77badeb337
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  chromium:918942 
Reviewed-on: https://chromium-review.googlesource.com/c/1402804
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621137}
[modify] https://crrev.com/4a6808d5e2619451f322692d3e22c12b57821608/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/4a6808d5e2619451f322692d3e22c12b57821608/testing/buildbot/test_suite_exceptions.pyl

Blockedon: 918993
This is the same issue as 918993: the fix there was applied to a specific driver version when it should apply to all driver versions.
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 17 (6 days ago)

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infra/puppet/+/ac10ed037ee0468fca79813ce2e1e8534bee171c

commit ac10ed037ee0468fca79813ce2e1e8534bee171c
Author: Corentin Wallez <cwallez@google.com>
Date: Thu Jan 17 00:14:58 2019

Comment 9 by jmadill@google.com, Jan 17 (5 days ago)

Thanks to Corentin and Elliot's changes to the puppet scripts, ANGLE started working on ES2 Vulkan last night in this build:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20FYI%20Experimental%20Release%20%28NVIDIA%29/7465

Fantastic job. I think we can re-enable these tests now.

Comment 10 by kbr@chromium.org, Jan 17 (5 days ago)

Fantastic work Elliott, Corentin, Yuly and Jamie!

Project Member

Comment 11 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8041a078908d455d239ddd7d76aab1c28145dbbe

commit 8041a078908d455d239ddd7d76aab1c28145dbbe
Author: Corentin Wallez <cwallez@chromium.org>
Date: Fri Jan 18 06:44:36 2019

Reenable dawn_end2end_tests from Linux NVIDIA experimental bot

This is equivalent to a revert of
2cf42b4511dd460234fed559a0cfe6ea9400e883

BUG= chromium:918942 

Change-Id: Ib88ff1d134875acccba70cc7995dab8c0c61f09c
Reviewed-on: https://chromium-review.googlesource.com/c/1419012
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Auto-Submit: Corentin Wallez <cwallez@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624023}
[modify] https://crrev.com/8041a078908d455d239ddd7d76aab1c28145dbbe/testing/buildbot/chromium.gpu.fyi.json
[modify] https://crrev.com/8041a078908d455d239ddd7d76aab1c28145dbbe/testing/buildbot/test_suite_exceptions.pyl

Comment 12 by jmadill@google.com, Jan 18 (4 days ago)

Sign in to add a comment