Issue metadata
Sign in to add a comment
|
Cast toolbar icon's inkdrop gets darker when hovering over other icons |
||||||||||||||||||||||
Issue descriptionChrome Version: 73.0.3642.0 OS: Linux What steps will reproduce the problem? (1) You may need to enable #views-cast-dialog in chrome://flags (2) App menu -> "Cast..." to show Cast toolbar icon (3) Hover over the Cast icon and other things such as extension icons. Notice that the color of the Cast icon changes penghuang@, could this be related to crrev.com/c/1368031? If so, could you take a look? Bisect range: https://chromium.googlesource.com/chromium/src/+log/d33127fd0f01784c99ace087a4346c4d8b54cca6..35a89996082e62d93f8c0eac6aaadfb6bf6f8acb
,
Jan 8
If you select "Cast..." from the three dots menu, can you make the icon show? You can pin the icon to the toolbar by right clicking on the icon and selecting "Always show icon".
,
Jan 8
Got the cast icon this time, but I still cannot reproduce this issue with https://chromium.googlesource.com/chromium/src/+/35a89996082e62d93f8c0eac6aaadfb6bf6f8acb
,
Jan 8
I have reproduced it. The problem only happens after a renderer is crashed on my box.
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d7aaf7831522612e6e4c947c29eb767e88e271f1 commit d7aaf7831522612e6e4c947c29eb767e88e271f1 Author: Peng Huang <penghuang@chromium.org> Date: Wed Jan 09 22:03:08 2019 Fix a rendering issue with RasterDecoder DoCopySubTexture may modifies GL global context state, we need restore them, otherwise RasterDecoderContextState::context_state will become dirty. Bug: 918929 Change-Id: I3d1a506b6410d215baa2e3a3a08db52395f30225 Reviewed-on: https://chromium-review.googlesource.com/c/1403337 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#621302} [modify] https://crrev.com/d7aaf7831522612e6e4c947c29eb767e88e271f1/gpu/command_buffer/service/raster_decoder.cc [modify] https://crrev.com/d7aaf7831522612e6e4c947c29eb767e88e271f1/gpu/command_buffer/service/raster_decoder_context_state.cc [modify] https://crrev.com/d7aaf7831522612e6e4c947c29eb767e88e271f1/gpu/command_buffer/service/raster_decoder_context_state.h
,
Jan 9
,
Jan 9
Thank you for the fix!
,
Jan 10
Unable to reproduce the issue on reported chrome version #73.0.3642.0 using Linux 17.10 by following below steps: Steps: ===== 1.Launched chrome. 2. Enabled view cast dialog from chrome://flags 3.Enabled cast icon 4. clicked on cast icon and hovered over other extension icons as per comment#0 Observation : Didn't see any color drop on cast icon. Attached screencast for reference. @Peng : Could you please review attached screencast and let us know if anything is being missed here. And please help us in verifying the fix. Thanks.!
,
Jan 10
I reproduce it by following steps. 1. Go to web store 2. Click add to chrome button for any chrome extension. 3. Click cancel button for to confirm dialog. 4. Press the cast icon 5. The problem happens.
,
Jan 17
(5 days ago)
Tried testing the issue on reported chrome version #73.0.3642.0 on Ubuntu 17.10 by following below steps. Steps: ===== 1.Launched chrome. 2.Enabled #views-cast-dialog in "chrome://flags". 3.Navigated to "about:crash" for renderer crash. 4.Navigated to "chrome://apps". 5.Opened a chrome extension and clicked on "add to chrome" button. 6.On confirm dialogue clicked on the cancel button. 7.Clicked "cast" icon and hovered over other icons. 8.Unable to observe any change in colour of "cast" icon. Attached screencast for reference. @Peng Huang: Could you please review attached screencast and let us know if anything is being missed from our end. Requesting you to help us in verifying this on upcoming Linux dev. Thanks.!
,
Jan 17
(5 days ago)
Can you past about:gpu page here? I think this issue only happens with use_virtualized_gl_contexts. You may check it in about:gpu page "Driver Bug Workarounds" section.
,
Jan 18
(4 days ago)
In Reply to comment#11, @Peng Huang: Please find the attached GPU details of the system.
,
Jan 18
(4 days ago)
The virtualized gl context is not enabled on your machine. You may try launch chrome with flag --use_virtualized_gl_contexts=1. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by penghuang@chromium.org
, Jan 8