New issue
Advanced search Search tips

Issue 918922 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 629707



Sign in to add a comment

Mash: Elim SystemSaltGetter from AshService

Project Member Reported by steve...@google.com, Jan 3

Issue description

The only Ash dependency on //chromeos/cryptohome is chromeos::SystemSaltGetter()::Initialize/Shutdown in AshService.

We should investigate whether this is needed and remove it if possible.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cf1dd71ae420fcd553a24d18d828a17c4cad1b6

commit 1cf1dd71ae420fcd553a24d18d828a17c4cad1b6
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jan 04 20:14:22 2019

Remove SystemSaltGetter from Ash

SystemSaltGetter::Get() is only used in src/chrome, and src/login/auth
(which is only used by src/chrome), so remove initialization and
shutdown from AshService and AshTestHelper. This allows us to remove
the //chromeos/cryptohome dependency from //ash entirely.

Bug:  918922 
Change-Id: I08d63d6b4ecd39ff8acac013253ff3c58d431e08
Reviewed-on: https://chromium-review.googlesource.com/c/1396320
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620044}
[modify] https://crrev.com/1cf1dd71ae420fcd553a24d18d828a17c4cad1b6/ash/ash_service.cc
[modify] https://crrev.com/1cf1dd71ae420fcd553a24d18d828a17c4cad1b6/ash/test/ash_test_helper.cc
[modify] https://crrev.com/1cf1dd71ae420fcd553a24d18d828a17c4cad1b6/chrome/browser/chromeos/extensions/quick_unlock_private/quick_unlock_private_api_unittest.cc

Labels: M-73
Status: Fixed (was: Started)

Sign in to add a comment