New issue
Advanced search Search tips

Issue 918906 link

Starred by 5 users
Status: Verified
Owner:
joelhockey@chromium.org
Closed: Jan 8
Cc:
jkardatzke@chromium.org
joelhockey@chromium.org
smbar...@chromium.org
rohi...@chromium.org
avkodipelli@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

CrostiniFiles test is failing as of 11512.0.0

Project Member Reported by jkardatzke@google.com, Jan 3 
Test is now solid red starting with 11512.0.0. There's very minimal Chrome OS changes in that version, but there's weeks of Chrome changes in it. The failure in the logs is as below:

2019/01/02 17:11:07 [17:11:06.866] Connecting to Chrome at ws://127.0.0.1:36913/devtools/page/C60F1DFF2EB0FE116612F0D33356A3F9
2019/01/02 17:11:07 [17:11:07.359] External command failed: exit status 1
2019/01/02 17:11:08 [17:11:07.359] Command: vsh --vm_name=termina --target_container=penguin --owner_id=75435538fefd2b4265232ba7add4ce151dcbd4b2 -- cat /mnt/chromeos/MyFiles/Downloads/shared/hello.txt
2019/01/02 17:11:08 [17:11:07.359] Uncaptured output:
2019/01/02 17:11:08 [17:11:07.360] Error at crostini_files.go:240: Failed to run cat /mnt/chromeos/MyFiles/Downloads/shared/hello.txt: exit status 1
2019/01/02 17:11:08 [17:11:07.360] Stack trace:
Failed to run cat /mnt/chromeos/MyFiles/Downloads/shared/hello.txt
	at chromiumos/tast/local/bundles/cros/vm.verifyFileInContainer (crostini_files.go:240)
	at chromiumos/tast/local/bundles/cros/vm.testShareFiles (crostini_files.go:162)
	at chromiumos/tast/local/bundles/cros/vm.CrostiniFiles (crostini_files.go:65)
	at chromiumos/tast/testing.(*Test).Run.func4 (test.go:228)
	at chromiumos/tast/testing.runStages.func1.1 (stage.go:39)
	at chromiumos/tast/testing.runAndRecover.func1 (stage.go:69)
	at runtime.goexit (asm_amd64.s:2361)
exit status 1
2019/01/02 17:11:08 [17:11:07.398] External command failed: exit status 1
2019/01/02 17:11:08 [17:11:07.398] Command: vsh --vm_name=termina --target_container=penguin --owner_id=75435538fefd2b4265232ba7add4ce151dcbd4b2 -- cat /mnt/chromeos/MyFiles/Downloads/hello.txt
2019/01/02 17:11:08 [17:11:07.398] Uncaptured output:
2019/01/02 17:11:08 [17:11:07.398] Error at crostini_files.go:240: Failed to run cat /mnt/chromeos/MyFiles/Downloads/hello.txt: exit status 1
2019/01/02 17:11:08 [17:11:07.398] Stack trace:
Failed to run cat /mnt/chromeos/MyFiles/Downloads/hello.txt
	at chromiumos/tast/local/bundles/cros/vm.verifyFileInContainer (crostini_files.go:240)
	at chromiumos/tast/local/bundles/cros/vm.testShareFiles (crostini_files.go:163)
	at chromiumos/tast/local/bundles/cros/vm.CrostiniFiles (crostini_files.go:65)
	at chromiumos/tast/testing.(*Test).Run.func4 (test.go:228)
	at chromiumos/tast/testing.runStages.func1.1 (stage.go:39)
	at chromiumos/tast/testing.runAndRecover.func1 (stage.go:69)
	at runtime.goexit (asm_amd64.s:2361)
exit status 1
2019/01/02 17:11:08 [17:11:07.476] External command failed: exit status 1
2019/01/02 17:11:08 [17:11:07.476] Command: vsh --vm_name=termina --target_container=penguin --owner_id=75435538fefd2b4265232ba7add4ce151dcbd4b2 -- mkdir -p /mnt/chromeos/MyFiles/Downloads/contwrite
2019/01/02 17:11:08 [17:11:07.476] Uncaptured output:
mkdir: cannot create directory ‘/mnt/chromeos/MyFiles/Downloads’: Permission denied
2019/01/02 17:11:08 [17:11:07.476] Error at crostini_files.go:173: Failed to create dir /mnt/chromeos/MyFiles/Downloads/contwrite in container: exit status 1
2019/01/02 17:11:08 [17:11:07.476] Stack trace:
Failed to create dir /mnt/chromeos/MyFiles/Downloads/contwrite in container
	at chromiumos/tast/local/bundles/cros/vm.testShareFiles (crostini_files.go:173)
	at chromiumos/tast/local/bundles/cros/vm.CrostiniFiles (crostini_files.go:65)
	at chromiumos/tast/testing.(*Test).Run.func4 (test.go:228)
	at chromiumos/tast/testing.runStages.func1.1 (stage.go:39)
	at chromiumos/tast/testing.runAndRecover.func1 (stage.go:69)
	at runtime.goexit (asm_amd64.s:2361)

Comment 1 by dverkamp@chromium.org, Jan 3

Cc: smbar...@chromium.org joelhockey@chromium.org
 Issue 918892  has been merged into this issue.

Comment 2 by avkodipelli@chromium.org, Jan 3

Cc: rohi...@chromium.org avkodipelli@chromium.org
Components: Platform>Apps>FileManager
Labels: -Type-Bug ReleaseBlock-Dev M-73 Type-Bug-Regression
Reproduced issue manually on 11516.0.0, 73.0.3654.0. It is failing due to permission denied to open Downloads folder from Linux(crostini).

Automation results from stainless: https://stainless.corp.google.com/search?view=matrix&row=model&col=build&first_date=2019-01-01&last_date=2019-01-03&test=vm.CrostiniFiles&exclude_cts=false&exclude_not_run=false&exclude_non_release=true&exclude_au=true&exclude_acts=true&exclude_retried=true&exclude_non_production=false

Comment 3 by smbar...@chromium.org, Jan 3 

Suspecting the 11396.0.0 VM push caused this, the timing matches up.

Comment 4 by joelhockey@chromium.org, Jan 4 

I can replicate the failing tast test locally.

I think that new containers are not getting raw.idmap set.

When I check the state of the container at the end of a local failed tast test, I see that it has an empty raw.idmap (lxc config get penguin raw.idmap).  I also see that the shared path of /mnt/chromeos/MyFiles/Downloads is owned by nobody:nobody.

If I stop the container and then do:
vsh termina
echo -n "1000 1000 both" | lxc config set penguin raw.idmap -

And then start the container, and share Downloads again, access to shared paths works.  I also see that /mnt/chromeos/MyFiles/Downloads is owned by testuser:nogroup

Comment 5 by dgagnon@chromium.org, Jan 4 

Just FYI, this issue is currently blocking M73 Dev which is targeted for next week.

Comment 6 by smbar...@chromium.org, Jan 4 

Joel's posted https://chromium-review.googlesource.com/c/chromiumos/platform/tremplin/+/1395897 to fix this, we're just waiting on a CQ run.
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/tremplin/+/c2303eb5dd0155dd8bdb535336031a632f3147d1

commit c2303eb5dd0155dd8bdb535336031a632f3147d1
Author: Joel Hockey <joelhockey@chromium.org>
Date: Sat Jan 05 12:12:01 2019

tremplin: set raw.idmap for new containers

BUG= chromium:918906 
TEST=tast vm.CrostiniFiles

Change-Id: I4151f7071721d502795126b54c56baad64172373
Reviewed-on: https://chromium-review.googlesource.com/1395897
Commit-Ready: Joel Hockey <joelhockey@chromium.org>
Tested-by: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Stephen Barber <smbarber@chromium.org>

[modify] https://crrev.com/c2303eb5dd0155dd8bdb535336031a632f3147d1/src/chromiumos/tremplin/main.go

Comment 8 by cindyb@chromium.org, Jan 7 

This shows pushed, can the bug be closed?

Comment 10 by smbar...@chromium.org, Jan 7 

I've pushed 11540.0.0 with the fix so the tests should start to clear up now.

Comment 11 by smbar...@chromium.org, Jan 7 

Actually, 11540 appears to have a broken manifest. So I'll push out 11542.0.0 shortly.

Comment 12 by smbar...@chromium.org, Jan 8

Status: Fixed (was: Assigned)
11542.0.0 is live. vm.CrostiniFiles now passes on my local setup.

Going to mark this fixed, we should mark verified once the stainless dashboard shows green as well.

Comment 13 by jkardatzke@chromium.org, Jan 8

Status: Verified (was: Fixed)
Tests are green now, marking verified. Thanks!
►

Sign in to add a comment