New issue
Advanced search Search tips

Issue 918905 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 918766
Owner: ----
Closed: Jan 4
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 3
Type: Bug



Sign in to add a comment

external/wpt/.../block-size-with-min-or-max-content-table-1b.html failing on Debug builds

Project Member Reported by steimel@chromium.org, Jan 3

Issue description

external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/sizing/block-size-with-min-or-max-content-table-1b.html is failing on Mac10.13 dbg:

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20(dbg)/7908

Added by crrev.com/c/1394189, which says to add a TestExpectation instead of reverting
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f78e045a4059342f8fc8b9124760d7a887a7df65

commit f78e045a4059342f8fc8b9124760d7a887a7df65
Author: Tommy Steimel <steimel@chromium.org>
Date: Thu Jan 03 19:52:53 2019

Add block-size-with-min-or-max-content-table-1b.html TestExpectation

Example failure:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/7897

Bug:  918905 
Change-Id: I3ab6874fb5380d8f369e03f3d0837edff8eacbeb
Reviewed-on: https://chromium-review.googlesource.com/c/1394799
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619725}
[modify] https://crrev.com/f78e045a4059342f8fc8b9124760d7a887a7df65/third_party/blink/web_tests/TestExpectations

Cc: r...@igalia.com
Status: Available (was: Untriaged)
+rego@ based on the owners description in crrev.com/c/1394189
Labels: OS-Linux
Summary: external/wpt/.../block-size-with-min-or-max-content-table-1b.html failing on Debug builds (was: external/wpt/.../block-size-with-min-or-max-content-table-1b.html failing on Mac10.13 dbg)
This is failing on other debug builds as well: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20(dbg)(1)/76911
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cbcf40ed73cbaa0fa165f31373cd7896c69019b4

commit cbcf40ed73cbaa0fa165f31373cd7896c69019b4
Author: Tommy Steimel <steimel@chromium.org>
Date: Thu Jan 03 23:34:05 2019

Update block-size-...-content-table-1b.html TestExpectation

Turns out this test is failing on other debug builds as well, e.g.:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20(dbg)(1)/76911

it also has failed on a Mac 10.12 rel bot, so updating to include all Mac bots

Bug:  918905 
Change-Id: I30628e6ee16674d8b961cbbbd273255f4429ad5e
Reviewed-on: https://chromium-review.googlesource.com/c/1394927
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619803}
[modify] https://crrev.com/cbcf40ed73cbaa0fa165f31373cd7896c69019b4/third_party/blink/web_tests/TestExpectations

Mergedinto: 918766
Status: Duplicate (was: Available)
This is one more of the new tests that started to fail after importing from WPT in issue #918766.


Project Member

Comment 6 by bugdroid1@chromium.org, Jan 18 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/28af6d7b89c20a8417951fded7f49e5f1ee76fc6

commit 28af6d7b89c20a8417951fded7f49e5f1ee76fc6
Author: Hiroki Nakagawa <nhiroki@chromium.org>
Date: Fri Jan 18 06:08:51 2019

Sheriff: Mark block-size-with-min-or-max-content-table-1b.html as flaky on more bots

This test is flaky also on Win.

Bug:  918905 ,  923246 
Change-Id: I21484df0cfc28603d971e2389023c805f556651d
Tbr: nhiroki@chromium.org
Notry: true
Reviewed-on: https://chromium-review.googlesource.com/c/1420504
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624020}
[modify] https://crrev.com/28af6d7b89c20a8417951fded7f49e5f1ee76fc6/third_party/blink/web_tests/TestExpectations

Comment 7 by nhiroki@chromium.org, Jan 18 (5 days ago)

 Issue 923246  has been merged into this issue.

Sign in to add a comment