nacl_bootstrap_lib isn't rebuilt on clang compiler rolls |
|||
Issue descriptionSome of NaCl's code is built with chromium's clang, nacl_bootstrap_lib. The normal build process uses the CR_CLANG_REVISION define to make sure that things get rebuilt after a clang update. But nacl_bootstrap_lib removes all the default configs: https://cs.chromium.org/chromium/src/native_client/src/trusted/service_runtime/linux/BUILD.gn?q=%5Cbconfigs%5C+%3D%5C+%5C%5B%5C%5D++file:%5C.gn$&sq=package:chromium&l=61&dr=C So it doesn't get CR_CLANG_REVISION. https://chromium-review.googlesource.com/c/chromium/src/+/701643/ moved CR_CLANG_REVISION into its own config, but we didn't add that config to the list in https://cs.chromium.org/chromium/src/native_client/src/trusted/service_runtime/linux/BUILD.gn?type=cs&q=nacl_bootstrap_+file:%5C.gn&sq=package:chromium&g=0&l=65 yet. We still need to do this. Until then, the clang tot bots don't find clang regressions in this code, and nacl_bootstrap_lib isn't rebuilt after clang rolls (unless it's rebuilt for some other reason), which is also an issue for deterministic builds. (See also issue 771191 and https://chromium-review.googlesource.com/c/chromium/src/+/1387604/3#message-2938d88ecfb6d832299f01c4c10108374876cff5)
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9bedb2edb27d4fa3d6764d649bb385e3cb05e965 commit 9bedb2edb27d4fa3d6764d649bb385e3cb05e965 Author: Nico Weber <thakis@chromium.org> Date: Thu Jan 03 18:02:39 2019 Clean up deterministic build whitelist slightly. Remove a redundant entry, and add a dedicated bug line for nacl_helper_bootstrap now that I understand what's going on there. Bug: 918882 Change-Id: Id5c12c9096783dda98b9c80c4de0a9db860d1aa7 Reviewed-on: https://chromium-review.googlesource.com/c/1394707 Reviewed-by: Erik Chen <erikchen@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#619686} [modify] https://crrev.com/9bedb2edb27d4fa3d6764d649bb385e3cb05e965/tools/determinism/deterministic_build_whitelist.pyl
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/native_client/src/native_client.git/+/202ccbd707ded4002aa402b9da0ea4e4026f3a1d commit 202ccbd707ded4002aa402b9da0ea4e4026f3a1d Author: Nico Weber <thakis@chromium.org> Date: Thu Jan 03 18:16:57 2019 Make sure nacl_helper_bootstrap is rebuilt after clang rolls. Bug: chromium:918882 Change-Id: Ie9280cf5b3c83d753759486370a1e1c4da8f634c Reviewed-on: https://chromium-review.googlesource.com/c/1394437 Reviewed-by: Roland McGrath <mcgrathr@chromium.org> [modify] https://crrev.com/202ccbd707ded4002aa402b9da0ea4e4026f3a1d/src/trusted/service_runtime/linux/BUILD.gn
,
Jan 3
,
Jan 3
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/72821898cb126001fd1c02e566de424cc066ec2d commit 72821898cb126001fd1c02e566de424cc066ec2d Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Thu Jan 03 22:15:03 2019 Roll src/native_client 1e2123822ca7..202ccbd707de (1 commits) https://chromium.googlesource.com/native_client/src/native_client.git/+log/1e2123822ca7..202ccbd707de git log 1e2123822ca7..202ccbd707de --date=short --no-merges --format='%ad %ae %s' 2019-01-03 thakis@chromium.org Make sure nacl_helper_bootstrap is rebuilt after clang rolls. Created with: gclient setdep -r src/native_client@202ccbd707de The AutoRoll server is located here: https://autoroll.skia.org/r/nacl-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG= chromium:918882 TBR=mseaborn@chromium.org Change-Id: I4953c0a06f1fb13eaef95687ebf9e7bbf32a254b Reviewed-on: https://chromium-review.googlesource.com/c/1394690 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619778} [modify] https://crrev.com/72821898cb126001fd1c02e566de424cc066ec2d/DEPS
,
Jan 8
|
|||
►
Sign in to add a comment |
|||
Comment 1 by thakis@chromium.org
, Jan 3