CHECK failure: false in paint_controller.cc |
|||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=4873928503459840 Fuzzer: inferno_layout_test_unmodified Job Type: linux_msan_content_shell_drt Platform Id: linux Crash Type: CHECK failure Crash Address: Crash State: false in paint_controller.cc blink::PaintController::CheckUnderInvalidation blink::PaintController::ProcessNewItem Sanitizer: memory (MSAN) Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4873928503459840 Issue filed automatically. See https://www.chromium.org/developers/testing/memorysanitizer#TOC-Reproducing-ClusterFuzz-Bugs for instructions to reproduce this bug locally.
,
Jan 4
With reference to the Issue 894390 , assigning it to wangxianzhu@ for further triage.
,
Jan 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe023954ad31e422d0deb4116d7867098e11b688 commit fe023954ad31e422d0deb4116d7867098e11b688 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Tue Jan 08 22:58:56 2019 [PE] Fix background-image on ::first-line This CL ensures correct handling of background-image on ::first-line from style change to paint invalidation. Bug: 918881 Change-Id: I2e3a7bf60cb0f851b203fc7f5135c4186cc731a3 Reviewed-on: https://chromium-review.googlesource.com/c/1396154 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#620921} [modify] https://crrev.com/fe023954ad31e422d0deb4116d7867098e11b688/third_party/blink/renderer/core/layout/layout_block.cc [modify] https://crrev.com/fe023954ad31e422d0deb4116d7867098e11b688/third_party/blink/renderer/core/layout/layout_block.h [modify] https://crrev.com/fe023954ad31e422d0deb4116d7867098e11b688/third_party/blink/renderer/core/layout/layout_object.cc [modify] https://crrev.com/fe023954ad31e422d0deb4116d7867098e11b688/third_party/blink/renderer/core/layout/layout_object.h [modify] https://crrev.com/fe023954ad31e422d0deb4116d7867098e11b688/third_party/blink/renderer/core/paint/README.md [add] https://crrev.com/fe023954ad31e422d0deb4116d7867098e11b688/third_party/blink/web_tests/external/wpt/css/css-backgrounds/background-image-first-line.html [add] https://crrev.com/fe023954ad31e422d0deb4116d7867098e11b688/third_party/blink/web_tests/external/wpt/css/css-backgrounds/reference/background-image-first-line-ref.html
,
Jan 9
ClusterFuzz has detected this issue as fixed in range 620920:620921. Detailed report: https://clusterfuzz.com/testcase?key=4873928503459840 Fuzzer: inferno_layout_test_unmodified Job Type: linux_msan_content_shell_drt Platform Id: linux Crash Type: CHECK failure Crash Address: Crash State: false in paint_controller.cc blink::PaintController::CheckUnderInvalidation blink::PaintController::ProcessNewItem Sanitizer: memory (MSAN) Fixed: https://clusterfuzz.com/revisions?job=linux_msan_content_shell_drt&range=620920:620921 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4873928503459840 See https://www.chromium.org/developers/testing/memorysanitizer#TOC-Reproducing-ClusterFuzz-Bugs for instructions to reproduce this bug locally. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Jan 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b58524dfeb579392545998cbb64841138cc5a6e commit 3b58524dfeb579392545998cbb64841138cc5a6e Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Wed Jan 09 16:39:06 2019 Revert "[PE] Fix background-image on ::first-line" This reverts commit fe023954ad31e422d0deb4116d7867098e11b688. Reason for revert: crbug.com/920115 Bug: 920115 Original change's description: > [PE] Fix background-image on ::first-line > > This CL ensures correct handling of background-image on ::first-line > from style change to paint invalidation. > > Bug: 918881 > Change-Id: I2e3a7bf60cb0f851b203fc7f5135c4186cc731a3 > Reviewed-on: https://chromium-review.googlesource.com/c/1396154 > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#620921} TBR=wangxianzhu@chromium.org,futhark@chromium.org Change-Id: Iba8387598922eaccd35f44bcaceac1cff59ea83a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 918881 Reviewed-on: https://chromium-review.googlesource.com/c/1403315 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#621178} [modify] https://crrev.com/3b58524dfeb579392545998cbb64841138cc5a6e/third_party/blink/renderer/core/layout/layout_block.cc [modify] https://crrev.com/3b58524dfeb579392545998cbb64841138cc5a6e/third_party/blink/renderer/core/layout/layout_block.h [modify] https://crrev.com/3b58524dfeb579392545998cbb64841138cc5a6e/third_party/blink/renderer/core/layout/layout_object.cc [modify] https://crrev.com/3b58524dfeb579392545998cbb64841138cc5a6e/third_party/blink/renderer/core/layout/layout_object.h [modify] https://crrev.com/3b58524dfeb579392545998cbb64841138cc5a6e/third_party/blink/renderer/core/paint/README.md [delete] https://crrev.com/4aa6b2a04fd1602f3f60e6e45a19c29231154ef3/third_party/blink/web_tests/external/wpt/css/css-backgrounds/background-image-first-line.html [delete] https://crrev.com/4aa6b2a04fd1602f3f60e6e45a19c29231154ef3/third_party/blink/web_tests/external/wpt/css/css-backgrounds/reference/background-image-first-line-ref.html
,
Jan 9
ClusterFuzz testcase 4873928503459840 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Jan 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f6facb87f009321e336fea1db249ad41f4116bb8 commit f6facb87f009321e336fea1db249ad41f4116bb8 Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Sat Jan 12 07:56:53 2019 Reland "[PE] Fix background-image on ::first-line" This reverts commit 3b58524dfeb579392545998cbb64841138cc5a6e. The original patch failed to call RemoveClient for the background-image in the first line style. Original change's description: > Revert "[PE] Fix background-image on ::first-line" > > This reverts commit fe023954ad31e422d0deb4116d7867098e11b688. > > Reason for revert: crbug.com/920115 > > Bug: 920115 > > Original change's description: > > [PE] Fix background-image on ::first-line > > > > This CL ensures correct handling of background-image on ::first-line > > from style change to paint invalidation. > > > > Bug: 918881 > > Change-Id: I2e3a7bf60cb0f851b203fc7f5135c4186cc731a3 > > Reviewed-on: https://chromium-review.googlesource.com/c/1396154 > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#620921} > > TBR=wangxianzhu@chromium.org,futhark@chromium.org > > Change-Id: Iba8387598922eaccd35f44bcaceac1cff59ea83a > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 918881 > Reviewed-on: https://chromium-review.googlesource.com/c/1403315 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#621178} Bug: 920115, 918881 Change-Id: I3ea101ae09ad062de657a8917d77b1ec34e329e4 Reviewed-on: https://chromium-review.googlesource.com/c/1403316 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#622298} [modify] https://crrev.com/f6facb87f009321e336fea1db249ad41f4116bb8/third_party/blink/renderer/core/layout/layout_block.cc [modify] https://crrev.com/f6facb87f009321e336fea1db249ad41f4116bb8/third_party/blink/renderer/core/layout/layout_block.h [modify] https://crrev.com/f6facb87f009321e336fea1db249ad41f4116bb8/third_party/blink/renderer/core/layout/layout_object.cc [modify] https://crrev.com/f6facb87f009321e336fea1db249ad41f4116bb8/third_party/blink/renderer/core/layout/layout_object.h [modify] https://crrev.com/f6facb87f009321e336fea1db249ad41f4116bb8/third_party/blink/renderer/core/layout/layout_object_test.cc [modify] https://crrev.com/f6facb87f009321e336fea1db249ad41f4116bb8/third_party/blink/renderer/core/paint/README.md [add] https://crrev.com/f6facb87f009321e336fea1db249ad41f4116bb8/third_party/blink/web_tests/external/wpt/css/css-backgrounds/background-image-first-line.html [add] https://crrev.com/f6facb87f009321e336fea1db249ad41f4116bb8/third_party/blink/web_tests/external/wpt/css/css-backgrounds/reference/background-image-first-line-ref.html
,
Jan 12
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3edb3f1bbe315083871126bcbe4d422556b0d69f commit 3edb3f1bbe315083871126bcbe4d422556b0d69f Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Sat Jan 12 21:33:09 2019 Revert "Reland "[PE] Fix background-image on ::first-line"" This reverts commit f6facb87f009321e336fea1db249ad41f4116bb8. Reason for revert: Still can't ensure strictly paired AddClient/RemoveClient. Bug: 921337 ,921341 Original change's description: > Reland "[PE] Fix background-image on ::first-line" > > This reverts commit 3b58524dfeb579392545998cbb64841138cc5a6e. > > The original patch failed to call RemoveClient for the background-image > in the first line style. > > Original change's description: > > Revert "[PE] Fix background-image on ::first-line" > > > > This reverts commit fe023954ad31e422d0deb4116d7867098e11b688. > > > > Reason for revert: crbug.com/920115 > > > > Bug: 920115 > > > > Original change's description: > > > [PE] Fix background-image on ::first-line > > > > > > This CL ensures correct handling of background-image on ::first-line > > > from style change to paint invalidation. > > > > > > Bug: 918881 > > > Change-Id: I2e3a7bf60cb0f851b203fc7f5135c4186cc731a3 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1396154 > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#620921} > > > > TBR=wangxianzhu@chromium.org,futhark@chromium.org > > > > Change-Id: Iba8387598922eaccd35f44bcaceac1cff59ea83a > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 918881 > > Reviewed-on: https://chromium-review.googlesource.com/c/1403315 > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#621178} > > Bug: 920115, 918881 > Change-Id: I3ea101ae09ad062de657a8917d77b1ec34e329e4 > Reviewed-on: https://chromium-review.googlesource.com/c/1403316 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622298} TBR=wangxianzhu@chromium.org,futhark@chromium.org Change-Id: I6d31b858b2bf61bb123c6bdb09780f33e05b4878 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 920115, 918881 Reviewed-on: https://chromium-review.googlesource.com/c/1407974 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#622325} [modify] https://crrev.com/3edb3f1bbe315083871126bcbe4d422556b0d69f/third_party/blink/renderer/core/layout/layout_block.cc [modify] https://crrev.com/3edb3f1bbe315083871126bcbe4d422556b0d69f/third_party/blink/renderer/core/layout/layout_block.h [modify] https://crrev.com/3edb3f1bbe315083871126bcbe4d422556b0d69f/third_party/blink/renderer/core/layout/layout_object.cc [modify] https://crrev.com/3edb3f1bbe315083871126bcbe4d422556b0d69f/third_party/blink/renderer/core/layout/layout_object.h [modify] https://crrev.com/3edb3f1bbe315083871126bcbe4d422556b0d69f/third_party/blink/renderer/core/layout/layout_object_test.cc [modify] https://crrev.com/3edb3f1bbe315083871126bcbe4d422556b0d69f/third_party/blink/renderer/core/paint/README.md [delete] https://crrev.com/23fd0037212be010c7c7e7ac2d8480203b5c3653/third_party/blink/web_tests/external/wpt/css/css-backgrounds/background-image-first-line.html [delete] https://crrev.com/23fd0037212be010c7c7e7ac2d8480203b5c3653/third_party/blink/web_tests/external/wpt/css/css-backgrounds/reference/background-image-first-line-ref.html
,
Jan 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bd339720737e44c9d730bb8a71990f30f6dd4ccf commit bd339720737e44c9d730bb8a71990f30f6dd4ccf Author: Xianzhu Wang <wangxianzhu@chromium.org> Date: Mon Jan 14 19:11:38 2019 Reland "Reland "[PE] Fix background-image on ::first-line"" This reverts commit 3edb3f1bbe315083871126bcbe4d422556b0d69f. Fix by moving UpdateFirstLineImageObservers() from CachedFirstLineStyle() into GetCachedPseudoStyle() to ensure we update image observers for the correct object. Original change's description: > Revert "Reland "[PE] Fix background-image on ::first-line"" > > This reverts commit f6facb87f009321e336fea1db249ad41f4116bb8. > > Reason for revert: Still can't ensure strictly paired AddClient/RemoveClient. > > Bug: 921337 ,921341 > > Original change's description: > > Reland "[PE] Fix background-image on ::first-line" > > > > This reverts commit 3b58524dfeb579392545998cbb64841138cc5a6e. > > > > The original patch failed to call RemoveClient for the background-image > > in the first line style. > > > > Original change's description: > > > Revert "[PE] Fix background-image on ::first-line" > > > > > > This reverts commit fe023954ad31e422d0deb4116d7867098e11b688. > > > > > > Reason for revert: crbug.com/920115 > > > > > > Bug: 920115 > > > > > > Original change's description: > > > > [PE] Fix background-image on ::first-line > > > > > > > > This CL ensures correct handling of background-image on ::first-line > > > > from style change to paint invalidation. > > > > > > > > Bug: 918881 > > > > Change-Id: I2e3a7bf60cb0f851b203fc7f5135c4186cc731a3 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1396154 > > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#620921} > > > > > > TBR=wangxianzhu@chromium.org,futhark@chromium.org > > > > > > Change-Id: Iba8387598922eaccd35f44bcaceac1cff59ea83a > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 918881 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1403315 > > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#621178} > > > > Bug: 920115, 918881 > > Change-Id: I3ea101ae09ad062de657a8917d77b1ec34e329e4 > > Reviewed-on: https://chromium-review.googlesource.com/c/1403316 > > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#622298} > > TBR=wangxianzhu@chromium.org,futhark@chromium.org > > Change-Id: I6d31b858b2bf61bb123c6bdb09780f33e05b4878 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 920115, 918881 > Reviewed-on: https://chromium-review.googlesource.com/c/1407974 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622325} Change-Id: I2509073937be3b1eb8f4bdc0d6f5151c93253851 Bug: 921337 , 921341, 920115, 918881 Reviewed-on: https://chromium-review.googlesource.com/c/1408358 Reviewed-by: Rune Lillesveen <futhark@chromium.org> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#622542} [modify] https://crrev.com/bd339720737e44c9d730bb8a71990f30f6dd4ccf/third_party/blink/renderer/core/layout/layout_block.cc [modify] https://crrev.com/bd339720737e44c9d730bb8a71990f30f6dd4ccf/third_party/blink/renderer/core/layout/layout_block.h [modify] https://crrev.com/bd339720737e44c9d730bb8a71990f30f6dd4ccf/third_party/blink/renderer/core/layout/layout_object.cc [modify] https://crrev.com/bd339720737e44c9d730bb8a71990f30f6dd4ccf/third_party/blink/renderer/core/layout/layout_object.h [modify] https://crrev.com/bd339720737e44c9d730bb8a71990f30f6dd4ccf/third_party/blink/renderer/core/layout/layout_object_test.cc [modify] https://crrev.com/bd339720737e44c9d730bb8a71990f30f6dd4ccf/third_party/blink/renderer/core/paint/README.md [add] https://crrev.com/bd339720737e44c9d730bb8a71990f30f6dd4ccf/third_party/blink/web_tests/external/wpt/css/css-backgrounds/background-image-first-line.html [add] https://crrev.com/bd339720737e44c9d730bb8a71990f30f6dd4ccf/third_party/blink/web_tests/external/wpt/css/css-backgrounds/reference/background-image-first-line-ref.html
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36dab48068086f08eacf7f283293d6ce49493440 commit 36dab48068086f08eacf7f283293d6ce49493440 Author: Dominic Battré <battre@chromium.org> Date: Tue Jan 15 08:59:16 2019 Revert "Reland "Reland "[PE] Fix background-image on ::first-line""" This reverts commit bd339720737e44c9d730bb8a71990f30f6dd4ccf. Reason for revert: test still failing, see crbug.com/920115 Original change's description: > Reland "Reland "[PE] Fix background-image on ::first-line"" > > This reverts commit 3edb3f1bbe315083871126bcbe4d422556b0d69f. > > Fix by moving UpdateFirstLineImageObservers() from > CachedFirstLineStyle() into GetCachedPseudoStyle() to ensure > we update image observers for the correct object. > > Original change's description: > > Revert "Reland "[PE] Fix background-image on ::first-line"" > > > > This reverts commit f6facb87f009321e336fea1db249ad41f4116bb8. > > > > Reason for revert: Still can't ensure strictly paired AddClient/RemoveClient. > > > > Bug: 921337 ,921341 > > > > Original change's description: > > > Reland "[PE] Fix background-image on ::first-line" > > > > > > This reverts commit 3b58524dfeb579392545998cbb64841138cc5a6e. > > > > > > The original patch failed to call RemoveClient for the background-image > > > in the first line style. > > > > > > Original change's description: > > > > Revert "[PE] Fix background-image on ::first-line" > > > > > > > > This reverts commit fe023954ad31e422d0deb4116d7867098e11b688. > > > > > > > > Reason for revert: crbug.com/920115 > > > > > > > > Bug: 920115 > > > > > > > > Original change's description: > > > > > [PE] Fix background-image on ::first-line > > > > > > > > > > This CL ensures correct handling of background-image on ::first-line > > > > > from style change to paint invalidation. > > > > > > > > > > Bug: 918881 > > > > > Change-Id: I2e3a7bf60cb0f851b203fc7f5135c4186cc731a3 > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1396154 > > > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > > > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#620921} > > > > > > > > TBR=wangxianzhu@chromium.org,futhark@chromium.org > > > > > > > > Change-Id: Iba8387598922eaccd35f44bcaceac1cff59ea83a > > > > No-Presubmit: true > > > > No-Tree-Checks: true > > > > No-Try: true > > > > Bug: 918881 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1403315 > > > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#621178} > > > > > > Bug: 920115, 918881 > > > Change-Id: I3ea101ae09ad062de657a8917d77b1ec34e329e4 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1403316 > > > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#622298} > > > > TBR=wangxianzhu@chromium.org,futhark@chromium.org > > > > Change-Id: I6d31b858b2bf61bb123c6bdb09780f33e05b4878 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 920115, 918881 > > Reviewed-on: https://chromium-review.googlesource.com/c/1407974 > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#622325} > > Change-Id: I2509073937be3b1eb8f4bdc0d6f5151c93253851 > Bug: 921337 , 921341, 920115, 918881 > Reviewed-on: https://chromium-review.googlesource.com/c/1408358 > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622542} TBR=wangxianzhu@chromium.org,futhark@chromium.org Change-Id: I3f5aca68d9e5e739f262187171530fc718ff71a9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 921337 , 921341, 920115, 918881 Reviewed-on: https://chromium-review.googlesource.com/c/1411534 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#622787} [modify] https://crrev.com/36dab48068086f08eacf7f283293d6ce49493440/third_party/blink/renderer/core/layout/layout_block.cc [modify] https://crrev.com/36dab48068086f08eacf7f283293d6ce49493440/third_party/blink/renderer/core/layout/layout_block.h [modify] https://crrev.com/36dab48068086f08eacf7f283293d6ce49493440/third_party/blink/renderer/core/layout/layout_object.cc [modify] https://crrev.com/36dab48068086f08eacf7f283293d6ce49493440/third_party/blink/renderer/core/layout/layout_object.h [modify] https://crrev.com/36dab48068086f08eacf7f283293d6ce49493440/third_party/blink/renderer/core/layout/layout_object_test.cc [modify] https://crrev.com/36dab48068086f08eacf7f283293d6ce49493440/third_party/blink/renderer/core/paint/README.md [delete] https://crrev.com/9f461d7b2b9eb0a8e42e948363dbdebfaf75fbfc/third_party/blink/web_tests/external/wpt/css/css-backgrounds/background-image-first-line.html [delete] https://crrev.com/9f461d7b2b9eb0a8e42e948363dbdebfaf75fbfc/third_party/blink/web_tests/external/wpt/css/css-backgrounds/reference/background-image-first-line-ref.html
,
Jan 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ac2dc886674e80d0ca221a4042a83f47ac0ed162 commit ac2dc886674e80d0ca221a4042a83f47ac0ed162 Author: Dominic Battré <battre@chromium.org> Date: Tue Jan 15 10:12:26 2019 Reland "Reland "Reland "[PE] Fix background-image on ::first-line""" This reverts commit 36dab48068086f08eacf7f283293d6ce49493440. Reason for revert: Reverting broke the compilation. A broken test is better than a non-compiling tree. Original change's description: > Revert "Reland "Reland "[PE] Fix background-image on ::first-line""" > > This reverts commit bd339720737e44c9d730bb8a71990f30f6dd4ccf. > > Reason for revert: test still failing, see crbug.com/920115 > > Original change's description: > > Reland "Reland "[PE] Fix background-image on ::first-line"" > > > > This reverts commit 3edb3f1bbe315083871126bcbe4d422556b0d69f. > > > > Fix by moving UpdateFirstLineImageObservers() from > > CachedFirstLineStyle() into GetCachedPseudoStyle() to ensure > > we update image observers for the correct object. > > > > Original change's description: > > > Revert "Reland "[PE] Fix background-image on ::first-line"" > > > > > > This reverts commit f6facb87f009321e336fea1db249ad41f4116bb8. > > > > > > Reason for revert: Still can't ensure strictly paired AddClient/RemoveClient. > > > > > > Bug: 921337 ,921341 > > > > > > Original change's description: > > > > Reland "[PE] Fix background-image on ::first-line" > > > > > > > > This reverts commit 3b58524dfeb579392545998cbb64841138cc5a6e. > > > > > > > > The original patch failed to call RemoveClient for the background-image > > > > in the first line style. > > > > > > > > Original change's description: > > > > > Revert "[PE] Fix background-image on ::first-line" > > > > > > > > > > This reverts commit fe023954ad31e422d0deb4116d7867098e11b688. > > > > > > > > > > Reason for revert: crbug.com/920115 > > > > > > > > > > Bug: 920115 > > > > > > > > > > Original change's description: > > > > > > [PE] Fix background-image on ::first-line > > > > > > > > > > > > This CL ensures correct handling of background-image on ::first-line > > > > > > from style change to paint invalidation. > > > > > > > > > > > > Bug: 918881 > > > > > > Change-Id: I2e3a7bf60cb0f851b203fc7f5135c4186cc731a3 > > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1396154 > > > > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > > > > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > > > > > > Cr-Commit-Position: refs/heads/master@{#620921} > > > > > > > > > > TBR=wangxianzhu@chromium.org,futhark@chromium.org > > > > > > > > > > Change-Id: Iba8387598922eaccd35f44bcaceac1cff59ea83a > > > > > No-Presubmit: true > > > > > No-Tree-Checks: true > > > > > No-Try: true > > > > > Bug: 918881 > > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1403315 > > > > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > > > Cr-Commit-Position: refs/heads/master@{#621178} > > > > > > > > Bug: 920115, 918881 > > > > Change-Id: I3ea101ae09ad062de657a8917d77b1ec34e329e4 > > > > Reviewed-on: https://chromium-review.googlesource.com/c/1403316 > > > > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > > Cr-Commit-Position: refs/heads/master@{#622298} > > > > > > TBR=wangxianzhu@chromium.org,futhark@chromium.org > > > > > > Change-Id: I6d31b858b2bf61bb123c6bdb09780f33e05b4878 > > > No-Presubmit: true > > > No-Tree-Checks: true > > > No-Try: true > > > Bug: 920115, 918881 > > > Reviewed-on: https://chromium-review.googlesource.com/c/1407974 > > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#622325} > > > > Change-Id: I2509073937be3b1eb8f4bdc0d6f5151c93253851 > > Bug: 921337 , 921341, 920115, 918881 > > Reviewed-on: https://chromium-review.googlesource.com/c/1408358 > > Reviewed-by: Rune Lillesveen <futhark@chromium.org> > > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#622542} > > TBR=wangxianzhu@chromium.org,futhark@chromium.org > > Change-Id: I3f5aca68d9e5e739f262187171530fc718ff71a9 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 921337 , 921341, 920115, 918881 > Reviewed-on: https://chromium-review.googlesource.com/c/1411534 > Reviewed-by: Dominic Battré <battre@chromium.org> > Commit-Queue: Dominic Battré <battre@chromium.org> > Cr-Commit-Position: refs/heads/master@{#622787} TBR=wangxianzhu@chromium.org,battre@chromium.org,futhark@chromium.org Change-Id: I46dca78e51fe16ff7091674028b184a6d7cc1b83 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 921337 , 921341, 920115, 918881 Reviewed-on: https://chromium-review.googlesource.com/c/1411595 Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#622796} [modify] https://crrev.com/ac2dc886674e80d0ca221a4042a83f47ac0ed162/third_party/blink/renderer/core/layout/layout_block.cc [modify] https://crrev.com/ac2dc886674e80d0ca221a4042a83f47ac0ed162/third_party/blink/renderer/core/layout/layout_block.h [modify] https://crrev.com/ac2dc886674e80d0ca221a4042a83f47ac0ed162/third_party/blink/renderer/core/layout/layout_object.cc [modify] https://crrev.com/ac2dc886674e80d0ca221a4042a83f47ac0ed162/third_party/blink/renderer/core/layout/layout_object.h [modify] https://crrev.com/ac2dc886674e80d0ca221a4042a83f47ac0ed162/third_party/blink/renderer/core/layout/layout_object_test.cc [modify] https://crrev.com/ac2dc886674e80d0ca221a4042a83f47ac0ed162/third_party/blink/renderer/core/paint/README.md [add] https://crrev.com/ac2dc886674e80d0ca221a4042a83f47ac0ed162/third_party/blink/web_tests/external/wpt/css/css-backgrounds/background-image-first-line.html [add] https://crrev.com/ac2dc886674e80d0ca221a4042a83f47ac0ed162/third_party/blink/web_tests/external/wpt/css/css-backgrounds/reference/background-image-first-line-ref.html |
|||
►
Sign in to add a comment |
|||
Comment 1 by ClusterFuzz
, Jan 3