New issue
Advanced search Search tips

Issue 918865 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Remove possible_browser.IsRemote/RunRemote

Project Member Reported by perezju@chromium.org, Jan 3

Issue description

These used to allow running perf try jobs, but that functionality
has been removed. Nothing sets IsRemote to anything other than False.

c.f.:
https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/browser/possible_browser.py?rcl=d9f036200e10164c1e67f6d1a083a9ed750e41a7&l=131

Found these while doing other cleanup for  issue 851948 
 
If we wanted to make try jobs work again, I imagine we wouldn't need this anyways?

I have been thinking a little bit about how it might be nice for our try system to work the same way that the rest of Chromium's does (using standard LUCI configuration files). An optional trybot on gerrit that gets auto-added when you make changes in src/tools/perf code would be nice to test benchmark changes/additions before they are submitted. But I don't think we would need IsRemote or RunRemote for this job.
Yes, exactly. An implementation for perf try jobs would look different now, and not depend on these.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/67c39d6acc91227776aa26f91c85f6c75eba20d8

commit 67c39d6acc91227776aa26f91c85f6c75eba20d8
Author: Juan Antonio Navarro Perez <perezju@chromium.org>
Date: Mon Jan 07 12:32:48 2019

[Telemetry] Remove possible_browser.IsRemote/RunRemote

These are a left over from functionality used in the past to implement
perf try jobs. No longer needed and, if we were to implement perf try
jobs again, a different approach based on pinpoint_cli would be used
instead.

Bug:  chromium:918865 
Change-Id: I471cb177d45e4d8e806a4c243778b512d2039111
Reviewed-on: https://chromium-review.googlesource.com/c/1396158
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>

[modify] https://crrev.com/67c39d6acc91227776aa26f91c85f6c75eba20d8/telemetry/telemetry/internal/browser/possible_browser.py
[modify] https://crrev.com/67c39d6acc91227776aa26f91c85f6c75eba20d8/telemetry/telemetry/testing/fakes/__init__.py
[modify] https://crrev.com/67c39d6acc91227776aa26f91c85f6c75eba20d8/telemetry/telemetry/page/shared_page_state.py

Status: Fixed (was: Started)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2160b14896e8860ebaca9bcc0452f5a74e0684ef

commit 2160b14896e8860ebaca9bcc0452f5a74e0684ef
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Mon Jan 07 13:36:39 2019

Roll src/third_party/catapult b82ebb6bf227..67c39d6acc91 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/b82ebb6bf227..67c39d6acc91


git log b82ebb6bf227..67c39d6acc91 --date=short --no-merges --format='%ad %ae %s'
2019-01-07 perezju@chromium.org [Telemetry] Remove possible_browser.IsRemote/RunRemote


Created with:
  gclient setdep -r src/third_party/catapult@67c39d6acc91

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:918865 
TBR=sullivan@chromium.org

Change-Id: I3a06e9a830b3d317747e94955036cc9c4832c1ea
Reviewed-on: https://chromium-review.googlesource.com/c/1397862
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#620308}
[modify] https://crrev.com/2160b14896e8860ebaca9bcc0452f5a74e0684ef/DEPS

Comment 7 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 8 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment