This is a bug to collect CLs that target the improvement of metrics for the password manager.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f468aee16fd2d272c7eff623d3203879b7ef8c10 commit f468aee16fd2d272c7eff623d3203879b7ef8c10 Author: Dominic Battre <battre@chromium.org> Date: Fri Jan 04 12:23:06 2019 Record reasons for failing to fill in the renderer This CL introduces a new UMA metric PasswordManager.FirstRendererFillingResult to record cases where the browser process instructed the renderer to fill credentials into a form but the renderer fails to fill the credentials. We record the metrics to understand why we fail to fill and prioritize our efforts. This is currently a blind spot. Bug: 918846 Change-Id: Ia146861e3d0056cff2ced970175ea377b687da61 Reviewed-on: https://chromium-review.googlesource.com/c/1394313 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#619920} [modify] https://crrev.com/f468aee16fd2d272c7eff623d3203879b7ef8c10/chrome/renderer/autofill/password_autofill_agent_browsertest.cc [modify] https://crrev.com/f468aee16fd2d272c7eff623d3203879b7ef8c10/components/autofill/content/renderer/password_autofill_agent.cc [modify] https://crrev.com/f468aee16fd2d272c7eff623d3203879b7ef8c10/components/autofill/content/renderer/password_autofill_agent.h [modify] https://crrev.com/f468aee16fd2d272c7eff623d3203879b7ef8c10/tools/metrics/histograms/enums.xml [modify] https://crrev.com/f468aee16fd2d272c7eff623d3203879b7ef8c10/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8baa20d90ca4d61dc4939f563326b40b55a50f2c commit 8baa20d90ca4d61dc4939f563326b40b55a50f2c Author: Dominic Battre <battre@chromium.org> Date: Tue Jan 08 08:10:04 2019 Metrics on why browser instructs not to fill credentials on page load This CL introduce a new UMA metric PasswordManager.FirstWaitForUsernameReason. It records the reason why the browser instructs the renderer not to fill credentials on page load but only after the user confirms the credential by clicking on a username in a popup. This is only recorded the first time, the browser intents to fill a specific form. The metric fills a blind spot in PasswordManager.FirstRendererFillingResult. Bug: 918846 Change-Id: If4bcce1f04a16bfed9a267f04b5dca22b665afd4 Reviewed-on: https://chromium-review.googlesource.com/c/1396143 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#620653} [modify] https://crrev.com/8baa20d90ca4d61dc4939f563326b40b55a50f2c/components/autofill/content/renderer/password_autofill_agent.h [modify] https://crrev.com/8baa20d90ca4d61dc4939f563326b40b55a50f2c/components/password_manager/core/browser/password_form_filling.cc [modify] https://crrev.com/8baa20d90ca4d61dc4939f563326b40b55a50f2c/components/password_manager/core/browser/password_form_metrics_recorder.cc [modify] https://crrev.com/8baa20d90ca4d61dc4939f563326b40b55a50f2c/components/password_manager/core/browser/password_form_metrics_recorder.h [modify] https://crrev.com/8baa20d90ca4d61dc4939f563326b40b55a50f2c/tools/metrics/histograms/enums.xml [modify] https://crrev.com/8baa20d90ca4d61dc4939f563326b40b55a50f2c/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d2801e04476adde3a973d22e589e1d5c5303abc5 commit d2801e04476adde3a973d22e589e1d5c5303abc5 Author: Dominic Battre <battre@chromium.org> Date: Tue Jan 08 14:31:07 2019 Fix <enum name='PasswordManagerFirstRendererFillingResult'> The descriptions of labels got shifted. This CL fixes that so that the descriptions fit the labels. Bug: 918846 Change-Id: I993aff7db247a1167d6d7e7d44e5d1f1c4939a91 Reviewed-on: https://chromium-review.googlesource.com/c/1400690 Commit-Queue: Dominic Battré <battre@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#620711} [modify] https://crrev.com/d2801e04476adde3a973d22e589e1d5c5303abc5/components/autofill/content/renderer/password_autofill_agent.h [modify] https://crrev.com/d2801e04476adde3a973d22e589e1d5c5303abc5/tools/metrics/histograms/enums.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6f29fd09de964affa436385a66017ae6c9dddbae commit 6f29fd09de964affa436385a66017ae6c9dddbae Author: Dominic Battre <battre@chromium.org> Date: Thu Jan 10 15:27:52 2019 Record wait_for_username and bail for NewPasswordFormManager If the NewPasswordFormManager instructs the PasswordAutofillAgent to wait for the user to confirm filling the password, we need to log this as for the old PasswordFormManager. I have verified that the new metrics are recorded and that PSL matched filling continues to work. Bug: 918846 Change-Id: I010500bedd0c3a7c462074f2c7dcd70b4cc7a0b4 Reviewed-on: https://chromium-review.googlesource.com/c/1404092 Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#621586} [modify] https://crrev.com/6f29fd09de964affa436385a66017ae6c9dddbae/components/autofill/content/renderer/password_autofill_agent.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/37ec544ac1bb60d128749d2d0c6f785b4176a0d3 commit 37ec544ac1bb60d128749d2d0c6f785b4176a0d3 Author: Vadym Doroshenko <dvadym@chromium.org> Date: Fri Jan 11 07:40:18 2019 PasswordManager.FillingAssistance UMA metric implementation. This metrics tries to understand how good is Chrome Password Manager in helping the user to sign in. It's recorded only on submissions that are considered to be successful. This CL contains: 1.Implementation the metric calculation in PasswordFormManagerRecorder 2.Propagating all necessary information for calculation. Bug: 918846 Change-Id: I53d71a2dcad0c33480157d69e275047138d2df0f Reviewed-on: https://chromium-review.googlesource.com/c/1400691 Reviewed-by: Ilya Sherman <isherman@chromium.org> Reviewed-by: Dominic Battré <battre@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#621939} [modify] https://crrev.com/37ec544ac1bb60d128749d2d0c6f785b4176a0d3/components/password_manager/core/browser/fake_form_fetcher.cc [modify] https://crrev.com/37ec544ac1bb60d128749d2d0c6f785b4176a0d3/components/password_manager/core/browser/fake_form_fetcher.h [modify] https://crrev.com/37ec544ac1bb60d128749d2d0c6f785b4176a0d3/components/password_manager/core/browser/form_fetcher.h [modify] https://crrev.com/37ec544ac1bb60d128749d2d0c6f785b4176a0d3/components/password_manager/core/browser/form_fetcher_impl.cc [modify] https://crrev.com/37ec544ac1bb60d128749d2d0c6f785b4176a0d3/components/password_manager/core/browser/form_fetcher_impl.h [modify] https://crrev.com/37ec544ac1bb60d128749d2d0c6f785b4176a0d3/components/password_manager/core/browser/new_password_form_manager.cc [modify] https://crrev.com/37ec544ac1bb60d128749d2d0c6f785b4176a0d3/components/password_manager/core/browser/new_password_form_manager.h [modify] https://crrev.com/37ec544ac1bb60d128749d2d0c6f785b4176a0d3/components/password_manager/core/browser/new_password_form_manager_unittest.cc [modify] https://crrev.com/37ec544ac1bb60d128749d2d0c6f785b4176a0d3/components/password_manager/core/browser/password_form_metrics_recorder.cc [modify] https://crrev.com/37ec544ac1bb60d128749d2d0c6f785b4176a0d3/components/password_manager/core/browser/password_form_metrics_recorder.h [modify] https://crrev.com/37ec544ac1bb60d128749d2d0c6f785b4176a0d3/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc [modify] https://crrev.com/37ec544ac1bb60d128749d2d0c6f785b4176a0d3/tools/metrics/histograms/enums.xml [modify] https://crrev.com/37ec544ac1bb60d128749d2d0c6f785b4176a0d3/tools/metrics/histograms/histograms.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a35313b247cab15d31ccb4339be16591c5f9e79b commit a35313b247cab15d31ccb4339be16591c5f9e79b Author: Dominic Battre <battre@chromium.org> Date: Mon Jan 14 16:41:47 2019 Record UKM for PasswordManager.FirstFillingResult This implements a UKM for the UMA metric PasswordManager.FirstFillingResult to discover locations from which we receive unexpected results. Bug: 918846 Change-Id: I77c32e64a173be6f6ee557874db7f931e02547f2 Reviewed-on: https://chromium-review.googlesource.com/c/1402892 Reviewed-by: Mike West <mkwst@chromium.org> Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#622474} [modify] https://crrev.com/a35313b247cab15d31ccb4339be16591c5f9e79b/chrome/browser/password_manager/chrome_password_manager_client.cc [modify] https://crrev.com/a35313b247cab15d31ccb4339be16591c5f9e79b/chrome/browser/password_manager/chrome_password_manager_client.h [modify] https://crrev.com/a35313b247cab15d31ccb4339be16591c5f9e79b/chrome/renderer/autofill/fake_mojo_password_manager_driver.h [modify] https://crrev.com/a35313b247cab15d31ccb4339be16591c5f9e79b/components/autofill/content/common/autofill_driver.mojom [modify] https://crrev.com/a35313b247cab15d31ccb4339be16591c5f9e79b/components/autofill/content/renderer/password_autofill_agent.cc [modify] https://crrev.com/a35313b247cab15d31ccb4339be16591c5f9e79b/components/autofill/content/renderer/password_autofill_agent.h [modify] https://crrev.com/a35313b247cab15d31ccb4339be16591c5f9e79b/components/autofill/content/renderer/renderer_save_password_progress_logger_unittest.cc [modify] https://crrev.com/a35313b247cab15d31ccb4339be16591c5f9e79b/components/password_manager/core/browser/new_password_form_manager.cc [modify] https://crrev.com/a35313b247cab15d31ccb4339be16591c5f9e79b/components/password_manager/core/browser/new_password_form_manager.h [modify] https://crrev.com/a35313b247cab15d31ccb4339be16591c5f9e79b/components/password_manager/core/browser/password_form_metrics_recorder.cc [modify] https://crrev.com/a35313b247cab15d31ccb4339be16591c5f9e79b/components/password_manager/core/browser/password_form_metrics_recorder.h [modify] https://crrev.com/a35313b247cab15d31ccb4339be16591c5f9e79b/components/password_manager/core/browser/password_manager.cc [modify] https://crrev.com/a35313b247cab15d31ccb4339be16591c5f9e79b/components/password_manager/core/browser/password_manager.h [modify] https://crrev.com/a35313b247cab15d31ccb4339be16591c5f9e79b/tools/metrics/histograms/histograms.xml [modify] https://crrev.com/a35313b247cab15d31ccb4339be16591c5f9e79b/tools/metrics/ukm/ukm.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/89f9ec826716bb159aee4bb70a6ebf86e6666c70 commit 89f9ec826716bb159aee4bb70a6ebf86e6666c70 Author: Dominic Battre <battre@chromium.org> Date: Thu Jan 17 21:26:37 2019 Improve documentation for PasswordManager.FillingAssistance This CL is a followup on some pending comments of https://chromium-review.googlesource.com/c/chromium/src/+/1400691 Bug: 918846 Change-Id: If85bca85dd846539d3906b20fe16d31ae777f842 Reviewed-on: https://chromium-review.googlesource.com/c/1406712 Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#623852} [modify] https://crrev.com/89f9ec826716bb159aee4bb70a6ebf86e6666c70/components/password_manager/core/browser/password_form_metrics_recorder.cc [modify] https://crrev.com/89f9ec826716bb159aee4bb70a6ebf86e6666c70/components/password_manager/core/browser/password_form_metrics_recorder.h [modify] https://crrev.com/89f9ec826716bb159aee4bb70a6ebf86e6666c70/components/password_manager/core/browser/password_form_metrics_recorder_unittest.cc [modify] https://crrev.com/89f9ec826716bb159aee4bb70a6ebf86e6666c70/tools/metrics/histograms/enums.xml [modify] https://crrev.com/89f9ec826716bb159aee4bb70a6ebf86e6666c70/tools/metrics/histograms/histograms.xml
Comment 1 by bugdroid1@chromium.org
, Jan 4