New issue
Advanced search Search tips

Issue 918828 link

Starred by 1 user
Status: Fixed
Owner:
pbos@chromium.org
Closed: Jan 9
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression:Grey Focus is seen chopped on the 'Open as window' option for shortcut window.

Project Member Reported by shru...@virtusa.com, Jan 3 
Chrome version: 73.0.3660.0 (Official Build) Revision 170f55273fbe689f402eade1a4e98fa2788938a2-refs/branch-heads/3660@{#1} (32/64 bit)
OS : Mac(10.13.6, 10.13.1, 10.14.3) Windows(7,8,10) and Linux(14.04 LTS) .

Steps to reproduce:
1. Launch chrome and Navigate to youtube.com.
2. Open wrench menu and under 'More Tools' ,click on 'Create Shortcut'.
3.'Create Shortcut' Dialogue will open ,
4. Click and Hold Mouse on the 'Open as window' option and Observe.
 
Actual Result   : Grey Focus is seen chopped on the 'Open as window' option.
Expected Result : Grey Focus should be seen properly  on the 'Open as window' option.

This is a regression issue broken in M-73 and will soon update bisect information:
Good Build :73.0.3659.0
Bad Build : 73.0.3660.0


Kindly refer the screen-cast from drive link.
https://drive.google.com/open?id=14HjcWrEL2Bg_IMKatD3dnoVx3OaH_74A
Thank You.

Comment 1 by shru...@virtusa.com, Jan 3

Labels: hasbisect
Owner: pbos@chromium.org
Status: Assigned (was: Unconfirmed)
Update :
Bisect-info:
https://chromium.googlesource.com/chromium/src/+log/73.0.3659.0..73.0.3660.0?pretty=fuller&n=10000  
Suspect:r 619533?

@Peter Boström: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: 
1. Unable to provide 'per-revision' bisect as it shows "We don't have enough builds to bisect" error message for above range. (tried on other machines but still getting the same error again)
2. Hence providing suspect via perform Chromium bisect .

Thank You...
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 9 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/225e49786806971237388ee8dbf2ed7e8a186599

commit 225e49786806971237388ee8dbf2ed7e8a186599
Author: Peter Boström <pbos@chromium.org>
Date: Wed Jan 09 02:28:28 2019

Remove InkDropMask for views::Checkbox

By default inkdrops are masked to their focus-ring shape. The ink-drop
ripple for Checkbox explodes outside its bounds and shouldn't be clipped
by them.

Bug:  chromium:918828 
Change-Id: Id90c266017c8e459374d00291217752cdeb2fc95
Reviewed-on: https://chromium-review.googlesource.com/c/1401614
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621005}
[modify] https://crrev.com/225e49786806971237388ee8dbf2ed7e8a186599/ui/views/controls/button/checkbox.cc
[modify] https://crrev.com/225e49786806971237388ee8dbf2ed7e8a186599/ui/views/controls/button/checkbox.h

Comment 3 by pbos@chromium.org, Jan 9

Status: Fixed (was: Assigned)

Comment 4 by shru...@virtusa.com, Jan 10

Labels: TE-Verified-M73 TE-Verified-73.0.3667.0
Update:
Retested above issue on  OS : Mac(10.13.6, 10.13.1, 10.14.3), Windows(7,8,10) and Linux(14.04 LTS)using latest Canary #73.0.3667.0 issue is fixed.
Now, Focus is seen properly  on the 'Open as window' option.
Kindly review the attached screen-cast.

Thank you!
Canary#73.0.3667.0.mov
5.6 MB View Download
►

Sign in to add a comment