New issue
Advanced search Search tips

Issue 918824 link

Starred by 1 user
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Jan 5
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview] Colour of the focus ring is not seen as expected i.e. blue colour

Project Member Reported by khush...@virtusa.com, Jan 3 
Chrome version: 73.0.3660.0 (Official Build) Revision 170f55273fbe689f402eade1a4e98fa2788938a2-refs/branch-heads/3660@{#1} (32/64 bit)

OS: Windows (7, 8, 8.1, 10) and Linux (14.04 LTS)

What steps will reproduce the problem?
(1) Launch chrome and press 'Ctrl+P' to open Print Preview.
(2) Press 'Tab' key to traverse the focus over 'Change' button.
(3) Observe the colour of focus ring.

Actual Result: Colour of the focus ring is not seen as expected.

Expected Result: Colour of the focus ring should be seen in blue colour.

This is a regression issue broken in ‘M-73’ and will soon update the bisect info:
Good build: 73.0.3659.0 (Revision: 619364)
Bad build:  73.0.3660.0 (Revision: 619561)

Kindly refer the attached screen-cast.

Thank You..!!
Actual Focus.mp4
570 KB View Download
Expected Focus.mp4
307 KB View Download

Comment 1 by khush...@virtusa.com, Jan 3

Labels: hasbisect
Owner: dbeam@chromium.org
Status: Assigned (was: Unconfirmed)
Update:

[Unable to provide bisect using Per-revision script as "Error running the gsutil command: AccessDeniedException: 403 rkote@etouch.net does not have storage.objects.list access to chrome-test-builds." error message is thrown. Hence, providing suspect using chromium bisect.]

Chromium Bisect URL:

https://chromium.googlesource.com/chromium/src/+log/b8d3a7757f252b2c69586d683243a64dac4c4c36..eae570f9546e087bbf584a502808ff5c13571634

Suspecting: https://chromium.googlesource.com/chromium/src/+/eae570f9546e087bbf584a502808ff5c13571634 ??

@dbeam: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: Issue is also seen on Mac (10.13.1, 10.13.6, 10.14.2) OS.

Kindly refer the attached screen-cast.

Thank You..!!

Comment 2 by dbeam@chromium.org, Jan 3

Status: Started (was: Assigned)
yeah, probably me
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/59a719ee7f6de6439a11700db1b75266ddc8b445

commit 59a719ee7f6de6439a11700db1b75266ddc8b445
Author: Dan Beam <dbeam@chromium.org>
Date: Sat Jan 05 01:20:47 2019

Fix color problem with active paper-button

In https://crrev.com/c/1393442, I changed this code:

  /* Google Blue 900 with 40% opacity. */
  box-shadow: 0 0 0 2px rgba(26, 115, 232, 0.4);

to

  box-shadow: 0 0 0 2px rgba(var(--google-blue-900-rgb), 0.4);

Unfortunately, the comment read "900", but it was actually "600".

So I fixed that (and checked that "26, 115, 232" is google-blue-600
in shared_vars_css.html) and also converted another duplicate Google
Blue instance in this file.

R=hcarmona@chromium.org
BUG= 918824 

Change-Id: Ifa4795cfe05f00273fe61759138dfbf3b23025af
Reviewed-on: https://chromium-review.googlesource.com/c/1396781
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Dan Beam <dbeam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620142}
[modify] https://crrev.com/59a719ee7f6de6439a11700db1b75266ddc8b445/ui/webui/resources/cr_elements/paper_button_style_css.html

Comment 4 by dbeam@chromium.org, Jan 5

Status: Fixed (was: Started)

Comment 5 by khush...@virtusa.com, Jan 7

Labels: TE-Verified-M73 TE-Verified-73.0.3664.0
Update:

Rechecked the above issue on Windows (7, 8, 8.1, 10), Mac (10.13.1, 10.13.6, 10.14.3) and Linux (14.04 LTS) OS using latest Canary version #73.0.3664.0 and the issue is found FIXED.
Hence, adding TE-Verified labels.

Please refer the attached screen-cast.

Thank You..!!
Fixed Video.mp4
472 KB View Download
►

Sign in to add a comment