Issue metadata
Sign in to add a comment
|
Regression: Chrome main window closes down when shortcut is created. |
||||||||||||||||||||
Issue descriptionChrome Version: 73.0.3660.0 (Official Build) 170f55273fbe689f402eade1a4e98fa2788938a2-refs/branch-heads/3660@{#1}(32/64-bit). OS: Win(7,8,8.1,10) and Linux(14.04 LTS). What steps will reproduce the problem? 1. Launch chrome and navigate to www.youtube.com 2. Right click on wrench icon and click on More tools > Create Shortcuts. 3. Chech box for Open as Window and Create Shortcut. 4. Observe chrome. Actual Result: Chrome main window closes down when shortcut is created. Expected Result: Chrome main window should not close. This is a regression issue broken in M-70 and below is the chromium bisect-info: Good Build : 70.0.3504.0(Revision:578511) Bad Build : 70.0.3505.0(Revision:578873) CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/a8117de4347200bd9e5fbe6eebf7fd024f5b170f..ef11a157a7ba06db29bdccec8b9991e3f20c9b32?pretty=fuller&n=10000 Suspecting: r578563 ? alancutter: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. Unable to provide 'per-revision' bisect as it shows error message for above range. (tried on other machines but still getting the same error again) 2. Hence providing suspect using Chromium bisect 3. Issue is also seen on Stable #71.0.3578.98 Beta #72.0.3626.28 and Dev #73.0.3642.0 build. 4. Issue is not seen on Mac(10.13.1, 10.13.6, 10.14.2) OS Kindly refer the screen cast for reference Thank You!
,
Jan 8
Thanks for the report. alancutter: this is kind of tricky, it's happening because we're reparenting a single window. Maybe we shouldn't reparent in that case, or open an NTP to leave the window open behind the reparented PWA?
,
Jan 8
Adding a NTP to preserve the existing tabbed browser SGTM. +hwi for UX opinion. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by dtapu...@chromium.org
, Jan 7