New issue
Advanced search Search tips

Issue 918817 link

Starred by 1 user
Status: Fixed
Owner:
dbeam@chromium.org
Closed: Jan 18
Cc:
ajha@chromium.org
baileyberro@chromium.org
steve...@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: Unwanted I-beam pointer is seen while hovering the mouse above ADD button in Add File Share overlay

Project Member Reported by rkalavakuntla@chromium.org, Jan 3 
Chrome Version:73.0.3654.0/11515.0.0 dev channel Daisy,Kip,Reks
OS: chrome OS

What steps will reproduce the problem?
(1)Sign into user >> launch chrome >> goto chrome://settings/smbShares
(2)Click on Add File Share >> Hover the pointer above ADD button and observe unwanted I-beam pointer

Actual:Unwanted I-beam pointer is seen while hovering the mouse above ADD button in Add File Share overlay
Expected: No such unwanted I-beam pointer should be seen

This is a Regression issue as same works fine in 71.0.3578.94/11151.59.0

Note: issue is seen in 72.0.3626.30/11316.35.0

Attached the screencast for reference..
actual.png
105 KB View Download
unwanted pointer.webm
288 KB View Download
expected.webm
431 KB View Download

Comment 1 by dpa...@chromium.org, Jan 15

Owner: dbeam@chromium.org
@dbeam: Can you triage this? Sounds related to the dark mode paper-button regression that has been fixed.

Comment 2 by dbeam@chromium.org, Jan 15

Labels: -Pri-1 Pri-3
this is tragic

Comment 3 by dbeam@chromium.org, Jan 16

Cc: dbeam@chromium.org
Owner: rkalavakuntla@chromium.org
rkalavakuntla@: can you bisect this?

Comment 4 by rkalavakuntla@chromium.org, Jan 16 (6 days ago)

Owner: ----
C # 3 >
Don't have bisect set up on Chrome OS to provide tool bisect,updating the narrower manual regression range:

Good Build:72.0.3618.0/11303.0.0
Bad Build:72.0.3626.30/11316.35.0

Thanks!

Comment 5 by dbeam@chromium.org, Jan 18 (5 days ago)

Cc: baileyberro@chromium.org

Comment 6 by dbeam@chromium.org, Jan 18 (5 days ago)

Cc: -dbeam@chromium.org
Owner: dbeam@chromium.org
Status: Started (was: Untriaged)
fairly sure it's the [slot="button-container"] > div that got added in https://crrev.com/c/1316664
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 18 (4 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19615bf8c78011c02ef531158f3e0d61a8a1a672

commit 19615bf8c78011c02ef531158f3e0d61a8a1a672
Author: Dan Beam <dbeam@chromium.org>
Date: Fri Jan 18 06:57:28 2019

Settings: fix whitespace issue on "Add SMB share" dialog

R=baileyberro@chromium.org
BUG= 918817 

Change-Id: If078eaf3a9cdef9b22041c9027fa1000abc8fcfd
Reviewed-on: https://chromium-review.googlesource.com/c/1419224
Commit-Queue: Dan Beam <dbeam@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Auto-Submit: Dan Beam <dbeam@chromium.org>
Reviewed-by: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624024}
[modify] https://crrev.com/19615bf8c78011c02ef531158f3e0d61a8a1a672/ui/webui/resources/cr_components/chromeos/smb_shares/add_smb_share_dialog.html

Comment 8 by dbeam@chromium.org, Jan 18 (4 days ago)

Status: Fixed (was: Started)
►

Sign in to add a comment