New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Feature



Sign in to add a comment
link

Issue 918795: FilesApp External Media Grouping

Reported by alliemurray@google.com, Jan 3 Project Member

Issue description

The current external drive UI does not allow the user to intuitively recognize which partitions belong to which physical external device. Partitions of external media have the same visual appearance and actions (i.e. eject) as physical devices, which can lead to confusion.

The bug tracks the work on partition grouping. Partitions which belong to the same external media device are to display as children under the common device in the directory tree UI. Eject button on root ejects all child partitions.

Eng owner:@alliemurray
Product owner:

Design doc: go/external_media_improvements
 

Comment 1 by bugdroid1@chromium.org, Jan 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/81566ec7ef76626b2d4233bd78eb90ffddb62362

commit 81566ec7ef76626b2d4233bd78eb90ffddb62362
Author: Alli Murray <alliemurray@google.com>
Date: Mon Jan 07 06:17:44 2019

Added device path param to test volume.

Bug: 918795
Change-Id: I9a70cebf8b65c2432da7ed9c9fca851ada88873e
Reviewed-on: https://chromium-review.googlesource.com/c/1393125
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Anand Mistry <amistry@chromium.org>
Commit-Queue: Alli Murray <alliemurray@google.com>
Cr-Commit-Position: refs/heads/master@{#620258}
[modify] https://crrev.com/81566ec7ef76626b2d4233bd78eb90ffddb62362/chrome/browser/chromeos/file_manager/volume_manager.cc
[modify] https://crrev.com/81566ec7ef76626b2d4233bd78eb90ffddb62362/chrome/browser/chromeos/file_manager/volume_manager.h

Comment 3 by amistry@chromium.org, Jan 10

Cc: weifangsun@chromium.org

Comment 4 by bugdroid, Jan 24

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/65c3de5ce108ea6400a4e0cd7287cb474e884930

commit 65c3de5ce108ea6400a4e0cd7287cb474e884930
Author: Alli Murray <alliemurray@google.com>
Date: Thu Jan 24 12:28:44 2019

Add drive label to be accessible from volume info.

Drive label, e.g. "SanDisk 3.0", is required to appear as the label of
the root entry for a partitioned external media device in the directory
tree.

Bug: 918795
Change-Id: I734a9995bd7ebbc249702b5a11fd5f163332f9dd
Reviewed-on: https://chromium-review.googlesource.com/c/1426238
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Anand Mistry <amistry@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#625614}

Comment 5 by bugdroid, Jan 31

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fdea3b249c50cd5235a07f82ff9606b6d43fdfd9

commit fdea3b249c50cd5235a07f82ff9606b6d43fdfd9
Author: Alli Murray <alliemurray@google.com>
Date: Thu Jan 31 06:51:29 2019

Added partition icon, added USB icon for root entries.

Bug: 918795
Change-Id: Ia7c5c4a748dd556285554447253ae94e21f7e430
Reviewed-on: https://chromium-review.googlesource.com/c/1442079
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Alli Murray <alliemurray@google.com>
Cr-Commit-Position: refs/heads/master@{#627846}
[modify] https://crrev.com/fdea3b249c50cd5235a07f82ff9606b6d43fdfd9/ui/file_manager/file_manager/foreground/css/file_types.css

Comment 6 by bugdroid, Feb 1

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5fde4c6597a65a44b1d8b1b4a9983aec0037dd8

commit a5fde4c6597a65a44b1d8b1b4a9983aec0037dd8
Author: Alli Murray <alliemurray@google.com>
Date: Fri Feb 01 04:05:44 2019

Move eject button setup function to be available for Directory Item
instances and classes which extend, such as EntryListItem. Removable
roots are EntryListItems and need eject functionality to set up an eject
button.

Bug: 918795
Change-Id: Icad38a3e44ff308d826a0fb2c3debcd5f0a7c69a
Reviewed-on: https://chromium-review.googlesource.com/c/1446258
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Alli Murray <alliemurray@google.com>
Cr-Commit-Position: refs/heads/master@{#628235}
[modify] https://crrev.com/a5fde4c6597a65a44b1d8b1b4a9983aec0037dd8/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

Comment 7 by bugdroid, Feb 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b211f1cf07ca8410031d6641b1ef8e310c9fe76

commit 3b211f1cf07ca8410031d6641b1ef8e310c9fe76
Author: Alli Murray <alliemurray@google.com>
Date: Thu Feb 07 03:44:20 2019

Partition grouping in navigation list model.

List partitions of external media devices as subdirectories underneath a
common root label to improve visual distinction. Make EntryList URL
unique for removable roots (otherwise directory change won't be
triggered).

Bug: 918795
Change-Id: I071664a333d44e0d9f4e1ca77bcb6dafda89e181
Reviewed-on: https://chromium-review.googlesource.com/c/1449472
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Alli Murray <alliemurray@google.com>
Cr-Commit-Position: refs/heads/master@{#629862}
[modify] https://crrev.com/3b211f1cf07ca8410031d6641b1ef8e310c9fe76/ui/file_manager/file_manager/background/js/entry_location_impl.js
[modify] https://crrev.com/3b211f1cf07ca8410031d6641b1ef8e310c9fe76/ui/file_manager/file_manager/background/js/mock_volume_manager.js
[modify] https://crrev.com/3b211f1cf07ca8410031d6641b1ef8e310c9fe76/ui/file_manager/file_manager/common/js/files_app_entry_types.js
[modify] https://crrev.com/3b211f1cf07ca8410031d6641b1ef8e310c9fe76/ui/file_manager/file_manager/foreground/css/file_types.css
[modify] https://crrev.com/3b211f1cf07ca8410031d6641b1ef8e310c9fe76/ui/file_manager/file_manager/foreground/js/navigation_list_model.js
[modify] https://crrev.com/3b211f1cf07ca8410031d6641b1ef8e310c9fe76/ui/file_manager/file_manager/foreground/js/navigation_list_model_unittest.js
[modify] https://crrev.com/3b211f1cf07ca8410031d6641b1ef8e310c9fe76/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
[modify] https://crrev.com/3b211f1cf07ca8410031d6641b1ef8e310c9fe76/ui/file_manager/file_manager/foreground/js/ui/location_line.js

Comment 8 by bugdroid, Feb 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b8e1d9bbeeab0c0ba5c8d9dbae40cd611e253ba

commit 8b8e1d9bbeeab0c0ba5c8d9dbae40cd611e253ba
Author: Alli Murray <alliemurray@google.com>
Date: Thu Feb 07 04:03:05 2019

Add command to unmount a removable entry list.

When partitions are grouped, the eject button is attached to the removable root label.
Unmounting a removable root means unmounting all child partitions, and using the
drive label in the unmount message.

Bug: 918795
Change-Id: Idd175c8f3d7a814bfe0784cfa52e35b12c36a663
Reviewed-on: https://chromium-review.googlesource.com/c/1454339
Commit-Queue: Alli Murray <alliemurray@google.com>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629867}
[modify] https://crrev.com/8b8e1d9bbeeab0c0ba5c8d9dbae40cd611e253ba/ui/file_manager/file_manager/foreground/js/file_manager_commands.js
[modify] https://crrev.com/8b8e1d9bbeeab0c0ba5c8d9dbae40cd611e253ba/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
[modify] https://crrev.com/8b8e1d9bbeeab0c0ba5c8d9dbae40cd611e253ba/ui/file_manager/file_manager/main.html

Comment 9 by bugdroid, Feb 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3968c5449ec5f431fb2d4a4096bf38cd3c984e3f

commit 3968c5449ec5f431fb2d4a4096bf38cd3c984e3f
Author: Alli Murray <alliemurray@google.com>
Date: Thu Feb 07 04:17:17 2019

Add quick view test for removable partitions.

Bug: 918795
Change-Id: I3ce85373b987f572e901889082d638035acf1235
Reviewed-on: https://chromium-review.googlesource.com/c/1457557
Commit-Queue: Alli Murray <alliemurray@google.com>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629872}
[modify] https://crrev.com/3968c5449ec5f431fb2d4a4096bf38cd3c984e3f/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/3968c5449ec5f431fb2d4a4096bf38cd3c984e3f/ui/file_manager/integration_tests/file_manager/quick_view.js

Comment 10 by bugdroid, Feb 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/18ad3039c0e0cc35ac5ed47f62fa65bba0019029

commit 18ad3039c0e0cc35ac5ed47f62fa65bba0019029
Author: Alli Murray <alliemurray@google.com>
Date: Thu Feb 07 07:12:52 2019

Test how partitions are displayed as children of their root label.

Bug: 918795
Change-Id: I3b4d530ad50264a1a9a40b2331b98886e3a81f18
Reviewed-on: https://chromium-review.googlesource.com/c/1457800
Commit-Queue: Alli Murray <alliemurray@google.com>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#629893}
[modify] https://crrev.com/18ad3039c0e0cc35ac5ed47f62fa65bba0019029/ui/file_manager/integration_tests/file_manager/file_display.js

Comment 11 by bugdroid, Feb 7

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/984a6c69155a81b9d26ac738ff7414526465d389

commit 984a6c69155a81b9d26ac738ff7414526465d389
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Thu Feb 07 08:25:33 2019

Revert "Add quick view test for removable partitions."

This reverts commit 3968c5449ec5f431fb2d4a4096bf38cd3c984e3f.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 629872 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vMzk2OGM1NDQ5ZWM1ZjQzMWZiMmQ0YTQwOTZiZjM4Y2QzYzk4NGUzZgw

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/31402

Sample Failed Step: webui_polymer2_browser_tests

Sample Flaky Test: QuickView/FilesAppBrowserTest.Test/openQuickViewRemovablePartitions

Original change's description:
> Add quick view test for removable partitions.
> 
> Bug: 918795
> Change-Id: I3ce85373b987f572e901889082d638035acf1235
> Reviewed-on: https://chromium-review.googlesource.com/c/1457557
> Commit-Queue: Alli Murray <alliemurray@google.com>
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#629872}

Change-Id: I8f69d1ee7321782bc3f1379e6d81dc24435c897f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 918795
Reviewed-on: https://chromium-review.googlesource.com/c/1457922
Cr-Commit-Position: refs/heads/master@{#629896}
[modify] https://crrev.com/984a6c69155a81b9d26ac738ff7414526465d389/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/984a6c69155a81b9d26ac738ff7414526465d389/ui/file_manager/integration_tests/file_manager/quick_view.js

Comment 13 by bugdroid, Feb 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/df938b958bad530ce3bfc3d4acccb897b30b5bec

commit df938b958bad530ce3bfc3d4acccb897b30b5bec
Author: Alli Murray <alliemurray@google.com>
Date: Tue Feb 12 00:50:31 2019

Reland: Add quick view test for removable usb partitions.

Bug: 918795
Change-Id: Id158154b74b9ee45cf799584630bedbcfde526ea
Reviewed-on: https://chromium-review.googlesource.com/c/1459870
Commit-Queue: Alli Murray <alliemurray@google.com>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631018}
[modify] https://crrev.com/df938b958bad530ce3bfc3d4acccb897b30b5bec/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/df938b958bad530ce3bfc3d4acccb897b30b5bec/ui/file_manager/integration_tests/file_manager/quick_view.js

Comment 14 by bugdroid, Feb 12

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/365dabdd88950ad02eb50f51143bc52098affdf5

commit 365dabdd88950ad02eb50f51143bc52098affdf5
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Tue Feb 12 05:26:26 2019

Revert "Reland: Add quick view test for removable usb partitions."

This reverts commit df938b958bad530ce3bfc3d4acccb897b30b5bec.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 631018 as the
culprit for flakes in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vZGY5MzhiOTU4YmFkNTMwY2UzYmZjM2Q0YWNjY2I4OTdiMzBiNWJlYww

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20ChromiumOS%20MSan%20Tests/11237

Sample Failed Step: non_single_process_mash_browser_tests

Sample Flaky Test: QuickView/FilesAppBrowserTest.Test/openQuickViewRemovablePartitions

Original change's description:
> Reland: Add quick view test for removable usb partitions.
> 
> Bug: 918795
> Change-Id: Id158154b74b9ee45cf799584630bedbcfde526ea
> Reviewed-on: https://chromium-review.googlesource.com/c/1459870
> Commit-Queue: Alli Murray <alliemurray@google.com>
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#631018}

Change-Id: I1dbf711061b22382b28c74e83a69ab2c9c4de1c8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 918795
Reviewed-on: https://chromium-review.googlesource.com/c/1466144
Cr-Commit-Position: refs/heads/master@{#631118}
[modify] https://crrev.com/365dabdd88950ad02eb50f51143bc52098affdf5/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/365dabdd88950ad02eb50f51143bc52098affdf5/ui/file_manager/integration_tests/file_manager/quick_view.js

Comment 15 by bugdroid, Feb 13

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97ea3cad12f8d794927bb03622846878235bad18

commit 97ea3cad12f8d794927bb03622846878235bad18
Author: Alli Murray <alliemurray@google.com>
Date: Wed Feb 13 00:27:13 2019

Reland: Add quick view test for removable usb partitions.

Bug: 918795
Change-Id: Icb4e9e9c28c91081233c38afa2d274e47ce7ca53
Reviewed-on: https://chromium-review.googlesource.com/c/1466203
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#631455}
[modify] https://crrev.com/97ea3cad12f8d794927bb03622846878235bad18/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/97ea3cad12f8d794927bb03622846878235bad18/ui/file_manager/integration_tests/file_manager/quick_view.js

Comment 16 by bugdroid, Feb 14 (6 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/921f227d03d096ad160435de86c0435c29b30f10

commit 921f227d03d096ad160435de86c0435c29b30f10
Author: Alli Murray <alliemurray@google.com>
Date: Thu Feb 14 06:07:10 2019

Add context menu for removable root entry list.

- Context menu should appear when right-click on root label.
- Command to unmount should be visible in context menu for removable roots and removable USBs.
- Partitions in the directory tree should not have an unmount in the context menu.

Bug: 918795
Change-Id: I025b1bb7a7cd15ce9610909e98b514f6ccab74e1
Reviewed-on: https://chromium-review.googlesource.com/c/1460201
Commit-Queue: Alli Murray <alliemurray@google.com>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632107}
[modify] https://crrev.com/921f227d03d096ad160435de86c0435c29b30f10/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/921f227d03d096ad160435de86c0435c29b30f10/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js
[modify] https://crrev.com/921f227d03d096ad160435de86c0435c29b30f10/ui/file_manager/integration_tests/file_manager/context_menu.js

Comment 17 by bugdroid, Feb 15 (5 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bafce5893821300d55c2e6b017463b769a8f3a23

commit bafce5893821300d55c2e6b017463b769a8f3a23
Author: Alli Murray <alliemurray@google.com>
Date: Fri Feb 15 01:48:34 2019

Populate partitions of the removable root during setup.

So that the UI reflects that the removable root has child partitions immediately after mounting.

Bug: 918795
Change-Id: Ifb50c86c6a6ac169e489292693adc1b56c06b835
Reviewed-on: https://chromium-review.googlesource.com/c/1474870
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Alli Murray <alliemurray@google.com>
Cr-Commit-Position: refs/heads/master@{#632448}
[modify] https://crrev.com/bafce5893821300d55c2e6b017463b769a8f3a23/ui/file_manager/file_manager/foreground/js/ui/directory_tree.js

Comment 18 by bugdroid, Feb 15 (5 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/499a46c274415cbae3dc022fd13d4ee6b2c6bddb

commit 499a46c274415cbae3dc022fd13d4ee6b2c6bddb
Author: Alli Murray <alliemurray@google.com>
Date: Fri Feb 15 03:16:24 2019

Change to default directory when removable entry list is unmounted.

Fixes bug where file list and breadcrumbs don't updated after removable
entry lists are unmounted.
Added unmount for removable test volumes, to test an unmount event.

Bug: 918795
Change-Id: I13ea71b6db9dff5ac2e59982eef7f6e34457fe31
Reviewed-on: https://chromium-review.googlesource.com/c/1465962
Commit-Queue: Alli Murray <alliemurray@google.com>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632481}
[modify] https://crrev.com/499a46c274415cbae3dc022fd13d4ee6b2c6bddb/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/499a46c274415cbae3dc022fd13d4ee6b2c6bddb/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/499a46c274415cbae3dc022fd13d4ee6b2c6bddb/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h
[modify] https://crrev.com/499a46c274415cbae3dc022fd13d4ee6b2c6bddb/chrome/browser/chromeos/file_manager/volume_manager.cc
[modify] https://crrev.com/499a46c274415cbae3dc022fd13d4ee6b2c6bddb/chrome/browser/chromeos/file_manager/volume_manager.h
[modify] https://crrev.com/499a46c274415cbae3dc022fd13d4ee6b2c6bddb/ui/file_manager/file_manager/foreground/js/directory_model.js
[modify] https://crrev.com/499a46c274415cbae3dc022fd13d4ee6b2c6bddb/ui/file_manager/integration_tests/file_manager/context_menu.js
[modify] https://crrev.com/499a46c274415cbae3dc022fd13d4ee6b2c6bddb/ui/file_manager/integration_tests/file_manager/file_display.js
[modify] https://crrev.com/499a46c274415cbae3dc022fd13d4ee6b2c6bddb/ui/file_manager/integration_tests/file_manager/quick_view.js

Comment 19 by bugdroid, Feb 15 (5 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5204465dce5a4365a55be44d0e3707ac868c055

commit f5204465dce5a4365a55be44d0e3707ac868c055
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Fri Feb 15 06:41:17 2019

Revert "Change to default directory when removable entry list is unmounted."

This reverts commit 499a46c274415cbae3dc022fd13d4ee6b2c6bddb.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 632481 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQ5OWE0NmMyNzQ0MTVjYmFlM2RjMDIyZmQxM2Q0ZWU2YjJjNmJkZGIM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20Chromium%20OS%20ASan%20LSan%20Tests%20%281%29/31559

Sample Failed Step: webui_polymer2_browser_tests

Original change's description:
> Change to default directory when removable entry list is unmounted.
> 
> Fixes bug where file list and breadcrumbs don't updated after removable
> entry lists are unmounted.
> Added unmount for removable test volumes, to test an unmount event.
> 
> Bug: 918795
> Change-Id: I13ea71b6db9dff5ac2e59982eef7f6e34457fe31
> Reviewed-on: https://chromium-review.googlesource.com/c/1465962
> Commit-Queue: Alli Murray <alliemurray@google.com>
> Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#632481}

Change-Id: I42f3409091357110d967dfb6e20e7676e849f5a5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 918795
Reviewed-on: https://chromium-review.googlesource.com/c/1474699
Cr-Commit-Position: refs/heads/master@{#632527}
[modify] https://crrev.com/f5204465dce5a4365a55be44d0e3707ac868c055/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/f5204465dce5a4365a55be44d0e3707ac868c055/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/f5204465dce5a4365a55be44d0e3707ac868c055/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h
[modify] https://crrev.com/f5204465dce5a4365a55be44d0e3707ac868c055/chrome/browser/chromeos/file_manager/volume_manager.cc
[modify] https://crrev.com/f5204465dce5a4365a55be44d0e3707ac868c055/chrome/browser/chromeos/file_manager/volume_manager.h
[modify] https://crrev.com/f5204465dce5a4365a55be44d0e3707ac868c055/ui/file_manager/file_manager/foreground/js/directory_model.js
[modify] https://crrev.com/f5204465dce5a4365a55be44d0e3707ac868c055/ui/file_manager/integration_tests/file_manager/context_menu.js
[modify] https://crrev.com/f5204465dce5a4365a55be44d0e3707ac868c055/ui/file_manager/integration_tests/file_manager/file_display.js
[modify] https://crrev.com/f5204465dce5a4365a55be44d0e3707ac868c055/ui/file_manager/integration_tests/file_manager/quick_view.js

Comment 20 by bugdroid, Feb 17 (2 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d041ecff8137bb31a114a394e8fca56d931aa8bb

commit d041ecff8137bb31a114a394e8fca56d931aa8bb
Author: Luciano Pacheco <lucmult@chromium.org>
Date: Sun Feb 17 23:23:40 2019

[Files app] Fix device_path_ member to be a value not a reference

RemovableTestVolume should own a FilePath as value not as reference,
otherwise it isn't guaranteed that the value is valid.

This fixes ASAN bot:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzQ5OWE0NmMyNzQ0MTVjYmFlM2RjMDIyZmQxM2Q0ZWU2YjJjNmJkZGIM
crrev.com/c/1474699

Bug: 918795
Change-Id: I269d3effb651947fc18985736d105d7bc9326c7d
Reviewed-on: https://chromium-review.googlesource.com/c/1474959
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Auto-Submit: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632991}
[modify] https://crrev.com/d041ecff8137bb31a114a394e8fca56d931aa8bb/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc

Comment 21 by bugdroid, Feb 18 (2 days ago)

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e92a759330b962a64d7fddbe810cf0b065cb8b08

commit e92a759330b962a64d7fddbe810cf0b065cb8b08
Author: Alli Murray <alliemurray@google.com>
Date: Mon Feb 18 00:06:06 2019

Reland "Change to default directory when removable entry list is unmounted."

This is a reland of 499a46c274415cbae3dc022fd13d4ee6b2c6bddb

Original change's description:
> Change to default directory when removable entry list is unmounted.
>
> Fixes bug where file list and breadcrumbs don't updated after removable
> entry lists are unmounted.
> Added unmount for removable test volumes, to test an unmount event.
>
> Bug: 918795
> Change-Id: I13ea71b6db9dff5ac2e59982eef7f6e34457fe31
> Reviewed-on: https://chromium-review.googlesource.com/c/1465962
> Commit-Queue: Alli Murray <alliemurray@google.com>
> Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#632481}

Bug: 918795
Change-Id: Idee5fcf4f17aa672468ac9ba39f5168d20a126bf
Tbr: noel@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1474961
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#632995}
[modify] https://crrev.com/e92a759330b962a64d7fddbe810cf0b065cb8b08/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/e92a759330b962a64d7fddbe810cf0b065cb8b08/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/e92a759330b962a64d7fddbe810cf0b065cb8b08/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.h
[modify] https://crrev.com/e92a759330b962a64d7fddbe810cf0b065cb8b08/chrome/browser/chromeos/file_manager/volume_manager.cc
[modify] https://crrev.com/e92a759330b962a64d7fddbe810cf0b065cb8b08/chrome/browser/chromeos/file_manager/volume_manager.h
[modify] https://crrev.com/e92a759330b962a64d7fddbe810cf0b065cb8b08/ui/file_manager/file_manager/foreground/js/directory_model.js
[modify] https://crrev.com/e92a759330b962a64d7fddbe810cf0b065cb8b08/ui/file_manager/integration_tests/file_manager/context_menu.js
[modify] https://crrev.com/e92a759330b962a64d7fddbe810cf0b065cb8b08/ui/file_manager/integration_tests/file_manager/file_display.js
[modify] https://crrev.com/e92a759330b962a64d7fddbe810cf0b065cb8b08/ui/file_manager/integration_tests/file_manager/quick_view.js

Sign in to add a comment