New issue
Advanced search Search tips

Issue 918769 link

Starred by 3 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Compat



Sign in to add a comment

[WPT] external/wpt/css/css-sizing/range-percent-intrinsic-size-2.html

Issue description

WPT import https://crrev.com/c/1394189 introduced new failures in external/wpt/css:

List of new failures:
external/wpt/css/css-sizing/range-percent-intrinsic-size-2.html [ Failure ]

This import contains upstream changes from a2448c2392587668a9b9f8ec4e3d0dec76640f25 to 4e6563687b9c03d2f54ce0f06ef0ccc8e0964328:
Stop importing testharness into a support file: https://github.com/web-platform-tests/wpt/commit/4e6563687b9c03d2f54ce0f06ef0ccc8e0964328
Support pen inputs in web platform tests: https://github.com/web-platform-tests/wpt/commit/4d72388ad966eec0f040acb1971e00e0336c216d
Less restrictive internal column count limit.: https://github.com/web-platform-tests/wpt/commit/65d9f77309d2159c659b21ab4474d399c6d1527b [affecting this directory]
Add AnimationTiming tests: https://github.com/web-platform-tests/wpt/commit/12a15bff62d9100afb17ee595fb98bee7e61b6ca
webdriver: fix key code for NUMPAD4 and NUMPAD5 (#14678): https://github.com/web-platform-tests/wpt/commit/6f5ee87390438c901d05e1ee39be634fc186aa01
Cookie Store: Test cross-origin frames + service workers.: https://github.com/web-platform-tests/wpt/commit/2e3e80c3b4c3652ff7a1be9118665bbd6d3b9ae7
Add WPT reftests for properties that inhibit text shaping across inline element boundaries.: https://github.com/web-platform-tests/wpt/commit/2c20cf1f30037222d0068786444ab96a7f9f1140 [affecting this directory]
[LayoutNG] Fix SVG replaced element sizes: https://github.com/web-platform-tests/wpt/commit/75bc93d7d93eb39a83b4f862872976858d9cb0e2
Implement getDisplayMedia() and update related wpt tests.: https://github.com/web-platform-tests/wpt/commit/4dbc8a0d7b1b1c032aaddc2579ec7239ad565127
Part 1 - Support column-span:all for a multi-column <details> element.: https://github.com/web-platform-tests/wpt/commit/0445e8c3f3c646bf19771b643ce96d633f9ceba0 [affecting this directory]
Implement the 'overflow-inline' media query.: https://github.com/web-platform-tests/wpt/commit/6db57475e0355b476c779b2b50363caf57cd1b57 [affecting this directory]
Implement the 'overflow-block' media query.: https://github.com/web-platform-tests/wpt/commit/68115d4053a179879ec0ce9b357a094b492d68cd [affecting this directory]
[css2] Link to reference: https://github.com/web-platform-tests/wpt/commit/665be845bb8cc3b1e9b420940418f0ade07ddfbf [affecting this directory]
[css-text-3] alignment and end-of-line white-space: https://github.com/web-platform-tests/wpt/commit/497af5a687a50f470f3cf5c2723db1e7fb934a56 [affecting this directory]
[css-text][css2] Add refs and update links: https://github.com/web-platform-tests/wpt/commit/e9f45b6c34000a63504d8c62b9e24a7bd8b55fc1 [affecting this directory]
v8binding: Implement timers with IDL callback function of type Function: https://github.com/web-platform-tests/wpt/commit/941e8206cee200360d29bdc09ff643bbe1bf61ce
[css2] Restore significant trailing white space: https://github.com/web-platform-tests/wpt/commit/16fc0dcdc41f6957fff263f7141c3808f579a892 [affecting this directory]
[LayoutNG] Remove NGLayoutResult::PositionedFloats.: https://github.com/web-platform-tests/wpt/commit/a1cc8c0bda2dc784ab07a34473c8f27d4bad7518 [affecting this directory]
[css-text] Tab size lengths inherit as lengths: https://github.com/web-platform-tests/wpt/commit/900ad7284cb30dc3620e348a7eb5ff0f69dfd519 [affecting this directory]
[css-text] Check tab-size behavior under various white-space values: https://github.com/web-platform-tests/wpt/commit/d02832384b2de958c40dc7606d35c8fbdef7bbde [affecting this directory]
Move visual overflow computation into the descendant-dependent tree walk.: https://github.com/web-platform-tests/wpt/commit/1d4dcbf0a3c4a1ded76ca96f3450261fec1d2266 [affecting this directory]
Async Clipboard: Refactor tests to use arrow functions: https://github.com/web-platform-tests/wpt/commit/f74e788a986b4630f12fdf5f1aeba913b6328cad
Shrink columns width in column-span reftests to fit the window on wpt.: https://github.com/web-platform-tests/wpt/commit/e9174d402d5e0be1e5f13f4ff0d10b4d4204d164 [affecting this directory]
Claim to support testdriver in servodriver: https://github.com/web-platform-tests/wpt/commit/259d0612af038d14f2cd889a14a3adb6c9e96d96
[css-text] Add "anywhere" equivalents to "break-word" tests: https://github.com/web-platform-tests/wpt/commit/cd31531b419737b67c3201f89eaa1406afe27948 [affecting this directory]
[css-text] overflow-wrap:break-word does not change the min-content size: https://github.com/web-platform-tests/wpt/commit/69c2a2b356e180785ce276fd842959193bcb5a3c [affecting this directory]
[css-text-3] Rework text-indent tests: https://github.com/web-platform-tests/wpt/commit/01bcaf75435db95e0ba06df42ccbd35aeef33f2f [affecting this directory]
Merge pull request #10627 from frivoal/text-2465: https://github.com/web-platform-tests/wpt/commit/67b751ef3b96755111d9f845efd3b21c014d68bc
[css-text] break-spaces has moved from overflow-wrap to white-space: https://github.com/web-platform-tests/wpt/commit/ae2ef2d8cf5cab2db0a477411ea7f9cc79f6f737 [affecting this directory]
[css-text] overflow-wrap and intrinsic sizing: https://github.com/web-platform-tests/wpt/commit/b439b5793f217eeb5ec1dd941161f6206ab2938d [affecting this directory]
Merge pull request #13385 from frivoal/text-2135: https://github.com/web-platform-tests/wpt/commit/9b22a2f64e0199794898ae88bf29ae558e2a2f5a
Merge pull request #13461 from frivoal/text-3143: https://github.com/web-platform-tests/wpt/commit/a546e84c5c9aa5e1481cfbdeef0d70530c811508
[css-text] text-transform must not disturb shaping in arabic: https://github.com/web-platform-tests/wpt/commit/a1e342c18c90f8386adf9e23495814ed6e7f2804 [affecting this directory]
[css-text] Improve text-transform:full-size-kana tests: https://github.com/web-platform-tests/wpt/commit/cf5dba33625ba1c4491054fa4a0ad3a1243f7a43 [affecting this directory]
Merge pull request #13428 from frivoal/text-627: https://github.com/web-platform-tests/wpt/commit/e13446ad8a47fa1643f3afa987d0da950822023b
[css-text] plain-text copy & paste does not preserve text-transform: https://github.com/web-platform-tests/wpt/commit/176d04ddd933ec150424b7f2c923ad6c4519b618 [affecting this directory]
v8binding: Add lexical scope test of event handlers in WPT: https://github.com/web-platform-tests/wpt/commit/64bd43ee19cc4667e4a3020c5894af7dbe68f5cc
Remove leading question mark when constructing URLSearchParams: https://github.com/web-platform-tests/wpt/commit/a1cd313702011d10db825aec3219b32f8b65a944
Add tests for image.onerror (#11683): https://github.com/web-platform-tests/wpt/commit/a357943a203d0d587a30c9aa41c4772a0500ff79
Update range-percent-intrinsic-size-1.html: https://github.com/web-platform-tests/wpt/commit/e7517084404fca126c4f89eb69217206689adf17 [affecting this directory]
Update range-percent-intrinsic-size-1-ref.html: https://github.com/web-platform-tests/wpt/commit/7f21e270e763b8288995580140847e4fa8468b87 [affecting this directory]
Make <input type=range> deal with "percentage inline-size implies zero min-content size" properly.: https://github.com/web-platform-tests/wpt/commit/002ba08cd5b6c2d6de1c8f4c900109312e7ae337 [affecting this directory]
Mark SVG script without an end tag malformed.: https://github.com/web-platform-tests/wpt/commit/e1857a53d30526ba446b70e9d3c0e055e30f14a8
Add test for pixel values of Gaussian blur for canvas 2d context shadowBlur.: https://github.com/web-platform-tests/wpt/commit/4647f5eb03e98565d3ebb21e4890bb24113d0600
Add new Feature-Policy-Report-Only header: https://github.com/web-platform-tests/wpt/commit/82c3ea4fb290ae6e8d3aa671c888e3f224a59f89
[Azure Pipelines] Use raw URL with `brew cask install` (#14651): https://github.com/web-platform-tests/wpt/commit/ac06ab662bf97c4e06feecd888225708521baa33
Use get-host-info to run in CI. Use method.py to get a response without any body (#14646): https://github.com/web-platform-tests/wpt/commit/f3cbe0368c46f52a1d8145181db4d1e4e6afc123
Log where we are downloading Firefox from: https://github.com/web-platform-tests/wpt/commit/bc34f4b379c760a5851d65689c88398d309dcf64
[Background Fetch] Remove use of chromium specific resource: https://github.com/web-platform-tests/wpt/commit/08a84e5a8c875e4aa2dad40759a5069d440eae84
Add HTMLInputElement select event test (#8624): https://github.com/web-platform-tests/wpt/commit/0c17bdc23f7e57994452fc669f6d0bcd371299d1
[Background Fetch] Display upload progress.: https://github.com/web-platform-tests/wpt/commit/9f99e81b2d827b50f5a97478a0d79a064cb99d5a
Add firefox buildid and source changeset to wptreport.json: https://github.com/web-platform-tests/wpt/commit/f12cd12fea9e577e4d18b8f3599c0e359abc0038
Move 'contain: size' handling for replaced content: https://github.com/web-platform-tests/wpt/commit/14cf574d6d8ff4d5ddd116dcb117dacaae6d0d6d [affecting this directory]
Fix reframing ColumnSetWrapperFrame when it already has column-span children.: https://github.com/web-platform-tests/wpt/commit/5dc533edb8de52a96f36d746ad50b6e176621f5a [affecting this directory]
Plumbing border box through to viz, and adding clip rect to backdrop-filter: https://github.com/web-platform-tests/wpt/commit/e95a36a608508cafe6739bda57ba405cc03e04d5 [affecting this directory]
Update RTCPeerConnection-helper.js (#14417): https://github.com/web-platform-tests/wpt/commit/b75b876e7d5843582f21e5b52c54d509dffb6da0
Sync Mozilla CSS tests as of 2018-12-20 (#14607): https://github.com/web-platform-tests/wpt/commit/8b2ce21a53705a0ac50ae66824be2229eb114579 [affecting this directory]
[LayoutNG] Don't allow line height quirk inside list items.: https://github.com/web-platform-tests/wpt/commit/6bfd51316130abc1d6b648ba281792fb34e4ee82

 
Cc: futhark@chromium.org
Labels: Pri-3 Type-Compat
Status: Available (was: Untriaged)
Summary: [WPT] external/wpt/css/css-sizing/range-percent-intrinsic-size-2.html (was: [WPT] New failures introduced in external/wpt/css by import https://crrev.com/c/1394189)
Labels: Hotlist-GoodFirstBug
I had a quick look at this, this looks like we don't correctly calculate the min-content contribution for a vertical slider.

See - which doesn't take this into account:
https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/layout/layout_slider.cc?q=layoutslider&sq=package:chromium&g=0&l=54

Low priority, but marking as good first bug for someone that wants to get started in the layout codebase.
Components: -Blink>CSS Blink>Layout

Sign in to add a comment