New issue
Advanced search Search tips

Issue 918747 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 8
Cc:
Components:
EstimatedDays: 1
NextAction: 2019-01-02
OS: Android
Pri: 3
Type: Bug



Sign in to add a comment

UrlBar triggers autofill

Project Member Reported by stonebraker@chromium.org, Jan 3

Issue description

Chrome Version: (copy from chrome://version)
OS: (e.g. Win10, MacOS 10.12, etc...)

What steps will reproduce the problem?
(1) adb shell cmd autofill set log_level verbose
(2) open chrome for android on a pixel 2 xl with Android Q
(3) touch url bar

What is the expected result?
autofill is not triggered (AutofillManager is logged)

What happens instead?
autofill is triggered


 
Labels: Needs-triage-Mobile
Cc: jbanavatu@chromium.org chelamcherla@chromium.org
Labels: Triaged-Mobile Needs-Feedback
@stonebraker: Could you please provide device details on which this issue is seen. Screencast/ screenshot on reproducing this would help in further triaging.

Thanks!
Description: Show this description
Status: Started (was: Untriaged)
Sorry, meant to mark this as started.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8eb885db5fcd05490a6cfad90856e28f64b5b8ea

commit 8eb885db5fcd05490a6cfad90856e28f64b5b8ea
Author: Drew Stonebraker <stonebraker@chromium.org>
Date: Tue Jan 08 23:27:27 2019

Remove Autofill from clank url bar

Focusing the url bar in clank triggers autofill unnecessarily. Added
importantForAutofill="no" attribute to UrlBar component.

Skipping presubmit due to failed text appearance check, since I made no
change to text appearance.

See also: 900912
NOPRESUBMIT=true

Bug:  918747 
Test: AutoFillManager no longer outputs to logcat on input focus
Change-Id: Ib927f2614733642dddcca323dd1ff04f5e479828
Reviewed-on: https://chromium-review.googlesource.com/c/1394186
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Commit-Queue: Drew Stonebraker <stonebraker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620928}
[modify] https://crrev.com/8eb885db5fcd05490a6cfad90856e28f64b5b8ea/chrome/android/java/res/layout/url_bar.xml

Status: Fixed (was: Started)

Sign in to add a comment