New issue
Advanced search Search tips

Issue 918746 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

[Merge Request M72] Minor UX fixes and bugs on Autofill name fix flow dialog

Project Member Reported by dlkumar@google.com, Jan 3

Issue description

Request to merge CL https://chromium-review.googlesource.com/c/chromium/src/+/1391350

verified in Canary 73

The feature is controlled by project's Finch flag. No other project/feature touches this file.

Thanks!
 
Project Member

Comment 1 by sheriffbot@chromium.org, Jan 3

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-72 Merge-Approved-72
Approving merge to M72 branch 3626 based on comment #0. Please merge ASAP so we can pick it up for next beta release. Thank you.
Pls merge your change to M72 branch 3626 ASAP so we can pick it up for next Beta release. Thank you.
Status: Fixed (was: Untriaged)
Merged as https://chromium-review.googlesource.com/c/chromium/src/+/1396482; marking as Fixed.
Thank you Krishna and Jared.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 4

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72a312237329b2d281947ef17be603098cdfd52a

commit 72a312237329b2d281947ef17be603098cdfd52a
Author: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Date: Fri Jan 04 18:57:19 2019

Small UX changes from UX review

1) Fix padding.
2) Fix editing in landscape mode


Screenshots - https://screenshot.googleplex.com/xFHjg8t9rxu.png
https://screenshot.googleplex.com/sS7NWffEpOf.png

Landscape mode screenshots -
https://screenshot.googleplex.com/xM2HVR5SXH6
https://screenshot.googleplex.com/zDeW1YOtQqB


Bug:  918746 
Change-Id: I2b8d3f70291de088f29007377cae0c03e3c5f18d
Reviewed-on: https://chromium-review.googlesource.com/c/1391350
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#619472}(cherry picked from commit bcff4822f19d72661086ee688884dd4dc219cdf4)
Reviewed-on: https://chromium-review.googlesource.com/c/1396482
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/branch-heads/3626@{#565}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/72a312237329b2d281947ef17be603098cdfd52a/chrome/android/java/res/layout/autofill_name_fixflow.xml

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/72a312237329b2d281947ef17be603098cdfd52a

Commit: 72a312237329b2d281947ef17be603098cdfd52a
Author: dlkumar@google.com
Commiter: jsaul@google.com
Date: 2019-01-04 18:57:19 +0000 UTC

Small UX changes from UX review

1) Fix padding.
2) Fix editing in landscape mode


Screenshots - https://screenshot.googleplex.com/xFHjg8t9rxu.png
https://screenshot.googleplex.com/sS7NWffEpOf.png

Landscape mode screenshots -
https://screenshot.googleplex.com/xM2HVR5SXH6
https://screenshot.googleplex.com/zDeW1YOtQqB


Bug:  918746 
Change-Id: I2b8d3f70291de088f29007377cae0c03e3c5f18d
Reviewed-on: https://chromium-review.googlesource.com/c/1391350
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Lakshmi Kumar Dabbiru <dlkumar@google.com>
Cr-Original-Commit-Position: refs/heads/master@{#619472}(cherry picked from commit bcff4822f19d72661086ee688884dd4dc219cdf4)
Reviewed-on: https://chromium-review.googlesource.com/c/1396482
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/branch-heads/3626@{#565}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

Sign in to add a comment