New issue
Advanced search Search tips

Issue 918743 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Jan 11
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: Bug



Sign in to add a comment

trace-export-events-to-etw flag not propagated to GPU process

Project Member Reported by dli...@microsoft.com, Jan 3

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3647.0 Safari/537.36 Edg/73.0.3647.0

Steps to reproduce the problem:
1. Launch chrome.exe with --trace-export-events-to-etw
2. Launch UIForETW and enable gpu/benchmark ETW keywords
3. Navigate or cause Chrome to otherwise visually update
4. Stop tracing and open resulting .etl file in WPA or other etw visualizer

What is the expected behavior?
Graphics.Pipeline.DrawAndSwap and other GPU-process related events show up

What went wrong?
The flag isn't propagated, so the appropriate machinery and flags are not set and thus no ETW events are logged from the GPU process

Did this work before? No 

Chrome version: 73.0.3647.0  Channel: n/a
OS Version: 10.0
Flash Version:
 
Cc: brucedaw...@chromium.org
Thanks for filing the bug.
Labels: Needs-Triage-M73
Cc: susan.boorgula@chromium.org
Components: Internals>GPU>Internals
Labels: Triaged-ET Needs-Feedback
dlibby@ Thanks for the issue.

Request you to provide a sample file/URL where this issue can be reproduced, which will help in further triaging.

Thanks..
Status: Available (was: Unconfirmed)
This issue isn't hit on any particular URL. It is hit when trying to do a certain type of profiling of Chrome. The intention of adding ETW tracing support was to have ETW events emitted from all Chrome processes. The omission of the GPU process was an oversight and this fix is wanted.
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f7e6263051e19089411236c86c4ef7507a49b64

commit 8f7e6263051e19089411236c86c4ef7507a49b64
Author: Daniel Libby <dlibby@microsoft.com>
Date: Tue Jan 08 22:35:55 2019

Enable GPU process to emit ETW events

The feature flag/commandline switch that controls whether a process
emits ETW events is not propagated the GPU process, so it never
records ETW events. This change propagates the flag via the
gpu-preferences commandline value, similar to other options passed
to the GPU process.

R=brucedawson@chromium.org

Bug:  918743 
Change-Id: I130331965f9c7b8a0864302238f91fc0bcab8fc7
Reviewed-on: https://chromium-review.googlesource.com/c/1398503
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620911}
[modify] https://crrev.com/8f7e6263051e19089411236c86c4ef7507a49b64/content/gpu/gpu_main.cc
[modify] https://crrev.com/8f7e6263051e19089411236c86c4ef7507a49b64/content/public/browser/gpu_utils.cc
[modify] https://crrev.com/8f7e6263051e19089411236c86c4ef7507a49b64/gpu/config/gpu_preferences.h
[modify] https://crrev.com/8f7e6263051e19089411236c86c4ef7507a49b64/gpu/config/gpu_preferences_unittest.cc
[modify] https://crrev.com/8f7e6263051e19089411236c86c4ef7507a49b64/gpu/ipc/common/gpu_preferences.mojom
[modify] https://crrev.com/8f7e6263051e19089411236c86c4ef7507a49b64/gpu/ipc/common/gpu_preferences_struct_traits.h

Just realized I never followed up to mark this bug as Fixed. I don't have bug editing permissions and the bug was never assigned to me.

brucedawson@ or susan.boorgula@, do you mind assigning to me so I can do so?

Thanks for all the help landing this change!
Status: Fixed (was: Available)
Fixed by dlibby@microsoft.com (not currently a project member so can't be assigned as an issue owner)

Sign in to add a comment