New issue
Advanced search Search tips

Issue 918741 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Externally accessible MenuItemView static variables should be initialized before RunMenuAt() call

Project Member Reported by collinbaker@chromium.org, Jan 3

Issue description

MenuItemView has some static size variables that are accessible through static getters: for example MenuItemView::label_start_ and views::MenuItemView::label_start(). These are not initialized until MenuItemView::UpdateMenuPartSizes() is called, which is called upon a MenuRunner::RunMenuAt(). Consequently, these methods return invalid data before a menu is run.

Aside from the bug of allowing uninitialized data to be read, this also prevents code from getting this information before menu run time, which is an obstacle to declarative layout.

Related: Issue 913998
 
Description: Show this description

Sign in to add a comment