New issue
Advanced search Search tips

Issue 918730 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 14
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature
Team-Accessibility



Sign in to add a comment

Port liblouis to wasm

Project Member Reported by dtseng@chromium.org, Jan 2

Issue description

Tracking bug
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90

commit cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90
Author: David Tseng <dtseng@chromium.org>
Date: Mon Jan 07 21:51:43 2019

Migrate LibLouis to web assembly

This change ports the LibLouis C++ library from Native Client to web assembly.

Major changes:
- the js-wrapper has been re-written (liblouis_wrapper.js) and the protocol with liblouis.js is slightly changed.
- liblouis itself has been upgraded to v3.2.
- table changes have occurred resulting in removal of some tables (e.g. there is now unified French braille which supplants other French tables).
This change only removes the impacted tables with a follow up to add all new tables.
- liblouis.js was simplified.

Bug:  918730 
Test: existing unit tests.
Change-Id: If9b7ede77e3ec508f4e40a3fd3e603a9e1f0f33f
Reviewed-on: https://chromium-review.googlesource.com/c/1393785
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Zachary Kuznia <zork@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620489}
[modify] https://crrev.com/cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90/DEPS
[modify] https://crrev.com/cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90/chrome/browser/resources/chromeos/chromevox/braille/braille_table_test.extjs
[modify] https://crrev.com/cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90/chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager.js
[modify] https://crrev.com/cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90/chrome/browser/resources/chromeos/chromevox/braille/liblouis.js
[modify] https://crrev.com/cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs
[modify] https://crrev.com/cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90/chrome/test/BUILD.gn
[modify] https://crrev.com/cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90/third_party/liblouis/BUILD.gn
[modify] https://crrev.com/cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90/third_party/liblouis/README.chromium
[delete] https://crrev.com/07793c0b8b65d57004af72bd6df676b3f5f2d2c2/third_party/liblouis/nacl_wrapper/liblouis_instance.cc
[delete] https://crrev.com/07793c0b8b65d57004af72bd6df676b3f5f2d2c2/third_party/liblouis/nacl_wrapper/liblouis_instance.h
[delete] https://crrev.com/07793c0b8b65d57004af72bd6df676b3f5f2d2c2/third_party/liblouis/nacl_wrapper/liblouis_module.cc
[delete] https://crrev.com/07793c0b8b65d57004af72bd6df676b3f5f2d2c2/third_party/liblouis/nacl_wrapper/liblouis_module.h
[delete] https://crrev.com/07793c0b8b65d57004af72bd6df676b3f5f2d2c2/third_party/liblouis/nacl_wrapper/liblouis_wrapper.cc
[delete] https://crrev.com/07793c0b8b65d57004af72bd6df676b3f5f2d2c2/third_party/liblouis/nacl_wrapper/liblouis_wrapper.h
[delete] https://crrev.com/07793c0b8b65d57004af72bd6df676b3f5f2d2c2/third_party/liblouis/nacl_wrapper/translation_params.h
[delete] https://crrev.com/07793c0b8b65d57004af72bd6df676b3f5f2d2c2/third_party/liblouis/nacl_wrapper/translation_result.h
[modify] https://crrev.com/cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90/third_party/liblouis/tables.json
[rename] https://crrev.com/cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90/third_party/liblouis/wasm/DEPS
[add] https://crrev.com/cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90/third_party/liblouis/wasm/liblouis_wasm.data
[add] https://crrev.com/cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90/third_party/liblouis/wasm/liblouis_wasm.js
[add] https://crrev.com/cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90/third_party/liblouis/wasm/liblouis_wasm.wasm
[add] https://crrev.com/cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90/third_party/liblouis/wasm/liblouis_wrapper.js
[rename] https://crrev.com/cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90/third_party/liblouis/wasm/liblouis_wrapper_browsertest.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aaa5b7d74a882acd2dbcc02d52f0d2437f64e8ef

commit aaa5b7d74a882acd2dbcc02d52f0d2437f64e8ef
Author: Thiemo Nagel <tnagel@chromium.org>
Date: Tue Jan 08 11:06:06 2019

Revert "Migrate LibLouis to web assembly"

This reverts commit cd7ff35637bfee1e51260aa0b8eae3c18a1d3d90.

Reason for revert: the CL seems to break Linux ChromiumOS MSan Tests

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20ChromiumOS%20MSan%20Tests/10621

  Test 'ChromeVoxLibLouisTest.checkAllTables' completed with the following status(es): 'TIMEOUT','TIMEOUT','TIMEOUT','TIMEOUT'
  Test 'ChromeVoxLibLouisTest.checkAllTables' had the following logs when run:
  ================================================================================
  [ RUN      ] ChromeVoxLibLouisTest.checkAllTables
  [1147:1147:0107/160655.775671:WARNING:chrome_browser_main_chromeos.cc(552)] Running as stub user with profile dir: test-user
  [1147:1147:0107/160656.293572:WARNING:easy_unlock_service_regular.cc(438)] EasyUnlockServiceRegular::IsInLegacyHostMode: DeviceSyncClient not ready. Returning false.
  [1147:1147:0107/160656.382735:INFO:remote_commands_service.cc(38)] Fetching remote commands.
  [1147:1147:0107/160656.383082:WARNING:remote_commands_service.cc(40)] Client is not registered.
  [1147:1147:0107/160656.383205:INFO:remote_commands_invalidator.cc(32)] Initialize RemoteCommandsInvalidator.
  [1147:1147:0107/160656.383284:INFO:remote_commands_invalidator.cc(57)] Starting RemoteCommandsInvalidator.
  [1147:1147:0107/160656.383603:INFO:remote_commands_invalidator.cc(123)] RemoteCommandsInvalidator ReloadPolicyData.
  [1147:1147:0107/160656.390919:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator.
  [1147:1147:0107/160656.579130:WARNING:wallpaper_controller_client.cc(358)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances.
  [1147:1147:0107/160657.596893:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *)
  [1147:1147:0107/160658.079601:ERROR:remote_text_input_client.cc(144)] Not implemented reached in virtual void RemoteTextInputClient::OnInputMethodChanged()
  [1147:1147:0107/160658.079713:ERROR:remote_text_input_client.cc(101)] Not implemented reached in virtual ui::TextInputClient::FocusReason RemoteTextInputClient::GetFocusReason() const
  [1147:1147:0107/160658.079772:ERROR:remote_text_input_client.cc(185)] Not implemented reached in virtual bool RemoteTextInputClient::ShouldDoLearning()
  [1147:1147:0107/160658.079873:ERROR:remote_text_input_client.cc(95)] Not implemented reached in virtual bool RemoteTextInputClient::HasCompositionText() const
  [1147:1147:0107/160658.079929:ERROR:remote_text_input_client.cc(107)] Not implemented reached in virtual bool RemoteTextInputClient::GetTextRange(gfx::Range *) const
  ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
  ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
  ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
  ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
  ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
  ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
  ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
  ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
  [1147:1351:0107/160658.449133:ERROR:alsa_util.cc(204)] PcmOpen: default,No such file or directory
  ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
  ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
  ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
  ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
  ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
  ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
  ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
  ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
  [1147:1351:0107/160658.450019:ERROR:alsa_util.cc(204)] PcmOpen: plug:default,No such file or directory
  [1147:1147:0107/160701.411856:INFO:CONSOLE(1071)] "Synchronous XMLHttpRequest on the main thread is deprecated because of its detrimental effects to the end user's experience. For more help, check https://xhr.spec.whatwg.org/.", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1071)
  [1147:1333:0107/160714.779443:ERROR:component_loader.cc(92)] Can't load /usr/share/chromeos-assets/speech_synthesis/patts/manifest.json: Manifest file is missing or unreadable
  [1147:1333:0107/160714.779806:ERROR:component_loader.cc(92)] Can't load /usr/share/chromeos-assets/speech_synthesis/espeak-ng/manifest.json: Manifest file is missing or unreadable
  [1147:1147:0107/160714.791455:ERROR:prefs_util.cc(601)] Cros settings pref not found: cros.display_rotation_default
  [1147:1147:0107/160719.628821:INFO:CONSOLE(963)] "Speak (Q) category=nav "Address and search bar"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963)
  [1147:1147:0107/160719.683004:INFO:CONSOLE(963)] "Speak (Q) category=nav "about:blank"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963)
  [1147:1147:0107/160719.731180:INFO:CONSOLE(963)] "Speak (Q) category=nav "Edit text, URL entry"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963)
  [1147:1147:0107/160719.819361:INFO:CONSOLE(963)] "Speak (Q) category=nav "about:blank - Chromium - Petals, window"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963)
  [1147:1147:0107/160719.852972:INFO:CONSOLE(963)] "Speak (Q) category=nav "Press up or down arrow for auto completions."", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963)
  [1147:1147:0107/160719.901464:INFO:CONSOLE(963)] "Speak (Q) category=nav "Type to auto complete."", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963)
  [1147:1334:0107/160812.728048:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.733817:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.735773:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.742939:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.744209:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.745276:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.752755:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.753947:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.755288:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.756316:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.757937:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.768173:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.769308:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.771299:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.772389:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.773525:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.774980:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.776155:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.790374:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.791636:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.792742:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.793870:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.794927:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.796357:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.797399:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.798426:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.799433:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.800470:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.801525:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.820688:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.821839:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.822877:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.823949:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.825004:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.826056:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.827080:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.828187:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.829293:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.830341:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.831416:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.832571:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.833633:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1334:0107/160812.834801:WARNING:url_request_job_manager.cc(91)] Failed to map: chrome-extension://invalid/
  [1147:1147:0107/160818.079331:INFO:CONSOLE(963)] "Speak (Q) "ChromeVox spoken feedback is ready"", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (963)
  [1147:1147:0107/160818.303430:INFO:CONSOLE(7817)] "Running TestCase ChromeVoxLibLouisTest.checkAllTables", source: file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs (7817)
  [1147:1147:0107/160818.306002:INFO:CONSOLE(7043)] "ReferenceError: axs is not defined
      at ChromeVoxLibLouisTest.get accessibilityAuditConfig [as accessibilityAuditConfig] (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:6704:44)
      at ChromeVoxLibLouisTest.setUp (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:6845:10)
      at TestCase.setUp (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:6997:20)
      at TestCase.run (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7039:12)
      at RUN_TEST_F (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7818:19)
      at file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7579:18
      at runTestFunction (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7656:35)
      at runTest (file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:7630:16)
      at file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs:8914:1", source: file:///b/s/w/ir/out/Release/test_data/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs (7043)
  [1147:1147:0107/160819.627083:INFO:CONSOLE(1266)] "Injecting into 2", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/chromeVox2ChromeBackgroundScript.js (1266)
  [1147:1147:0107/160821.151328:INFO:CONSOLE(1827)] "ChromeVox waiting for background page: about:blank. Will try again in 100ms", source: chrome-extension://chromevox/chromeVoxChromePageScript.js (1827)
  [1:1:0107/160821.338681:WARNING:logging_native_handler.cc(71)] Got textChanged event on unknown node: 2; this: 1
  [1147:1147:0107/160823.558360:INFO:CONSOLE(2315)] "got inlen!15", source: chrome-extension://mndnfokpggljbaajbnioimlmbfngpief/braille/liblouis_wasm.js (2315)
  BrowserTestBase received signal: Terminated. Backtrace:
      #0 0x56353de537b1 in __interceptor_backtrace /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/msan/../sanitizer_common/sanitizer_common_interceptors.inc:4050:13
      #1 0x563553b2f28a in base::debug::StackTrace::StackTrace(unsigned long) ./../../base/debug/stack_trace_posix.cc:820:41
      #2 0x5635558f1388 in content::(anonymous namespace)::DumpStackTraceSignalHandler(int) ./../../content/public/test/browser_test_base.cc:100:5
      #3 0x56353de7b9a9 in SignalHandler(int) /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:992:3
      #4 0x7fbea64d7cb0 in killpg ??:?
      #5 0x7fbea64d7cb0 in ?? ??:0
      #6 0x7fbea659f6d3 in epoll_wait ??:0:0
      #7 0x56353de3c8c4 in __interceptor_epoll_wait /b/swarming/w/ir/kitchen-workdir/src/third_party/llvm/compiler-rt/lib/msan/msan_interceptors.cc:859:13
      #8 0x563557b380a9 in epoll_dispatch ./../../base/third_party/libevent/epoll.c:198:8
      #9 0x563557b2b2ab in event_base_loop ./../../base/third_party/libevent/event.c:512:9
      #10 0x563553b868c9 in base::MessagePumpLibevent::Run(base::MessagePump::Delegate*) ./../../base/message_loop/message_pump_libevent.cc:247:9
      #11 0x5635539187b0 in base::RunLoop::Run() ./../../base/run_loop.cc:102:14
      #12 0x5635559118f9 in content::DOMMessageQueue::WaitForMessage(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) ./../../content/public/test/browser_test_utils.cc:2214:14
      #13 0x5635559025dd in content::(anonymous namespace)::ExecuteScriptHelper(content::RenderFrameHost*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, bool, int, std::__1::unique_ptr<base::Value, std::__1::default_delete<base::Value> >*) ./../../content/public/test/browser_test_utils.cc:197:26
      #14 0x563555901092 in content::ExecuteScriptAndExtractString(content::ToRenderFrameHost const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> >*) ./../../content/public/test/browser_test_utils.cc:1241:10
      #15 0x56355317b334 in extensions::browsertest_util::ExecuteScriptInBackgroundPage(content::BrowserContext*, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, extensions::browsertest_util::ScriptUserActivation) ./../../extensions/browser/browsertest_util.cc:30:15
      #16 0x5635537a2624 in ExtensionJSBrowserTest::RunJavascriptTestF(bool, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&, std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) ./../../chrome/test/base/extension_js_browser_test.cc:51:7
      #17 0x5635531d00b4 in ChromeVoxLibLouisTest_checkAllTables_Test::RunTestOnMainThread() ./gen/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test-gen.cc:35:3
      #18 0x5635558edc11 in content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() ./../../content/public/test/browser_test_base.cc:462:5
      #19 0x563553f3f2e8 in Run ./../../base/callback.h:129:12
      #20 0x563553f3f2e8 in ChromeBrowserMainParts::PreMainMessageLoopRunImpl() ./../../chrome/browser/chrome_browser_main.cc:1794:0
      #21 0x563553f3adf6 in ChromeBrowserMainParts::PreMainMessageLoopRun() ./../../chrome/browser/chrome_browser_main.cc:1182:18
      #22 0x563544c76faa in chromeos::ChromeBrowserMainPartsChromeos::PreMainMessageLoopRun() ./../../chrome/browser/chromeos/chrome_browser_main_chromeos.cc:668:32
      #23 0x56354a56555a in content::BrowserMainLoop::PreMainMessageLoopRun() ./../../content/browser/browser_main_loop.cc:984:13
      #24 0x56354bd1fdcd in Run ./../../base/callback.h:129:12
      #25 0x56354bd1fdcd in content::StartupTaskRunner::RunAllTasksNow() ./../../content/browser/startup_task_runner.cc:41:0
      #26 0x56354a55e48a in content::BrowserMainLoop::CreateStartupTasks() ./../../content/browser/browser_main_loop.cc:918:25
      #27 0x56354a5700bb in content::BrowserMainRunnerImpl::Initialize(content::MainFunctionParams const&) ./../../content/browser/browser_main_runner_impl.cc:144:15
      #28 0x56354a553eca in content::BrowserMain(content::MainFunctionParams const&) ./../../content/browser/browser_main.cc:43:32
      #29 0x5635523ecea0 in RunBrowserProcessMain ./../../content/app/content_main_runner_impl.cc:545:10
      #30 0x5635523ecea0 in content::ContentMainRunnerImpl::RunServiceManager(content::MainFunctionParams&, bool) ./../../content/app/content_main_runner_impl.cc:954:0
      #31 0x5635523ebb29 in content::ContentMainRunnerImpl::Run(bool) ./../../content/app/content_main_runner_impl.cc:868:12
      #32 0x56355db3aa61 in service_manager::Main(service_manager::MainParams const&) ./../../services/service_manager/embedder/main.cc:461:29
      #33 0x5635523e394f in content::ContentMain(content::ContentMainParams const&) ./../../content/app/content_main.cc:19:10
      #34 0x5635558ebc71 in content::BrowserTestBase::SetUp() ./../../content/public/test/browser_test_base.cc:349:3
      #35 0x563553d7b385 in InProcessBrowserTest::SetUp() ./../../chrome/test/base/in_process_browser_test.cc:284:20
      #36 0x563546763769 in HandleExceptionsInMethodIfSupported<testing::Test, void> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
      #37 0x563546763769 in testing::Test::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2517:0
      #38 0x563546767cde in testing::TestInfo::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2703:11
      #39 0x563546769a3a in testing::TestCase::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:2825:28
      #40 0x5635467a056a in testing::internal::UnitTestImpl::RunAllTests() ./../../third_party/googletest/src/googletest/src/gtest.cc:5227:43
      #41 0x56354679edd9 in HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> ./../../third_party/googletest/src/googletest/src/gtest.cc:0:0
      #42 0x56354679edd9 in testing::UnitTest::Run() ./../../third_party/googletest/src/googletest/src/gtest.cc:4835:0
      #43 0x563553df217b in RUN_ALL_TESTS ./../../third_party/googletest/src/googletest/include/gtest/gtest.h:2369:46
      #44 0x563553df217b in base::TestSuite::Run() ./../../base/test/test_suite.cc:294:0
      #45 0x56355377857d in ChromeTestSuiteRunner::RunTestSuite(int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:71:21
      #46 0x5635559a0163 in content::LaunchTests(content::TestLauncherDelegate*, unsigned long, int, char**) ./../../content/public/test/test_launcher.cc:647:31
      #47 0x563553779c0d in LaunchChromeTests(unsigned long, content::TestLauncherDelegate*, int, char**) ./../../chrome/test/base/chrome_test_launcher.cc:184:10
      #48 0x563553778331 in main ./../../chrome/test/base/browser_tests_main_chromeos.cc:21:10
      #49 0x7fbea64c2f45 in __libc_start_main ??:0:0
      #50 0x56353de1627a in _start ??:0:0
  [ RUN      ] ChromeVoxLibLouisTest.checkAllTables
  [2562:2562:0107/162500.711425:WARNING:chrome_browser_main_chromeos.cc(552)] Running as stub user with profile dir: test-user
  [2562:2562:0107/162501.159210:WARNING:easy_unlock_service_regular.cc(438)] EasyUnlockServiceRegular::IsInLegacyHostMode: DeviceSyncClient not ready. Returning false.
  [2562:2562:0107/162501.242559:INFO:remote_commands_service.cc(38)] Fetching remote commands.
  [2562:2562:0107/162501.242759:WARNING:remote_commands_service.cc(40)] Client is not registered.
  [2562:2562:0107/162501.242928:INFO:remote_commands_invalidator.cc(32)] Initialize RemoteCommandsInvalidator.
  [2562:2562:0107/162501.243067:INFO:remote_commands_invalidator.cc(57)] Starting RemoteCommandsInvalidator.
  [2562:2562:0107/162501.243179:INFO:remote_commands_invalidator.cc(123)] RemoteCommandsInvalidator ReloadPolicyData.
  [2562:2562:0107/162501.243282:INFO:remote_commands_invalidator.cc(167)] Unregister RemoteCommandsInvalidator.
  [2562:2562:0107/162501.321464:WARNING:wallpaper_controller_client.cc(358)] Cannot get wallpaper files id in RemovePolicyWallpaper. This should never happen under normal circumstances.
  [2562:2562:0107/162501.849934:ERROR:gpu_interface_provider.cc(87)] Not implemented reached in virtual void content::GpuInterfaceProvider::RegisterOzoneGpuInterfaces(service_manager::BinderRegistry *)
  [2562:2562:0107/162502.174377:ERROR:remote_text_input_client.cc(144)] Not implemented reached in virtual void RemoteTextInputClient::OnInputMethodChanged()
  [2562:2562:0107/162502.174458:ERROR:remote_text_input_client.cc(101)] Not implemented reached in virtual ui::TextInputClient::FocusReason RemoteTextInputClient::GetFocusReason() const
  [2562:2562:0107/162502.174493:ERROR:remote_text_input_client.cc(185)] Not implemented reached in virtual bool RemoteTextInputClient::ShouldDoLearning()
  [2562:2562:0107/162502.174578:ERROR:remote_text_input_client.cc(95)] Not implemented reached in virtual bool RemoteTextInputClient::HasCompositionText() const
  [2562:2562:0107/162502.174612:ERROR:remote_text_input_client.cc(107)] Not implemented reached in virtual bool RemoteTextInputClient::GetTextRange(gfx::Range *) const
  ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
  ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_card_driver returned error: No such file or directory
  ALSA lib confmisc.c:392:(snd_func_concat) error evaluating strings
  ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_concat returned error: No such file or directory
  ALSA lib confmisc.c:1251:(snd_func_refer) error evaluating name
  ALSA lib conf.c:4248:(_snd_config_evaluate) function snd_func_refer returned error: No such file or directory
  ALSA lib conf.c:4727:(snd_config_expand) Evaluate error: No such file or directory
  ALSA lib pcm.c:2239:(snd_pcm_open_noupdate) Unknown PCM default
  [2562:2591:0107/162502.414602:ERROR:alsa_util.cc(204)] PcmOpen: default,No such file or directory
  ALSA lib confmisc.c:768:(parse_card) cannot find card '0'
  ALSA lib conf.c:4248:(_snd_config_ev
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b9ad8e3604112d69fe58ad34a16384dc24a0f63

commit 9b9ad8e3604112d69fe58ad34a16384dc24a0f63
Author: David Tseng <dtseng@chromium.org>
Date: Wed Jan 09 03:40:15 2019

Reland: Migrate LibLouis to web assembly

The failing two memory sanitizer tests were disabled. This is a javascript component.

TBR=dtseng@chromium.org

Original commit:

This change ports the LibLouis C++ library from Native Client to web assembly.

Major changes:
- the js-wrapper has been re-written (liblouis_wrapper.js) and the protocol with liblouis.js is slightly changed.
- liblouis itself has been upgraded to v3.2.
- table changes have occurred resulting in removal of some tables (e.g. there is now unified French braille which supplants other French tables).
This change only removes the impacted tables with a follow up to add all new tables.
- liblouis.js was simplified.

Bug:  918730 
Test: existing unit tests.
Change-Id: If67ee266c39caeab00ea56fdbd3ee0f675809aae
Reviewed-on: https://chromium-review.googlesource.com/c/1393785
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Zachary Kuznia <zork@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#620489}
Reviewed-on: https://chromium-review.googlesource.com/c/1401049
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621034}
[modify] https://crrev.com/9b9ad8e3604112d69fe58ad34a16384dc24a0f63/DEPS
[modify] https://crrev.com/9b9ad8e3604112d69fe58ad34a16384dc24a0f63/chrome/browser/resources/chromeos/chromevox/braille/braille_table_test.extjs
[modify] https://crrev.com/9b9ad8e3604112d69fe58ad34a16384dc24a0f63/chrome/browser/resources/chromeos/chromevox/braille/braille_translator_manager.js
[modify] https://crrev.com/9b9ad8e3604112d69fe58ad34a16384dc24a0f63/chrome/browser/resources/chromeos/chromevox/braille/liblouis.js
[modify] https://crrev.com/9b9ad8e3604112d69fe58ad34a16384dc24a0f63/chrome/browser/resources/chromeos/chromevox/braille/liblouis_test.extjs
[modify] https://crrev.com/9b9ad8e3604112d69fe58ad34a16384dc24a0f63/chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions_test.extjs
[modify] https://crrev.com/9b9ad8e3604112d69fe58ad34a16384dc24a0f63/chrome/test/BUILD.gn
[rename] https://crrev.com/9b9ad8e3604112d69fe58ad34a16384dc24a0f63/chrome/test/data/chromeos/liblouis_wasm/manifest.json
[rename] https://crrev.com/9b9ad8e3604112d69fe58ad34a16384dc24a0f63/chrome/test/data/chromeos/liblouis_wasm/test.js
[modify] https://crrev.com/9b9ad8e3604112d69fe58ad34a16384dc24a0f63/third_party/liblouis/BUILD.gn
[modify] https://crrev.com/9b9ad8e3604112d69fe58ad34a16384dc24a0f63/third_party/liblouis/README.chromium
[delete] https://crrev.com/4747b6ba46d14ec3523b0169d27612eb1fd619df/third_party/liblouis/nacl_wrapper/liblouis_instance.cc
[delete] https://crrev.com/4747b6ba46d14ec3523b0169d27612eb1fd619df/third_party/liblouis/nacl_wrapper/liblouis_instance.h
[delete] https://crrev.com/4747b6ba46d14ec3523b0169d27612eb1fd619df/third_party/liblouis/nacl_wrapper/liblouis_module.cc
[delete] https://crrev.com/4747b6ba46d14ec3523b0169d27612eb1fd619df/third_party/liblouis/nacl_wrapper/liblouis_module.h
[delete] https://crrev.com/4747b6ba46d14ec3523b0169d27612eb1fd619df/third_party/liblouis/nacl_wrapper/liblouis_wrapper.cc
[delete] https://crrev.com/4747b6ba46d14ec3523b0169d27612eb1fd619df/third_party/liblouis/nacl_wrapper/liblouis_wrapper.h
[delete] https://crrev.com/4747b6ba46d14ec3523b0169d27612eb1fd619df/third_party/liblouis/nacl_wrapper/translation_params.h
[delete] https://crrev.com/4747b6ba46d14ec3523b0169d27612eb1fd619df/third_party/liblouis/nacl_wrapper/translation_result.h
[modify] https://crrev.com/9b9ad8e3604112d69fe58ad34a16384dc24a0f63/third_party/liblouis/tables.json
[rename] https://crrev.com/9b9ad8e3604112d69fe58ad34a16384dc24a0f63/third_party/liblouis/wasm/DEPS
[add] https://crrev.com/9b9ad8e3604112d69fe58ad34a16384dc24a0f63/third_party/liblouis/wasm/liblouis_wasm.data
[add] https://crrev.com/9b9ad8e3604112d69fe58ad34a16384dc24a0f63/third_party/liblouis/wasm/liblouis_wasm.js
[add] https://crrev.com/9b9ad8e3604112d69fe58ad34a16384dc24a0f63/third_party/liblouis/wasm/liblouis_wasm.wasm
[add] https://crrev.com/9b9ad8e3604112d69fe58ad34a16384dc24a0f63/third_party/liblouis/wasm/liblouis_wrapper.js
[rename] https://crrev.com/9b9ad8e3604112d69fe58ad34a16384dc24a0f63/third_party/liblouis/wasm/liblouis_wrapper_browsertest.cc

Status: Fixed (was: Started)

Sign in to add a comment