Issue metadata
Sign in to add a comment
|
180 kb regression in resource_sizes (MonochromePublic.apk) at 618856:618856 |
||||||||||||||||||||
Issue descriptionCaused by "Roll AFDO from 73.0.3650.0_rc-r1 to 73.0.3651.0_rc-r1" Commit: be5aa3be9c975a4c0c201cda1031b8e46305b25d
,
Jan 2
Assigning to chromium-autoroll@skia-public.iam.gserviceaccount.com because this is the only CL in range: Roll AFDO from 73.0.3650.0_rc-r1 to 73.0.3651.0_rc-r1 This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I152470e36863be436f02c44cd3928a48cb449cf3 Reviewed-on: https://chromium-review.googlesource.com/c/1390815 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#618856}
,
Jan 2
Thanks for the heads-up! Looks like it's on the heels of a 118K improvement from AFDO, and the most recent roll spiked it up a bit more. Will keep an eye on the chart through the rest of the week, and see if we can win some of that size back.
,
Jan 2
sg, thanks!
,
Jan 7
That's a bumpy size chart for sure :) Seems like the AFDO blips on that are (roughly) evening out, though, showing a slight favor to adding size instead of reducing it. If you want, I can check to see if there's a few big offenders (e.g. https://chromium-review.googlesource.com/c/chromium/src/+/1176963), but this appears to be regular noise to me, modulo the >100KB swing down and right back up. Thanks again!
,
Jan 8
Sounds good for now, thanks! |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jan 2