memd crash with ParseIntError overflow |
||||
Issue descriptionFrom feedback report: https://listnr.corp.google.com/product/208/report/85870333246 2018-12-26T16:54:19.674410-08:00 INFO kernel: [191719.554672] entering low_mem (avail RAM = 36 kB, avail swap 316884 kB, avail file 0 kB, anon mem: 125736 kB) 2018-12-26T16:54:19.713048-08:00 ERR memd[2154]: memd: panicked at 'memd failed: ParseIntError { kind: Overflow }', libcore/result.rs:1009:5
,
Jan 3
should we just change that to u64?
,
Jan 3
Yes, no reason not to.
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/64ee3f3806a31f64504bde77dae4559fa2187da1 commit 64ee3f3806a31f64504bde77dae4559fa2187da1 Author: Luigi Semenzato <semenzato@chromium.org> Date: Thu Jan 03 23:04:41 2019 metrics: memd: increase size of vmstat variables Some of the values (for instance, page allocations) can exceed u32 capacity on long-running systems. BUG= chromium:918714 TEST=cargo test Change-Id: If7d5563c9df29af5a217eb858a61fd49c246431b Reviewed-on: https://chromium-review.googlesource.com/1394246 Commit-Ready: Luigi Semenzato <semenzato@chromium.org> Tested-by: Luigi Semenzato <semenzato@chromium.org> Reviewed-by: Sonny Rao <sonnyrao@chromium.org> [modify] https://crrev.com/64ee3f3806a31f64504bde77dae4559fa2187da1/metrics/memd/src/test.rs [modify] https://crrev.com/64ee3f3806a31f64504bde77dae4559fa2187da1/metrics/memd/src/main.rs
,
Jan 11
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
,
Jan 16
|
||||
►
Sign in to add a comment |
||||
Comment 1 by semenzato@chromium.org
, Jan 3