New issue
Advanced search Search tips

Issue 918713 link

Starred by 5 users
Status: Fixed
Owner:
chrishtr@chromium.org
Closed: Jan 4
Cc:
atotic@chromium.org
nyerramilli@chromium.org
pbomm...@chromium.org
rbasuvula@chromium.org
l...@chromium.org
chrishtr@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Visual overflow is painted incorrectly

Project Member Reported by l...@chromium.org, Jan 2 
Chrome Version: 73.0.3660.0
OS: Linux

What steps will reproduce the problem?
(1) Open DevTools, open command menu with 'Ctrl+Shift+P'

(2) alternatively, examine this JSFiddle:
http://jsfiddle.net/s0972L3e/4/

What is the expected result?
- DevTools command menu should visually cover text behind it
- JS fiddle should show a pink box with box-shadow all around

What happens instead?
- DevTools command menu gets messy: https://imgur.com/a/6GHdbQN
- Pink box extends farther than it should, cutting off box-shadow:
https://imgur.com/a/VX2pIMU

Narrow bisect to:
https://chromium.googlesource.com/chromium/src/+/d8ebabeb38aae2a0f18e2f8e843ed069080037b5

Comment 1 by l...@chromium.org, Jan 2

Cc: atotic@chromium.org
Owner: chrishtr@chromium.org
chrishtr@, could you please take a look, in case this is related to your change?

Comment 2 by chrishtr@chromium.org, Jan 3 

In the jsfiddle, the element with class="container" that also has overflow-y: auto has a height of 3354px. Therefore the overflow of the pink box should not be clipped
out, because the only part that should be clipped out is the part outside of the border
box of the class="container" element.

Firefox also has this behavior. Perhaps it is correct now and was incorrect before.

I don't know why this would have changed due to my patch though, will investigate further.

Comment 3 by chrishtr@chromium.org, Jan 3

Owner: atotic@chromium.org

Comment 4 by l...@chromium.org, Jan 3 

c#2: thanks for taking a look.  I noticed another symptom in the fiddle, which is that the box-shadow can appear "chopped" or stop abruptly at the bottom.  I can reproduce it more easily with DevTools open, but I can also repro if I click the JSFiddle "Run" button 10 times.
choppedShadow.png
11.5 KB View Download

Comment 5 by chrishtr@chromium.org, Jan 3

Cc: nyerramilli@chromium.org chrishtr@chromium.org rbasuvula@chromium.org pbomm...@chromium.org
 Issue 918492  has been merged into this issue.

Comment 6 by chrishtr@chromium.org, Jan 3 

 Issue 918484  has been merged into this issue.

Comment 7 by chrishtr@chromium.org, Jan 3

Owner: chrishtr@chromium.org
Stealing this back - figured out the bug.

Comment 8 by chrishtr@chromium.org, Jan 4 

 Issue 918477  has been merged into this issue.
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 4 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/87923cb6db61c9e271fa0f5f5c1d3f7e3fbe4006

commit 87923cb6db61c9e271fa0f5f5c1d3f7e3fbe4006
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Fri Jan 04 02:38:28 2019

Mark for needing visual overflow recalc when marking for needing descendant layout.

CL 1391863 inadvertently removed this.

Bug:  918713 

Change-Id: I3622168c1dab40403361f8d671a3bb84af88de01
Reviewed-on: https://chromium-review.googlesource.com/c/1395557
Reviewed-by: Aleks Totic <atotic@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619865}
[modify] https://crrev.com/87923cb6db61c9e271fa0f5f5c1d3f7e3fbe4006/third_party/blink/renderer/core/layout/layout_object.cc
[modify] https://crrev.com/87923cb6db61c9e271fa0f5f5c1d3f7e3fbe4006/third_party/blink/renderer/core/layout/layout_object_test.cc

Comment 10 by chrishtr@chromium.org, Jan 4

Status: Fixed (was: Assigned)
►

Sign in to add a comment