Issue metadata
Sign in to add a comment
|
Chrome build fails (+ possible failing CL attached) |
||||||||||||||||||||
Issue description
Compilation errors:
In file included from ../../services/tracing/perfetto/json_trace_exporter.cc:5:
../../services/tracing/perfetto/json_trace_exporter.h:58:31: error: only virtual member functions can be marked 'override'
void OnDetach(bool success) override;
^~~~~~~~
../../services/tracing/perfetto/json_trace_exporter.h:59:61: error: only virtual member functions can be marked 'override'
void OnAttach(bool success, const perfetto::TraceConfig&) override;
^~~~~~~~
../../services/tracing/perfetto/json_trace_exporter.cc:288:63: error: too many arguments to function call, expected 1, have 2
consumer_endpoint_ = service->ConnectConsumer(this, /*uid=*/0);
~~~~~~~~~~~~~~~~~~~~~~~~ ^
../../third_party/perfetto/include/perfetto/tracing/core/tracing_service.h:196:3: note: 'ConnectConsumer' declared here
virtual std::unique_ptr<ConsumerEndpoint> ConnectConsumer(Consumer*) = 0;
^
3 errors generated.
Possible problematic CL:
from 2018-12-21 17:44:58
Compilation settings:
target_os="android"
target_cpu="arm"
enable_nacl=false
symbol_level=0
remove_webcore_debug_symbols=true
is_debug=false
dcheck_always_on=false
is_component_build=false
use_jumbo_build=true
,
Jan 2
I suspect that you need to update your client. The chromium src was updated on 12/20 with the methods you're trying to override and adding the additional parameter to ConnectConsumer.
,
Jan 3
,
Jan 3
gbeaty@, you were right. Sorry and thx. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by mar...@mwiacek.com
, Jan 2