DDoc LGTM

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/38e9bde2d27ab66b6e648a82664be44601c7cbd0

commit 38e9bde2d27ab66b6e648a82664be44601c7cbd0
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Jan 03 17:31:10 2019

Move chromeos_constants files to chromeos/constants

This is just:
./tools/git/move_source_file.py chromeos/chromeos_switches.* chromeos/constants/
./tools/git/move_source_file.py chromeos/chromeos_pref_names.* chromeos/constants/
./tools/git/move_source_file.py chromeos/chromeos_paths.* chromeos/constants/
./tools/git/move_source_file.py chromeos/chromeos_features.* chromeos/constants/

And some minor associated DEPS changes.

This will allow more strict DEPS checking for components depending on
//chromoes:chromeos_constants (but not //chromeos).

It also moves most of the remaining src files from src/chromeos/.

For mechanical file moves:
TBR=sky@chromium.org

Bug:  918682 
Change-Id: Ie1cd23b0b69d719cc48d9e60a27eb3c60dbd771d
Reviewed-on: https://chromium-review.googlesource.com/c/1393559
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619675}
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/DEPS
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/accelerators/accelerator_commands.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/accelerators/accelerator_controller.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/accessibility/touch_exploration_manager.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/app_list/DEPS
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/app_list/app_list_presenter_delegate_impl.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/app_list/views/app_list_main_view.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/app_list/views/search_box_view.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/assistant/assistant_controller_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/assistant/assistant_screen_context_controller_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/assistant/ui/assistant_container_view_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/display/display_color_manager_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/display/display_configuration_observer.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/display/display_prefs.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/display/display_prefs_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/highlighter/highlighter_controller.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/login/ui/lock_screen.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/mojo_interface_factory.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/root_window_controller.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/session/session_controller.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/shelf/app_list_button.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/shelf/app_list_button_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/shelf/assistant_overlay.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/shelf/login_shelf_view_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/shelf/overflow_button.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/shelf/shelf_button.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/shelf/shelf_constants.h
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/shelf/shelf_tooltip_manager.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/shelf/shelf_view.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/shell.h
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/system/accessibility/dictation_button_tray.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/system/palette/palette_tool.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/system/palette/palette_tool_manager.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/system/palette/palette_tray_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/system/palette/palette_welcome_bubble.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/system/power/power_prefs.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/system/tray/tray_constants.h
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/system/virtual_keyboard/virtual_keyboard_tray.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/voice_interaction/voice_interaction_controller.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/wallpaper/wallpaper_controller.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/ash/wallpaper/wallpaper_controller_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/app/DEPS
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/app/chrome_crash_reporter_client.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/app/chrome_main_delegate.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/about_flags.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chrome_browser_main.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chrome_content_browser_client.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chrome_resource_bundle_helper.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/accessibility/accessibility_manager.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/accessibility/accessibility_manager_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/accessibility/magnification_manager_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/accessibility/switch_access_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/account_manager/account_manager_migrator.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/android_sms/android_sms_service_factory.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/android_sms/android_sms_urls.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/app_mode/kiosk_app_manager.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/app_mode/kiosk_app_manager_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/app_mode/kiosk_app_update_service_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/app_mode/kiosk_crash_restore_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/arc/accessibility/arc_accessibility_helper_bridge_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/arc/arc_play_store_enabled_preference_handler.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/arc/arc_session_manager.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/arc/arc_session_manager_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/arc/arc_util.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/arc/arc_util_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/arc/auth/arc_auth_service.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/arc/auth/arc_auth_service_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/arc/enterprise/arc_cert_store_bridge_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/arc/intent_helper/arc_settings_service.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/arc/policy/arc_policy_util.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_arc_home_service.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/arc/voice_interaction/arc_voice_interaction_framework_service.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/arc/voice_interaction/voice_interaction_controller_client.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/attestation/attestation_ca_client.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/attestation/attestation_ca_client_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/attestation/platform_verification_flow.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/authpolicy/auth_policy_credentials_manager.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/crostini/crostini_share_path.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/crostini/crostini_share_path_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/cryptauth/gcm_device_info_provider_impl.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/customization/customization_wallpaper_downloader_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/device_sync/device_sync_client_factory.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/display/quirks_manager_delegate_impl.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/drive/drive_integration_service.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/drive/file_system_util.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/eol_notification.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/events/event_rewriter_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/extensions/backdrop_wallpaper_handlers/backdrop_wallpaper_handlers.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/extensions/default_app_order.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/extensions/default_app_order_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/extensions/echo_private_apitest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/extensions/file_manager/file_manager_private_apitest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/extensions/file_manager/private_api_strings.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/extensions/info_private_api.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/extensions/info_private_apitest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/extensions/input_method_api.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/extensions/input_method_apitest_chromeos.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/extensions/wallpaper_private_api.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/external_metrics.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/external_metrics_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/file_manager/external_filesystem_apitest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/file_manager/file_browser_handlers.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/file_manager/file_manager_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/file_manager/file_manager_browsertest_base.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/file_manager/file_tasks.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/file_manager/path_util.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/file_manager/path_util_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/file_manager/url_util.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/file_manager/url_util_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/file_manager/video_player_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/file_manager/volume_manager.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/file_manager/volume_manager_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/fileapi/external_file_url_loader_factory_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/fileapi/external_file_url_request_job_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/fileapi/file_system_backend.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/first_run/first_run.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/hats/hats_notification_controller.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/input_method/input_method_persistence_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/lock_screen_apps/note_taking_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/lock_screen_apps/state_controller.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/active_directory_login_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/active_directory_test_helper.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/chrome_restart_request.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/crash_restore_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/demo_mode/demo_app_launcher_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/demo_mode/demo_mode_detector.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/demo_mode/demo_mode_detector_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/demo_mode/demo_mode_test_helper.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/demo_mode/demo_resources.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/demo_mode/demo_session.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/demo_mode/demo_setup_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/easy_unlock/chrome_proximity_auth_client.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_regular.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/enable_debugging_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/enrollment/auto_enrollment_check_screen.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/enrollment/auto_enrollment_controller.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/enrollment/enrollment_screen_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/enrollment/hands_off_enrollment_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/existing_user_controller.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/helper.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/hwid_checker.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/kiosk_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/login_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/login_manager_test.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/login_screen_policy_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/login_ui_keyboard_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/login_utils_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/oobe_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/oobe_interactive_ui_test.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/oobe_screen.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/reset_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/saml/saml_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/screens/assistant_optin_flow_screen.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/screens/hid_detection_screen_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/screens/marketing_opt_in_screen.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/screens/network_screen_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/screens/network_screen_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/screens/reset_screen.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/screens/update_screen_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/screens/update_screen_unittest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/screens/user_selection_screen.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/screens/user_selection_screen_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/session/chrome_session_manager.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/session/chrome_session_manager_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/signin/device_id_browsertest.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/signin/oauth2_login_manager.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/startup_utils.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/test/oobe_base_test.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/test/wizard_in_process_browser_test.cc
[modify] https://crrev.com/38e9bde2d27ab66b6e648a82664be44601c7cbd0/chrome/browser/chromeos/login/ui/captive_portal_window_browsertest.cc
[modi

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc6af1cd818a24c832eba1bc20cafa7de7fab112

commit fc6af1cd818a24c832eba1bc20cafa7de7fab112
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Jan 03 18:22:02 2019

Move chromeos/ test files to chromeos/test

For trivial file moves in policy browser tests:
TBR=emaxx@chromium.org

Bug:  918682 
Change-Id: Ie46d17b4d1fb5ff6f106f7662a192eb580888d84
Reviewed-on: https://chromium-review.googlesource.com/c/1392605
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619695}
[modify] https://crrev.com/fc6af1cd818a24c832eba1bc20cafa7de7fab112/chrome/browser/chromeos/login/enrollment/enrollment_screen_browsertest.cc
[modify] https://crrev.com/fc6af1cd818a24c832eba1bc20cafa7de7fab112/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc
[modify] https://crrev.com/fc6af1cd818a24c832eba1bc20cafa7de7fab112/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/fc6af1cd818a24c832eba1bc20cafa7de7fab112/chrome/browser/chromeos/policy/user_network_configuration_updater_factory_browsertest.cc
[modify] https://crrev.com/fc6af1cd818a24c832eba1bc20cafa7de7fab112/chromeos/BUILD.gn
[modify] https://crrev.com/fc6af1cd818a24c832eba1bc20cafa7de7fab112/chromeos/app_mode/kiosk_oem_manifest_parser_unittest.cc
[modify] https://crrev.com/fc6af1cd818a24c832eba1bc20cafa7de7fab112/chromeos/network/onc/onc_test_utils.cc
[modify] https://crrev.com/fc6af1cd818a24c832eba1bc20cafa7de7fab112/chromeos/network/onc/onc_utils_unittest.cc
[rename] https://crrev.com/fc6af1cd818a24c832eba1bc20cafa7de7fab112/chromeos/test/chromeos_test_utils.cc
[rename] https://crrev.com/fc6af1cd818a24c832eba1bc20cafa7de7fab112/chromeos/test/chromeos_test_utils.h
[rename] https://crrev.com/fc6af1cd818a24c832eba1bc20cafa7de7fab112/chromeos/test/run_all_unittests.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bea303414a333107d50f90850acd7afe798e594

commit 4bea303414a333107d50f90850acd7afe798e594
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Jan 03 19:33:18 2019

chromeos/login: Create separate components

For header file moves in src/chrome:
TBR=sky@chromium.org

Bug:  918682 
Change-Id: I2cc795ada277560503aa4183075a94825d876c54
Reviewed-on: https://chromium-review.googlesource.com/c/1394003
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619718}
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/ash/DEPS
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/ash/shelf/shelf_context_menu_model_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/boot_times_recorder.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/extensions/active_tab_permission_granter_delegate_chromeos_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/extensions/device_local_account_management_policy_provider_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/extensions/extension_tab_util_delegate_chromeos_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/extensions/file_manager/event_router.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/extensions/public_session_permission_helper_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/extensions/wallpaper_function_base.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/login/auth/chrome_cryptohome_authenticator.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/login/easy_unlock/easy_unlock_service_signin_chromeos.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/login/ui/login_display_host_webui.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/login/users/chrome_user_manager.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/login/users/fake_chrome_user_manager.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/net/network_portal_detector_impl.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/net/wake_on_wifi_manager.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/profiles/profile_util.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/system/system_clock.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/chromeos/system/system_clock.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/extensions/active_tab_apitest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/extensions/active_tab_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/extensions/api/page_capture/page_capture_apitest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/extensions/api/web_request/web_request_api_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/extensions/api/web_request/web_request_permissions_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/extensions/extension_system_impl.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/media/public_session_media_access_handler.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/media/public_session_tab_capture_access_handler.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/memory/memory_kills_monitor.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/metrics/chromeos_metrics_provider_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/metrics/perf/perf_events_collector_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/metrics/perf/profile_provider_chromeos.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/metrics/perf/profile_provider_chromeos_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/profiles/profiles_state.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/signin/signin_status_metrics_provider_chromeos.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/ui/ash/chrome_screenshot_grabber.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/ui/ash/network/enrollment_dialog_view.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/ui/ash/network/mobile_data_notifications.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/ui/ash/network/mobile_data_notifications_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/ui/ash/network/network_state_notifier_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/ui/ash/session_controller_client.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/ui/ash/session_controller_client_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash_browsertest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/ui/views/apps/chrome_native_app_window_views_aura_ash_interactive_uitest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/ui/webui/chromeos/network_element_localized_strings_provider.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chrome/browser/ui/webui/chromeos/set_time_ui.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/BUILD.gn
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/components/tether/host_scan_scheduler_impl_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/cryptohome/BUILD.gn
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/dbus/BUILD.gn
[delete] https://crrev.com/c368d9b6d129ff6b01d87b3ec840d7779010db7b/chromeos/login/BUILD.gn
[delete] https://crrev.com/c368d9b6d129ff6b01d87b3ec840d7779010db7b/chromeos/login/DEPS
[add] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/BUILD.gn
[add] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/DEPS
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/auth_attempt_state.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/auth_attempt_state_resolver.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/auth_status_consumer.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/authenticator.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/authpolicy_login_helper.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/challenge_response_key.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/cryptohome_authenticator.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/cryptohome_authenticator.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/extended_authenticator.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/extended_authenticator_impl.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/extended_authenticator_impl.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/fake_extended_authenticator.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/key.h
[rename] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/login_event_recorder.cc
[rename] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/login_event_recorder.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/login_performer.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/login_performer.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/mock_auth_attempt_state_resolver.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/mock_auth_status_consumer.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/mock_url_fetchers.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/stub_authenticator.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/test_attempt_state.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/auth/user_context.h
[add] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/login_state/BUILD.gn
[rename] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/login_state/login_state.cc
[rename] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/login_state/login_state.h
[rename] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/login_state/login_state_unittest.cc
[rename] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/login_state/scoped_test_public_session_login_state.cc
[rename] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/login/login_state/scoped_test_public_session_login_state.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/network/BUILD.gn
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/network/auto_connect_handler.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/network/network_connect.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/network/network_connect_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/network/network_connection_handler_impl.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/network/network_util.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/network/prohibited_technologies_handler.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/settings/BUILD.gn
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/settings/system_settings_provider.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/chromeos/tpm/tpm_token_loader.h
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/components/arc/net/arc_net_host_impl.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/extensions/browser/api/lock_screen_data/lock_screen_item_storage_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/extensions/browser/api/networking_private/networking_private_chromeos.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/extensions/browser/api/networking_private/networking_private_chromeos_unittest.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/extensions/browser/api/web_request/web_request_api.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/extensions/browser/api/web_request/web_request_permissions.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/extensions/browser/test_extensions_browser_client.cc
[modify] https://crrev.com/4bea303414a333107d50f90850acd7afe798e594/extensions/shell/browser/shell_extensions_browser_client.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2e6eaf75e3b0da97ae6ccc5a83250c9e3e693c79

commit 2e6eaf75e3b0da97ae6ccc5a83250c9e3e693c79
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jan 04 16:52:39 2019

Make //chromeos/login non public deps of //chromeos

This forces explicit dependencies for code relying on //chromeos/login.
Only code that is part of the Chrome process should have these deps.

For minor BUILD.gn changes:
TBR=rdevlin.cronin@chromium.org,hidehiko@chromium.org

Bug:  918682 
Change-Id: Ic443725f1f6763e36a7214f569542822db94482c
Reviewed-on: https://chromium-review.googlesource.com/c/1394800
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619976}
[modify] https://crrev.com/2e6eaf75e3b0da97ae6ccc5a83250c9e3e693c79/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/2e6eaf75e3b0da97ae6ccc5a83250c9e3e693c79/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/2e6eaf75e3b0da97ae6ccc5a83250c9e3e693c79/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/2e6eaf75e3b0da97ae6ccc5a83250c9e3e693c79/chromeos/BUILD.gn
[modify] https://crrev.com/2e6eaf75e3b0da97ae6ccc5a83250c9e3e693c79/chromeos/components/tether/BUILD.gn
[modify] https://crrev.com/2e6eaf75e3b0da97ae6ccc5a83250c9e3e693c79/components/arc/BUILD.gn
[modify] https://crrev.com/2e6eaf75e3b0da97ae6ccc5a83250c9e3e693c79/extensions/browser/BUILD.gn
[modify] https://crrev.com/2e6eaf75e3b0da97ae6ccc5a83250c9e3e693c79/extensions/browser/api/BUILD.gn
[modify] https://crrev.com/2e6eaf75e3b0da97ae6ccc5a83250c9e3e693c79/extensions/shell/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d7bd9ce1d2008c2e3cf538cb652c9b585a5f760a

commit d7bd9ce1d2008c2e3cf538cb652c9b585a5f760a
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jan 04 17:47:58 2019

Move //chromeos/cryptohome from //chromeos public_deps

This moves //chromeos/cryptohome from //chromeos public_deps to deps
so that other components (chrome, ash, extensions, arc) must depend
on it explicitly.

This will also allow the dependency to be removed from src/ash.

For explicit dependency add to components/arc/BUILD.gn:
TBR=hidehiko@chromium.org

Bug:  918682 
Change-Id: I660aedbdb04b4edd9f6308d27135be9d5aab8276
Reviewed-on: https://chromium-review.googlesource.com/c/1394865
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619995}
[modify] https://crrev.com/d7bd9ce1d2008c2e3cf538cb652c9b585a5f760a/ash/BUILD.gn
[modify] https://crrev.com/d7bd9ce1d2008c2e3cf538cb652c9b585a5f760a/chrome/browser/apps/platform_apps/api/BUILD.gn
[modify] https://crrev.com/d7bd9ce1d2008c2e3cf538cb652c9b585a5f760a/chrome/browser/apps/platform_apps/api/music_manager_private/BUILD.gn
[modify] https://crrev.com/d7bd9ce1d2008c2e3cf538cb652c9b585a5f760a/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/d7bd9ce1d2008c2e3cf538cb652c9b585a5f760a/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/d7bd9ce1d2008c2e3cf538cb652c9b585a5f760a/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/d7bd9ce1d2008c2e3cf538cb652c9b585a5f760a/chromeos/BUILD.gn
[modify] https://crrev.com/d7bd9ce1d2008c2e3cf538cb652c9b585a5f760a/components/arc/BUILD.gn

If you're considering redoing directories, I would also consider how ash fits into. IMO src/ash and src/chromeos should be combined. A straw man would be:

move ash/components into chromeos/components
move ash into chromeos/ash.

I'm not sure I agree about combining src/ash and src/chromeos. src/chromeos is intended to contain lower level OS code without src/chrome or src/ash dependencies.

That said, I am in favor of moving (most) code that will be solely part of the Ash process under src/ash. Currently the majority of the code in src/chromeos is part of the Chrome process or both.

I will try to outline that better in the DD:
https://docs.google.com/document/d/1qDiZo7_Ho7TDe6XIz5YWVgMLFSB32O3udmFgadnCRc0/edit

Tangential: I think //ash/components should really be //ash/services. It doesn't have any reusable components in it, just mojo services and some non-reusable ink code.

#8: Agreed re //ash vs. //chromeos. Much/most of the code in //chromeos provides low-level functionality similar to what's provided by system libraries on Windows or macOS. This sometimes results in convoluted dependency injection (see e.g. //base/power_monitor, IIRC).

It'd probably be good if we were more disciplined about what goes in //chromeos, restricting it to just contain these low-level pieces.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/036b9b663d76dcba4f9ab91c82e8751763feba0d

commit 036b9b663d76dcba4f9ab91c82e8751763feba0d
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jan 11 17:47:57 2019

Make //chromeos/settings a component

This includes some deps cleanup of //chromeos.

For explicit DEPS extraction:
TBR=sky@chromium.org

Bug:  918682 
Change-Id: I551c9a78284e86aef229f7c12e9b8611d4514c07
Reviewed-on: https://chromium-review.googlesource.com/c/1405968
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: A Olsen <olsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622052}
[modify] https://crrev.com/036b9b663d76dcba4f9ab91c82e8751763feba0d/ash/BUILD.gn
[modify] https://crrev.com/036b9b663d76dcba4f9ab91c82e8751763feba0d/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/036b9b663d76dcba4f9ab91c82e8751763feba0d/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/036b9b663d76dcba4f9ab91c82e8751763feba0d/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/036b9b663d76dcba4f9ab91c82e8751763feba0d/chromeos/BUILD.gn
[modify] https://crrev.com/036b9b663d76dcba4f9ab91c82e8751763feba0d/chromeos/settings/BUILD.gn
[add] https://crrev.com/036b9b663d76dcba4f9ab91c82e8751763feba0d/chromeos/settings/DEPS
[modify] https://crrev.com/036b9b663d76dcba4f9ab91c82e8751763feba0d/chromeos/settings/cros_settings_names.h
[modify] https://crrev.com/036b9b663d76dcba4f9ab91c82e8751763feba0d/chromeos/settings/cros_settings_provider.h
[modify] https://crrev.com/036b9b663d76dcba4f9ab91c82e8751763feba0d/chromeos/settings/system_settings_provider.h
[modify] https://crrev.com/036b9b663d76dcba4f9ab91c82e8751763feba0d/chromeos/settings/timezone_settings.h
[modify] https://crrev.com/036b9b663d76dcba4f9ab91c82e8751763feba0d/chromeos/settings/timezone_settings_helper.cc
[modify] https://crrev.com/036b9b663d76dcba4f9ab91c82e8751763feba0d/services/device/time_zone_monitor/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/cc799d40f9b62fb97ca873695c44987b4f69f519

commit cc799d40f9b62fb97ca873695c44987b4f69f519
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jan 11 19:31:40 2019

Fix chromeos_export

chromeos_export.h is being included outside of src/chromeos which
should not be the case. This is probably from files moved out of
src/chromeos. This CL fixes those and makes chromeos_export a non
public deps of //chromeos.

Bug:  918682 
Change-Id: I6bf394f0c933b8259f7567cfbb514c936b2d457c
Reviewed-on: https://chromium-review.googlesource.com/c/1405979
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: A Olsen <olsen@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622093}
[modify] https://crrev.com/cc799d40f9b62fb97ca873695c44987b4f69f519/build/check_gn_headers_whitelist.txt
[modify] https://crrev.com/cc799d40f9b62fb97ca873695c44987b4f69f519/chrome/browser/chromeos/fileapi/external_file_url_loader_factory.h
[modify] https://crrev.com/cc799d40f9b62fb97ca873695c44987b4f69f519/chrome/browser/chromeos/login/users/default_user_image/default_user_images.h
[modify] https://crrev.com/cc799d40f9b62fb97ca873695c44987b4f69f519/chrome/browser/chromeos/network_change_manager_client.h
[modify] https://crrev.com/cc799d40f9b62fb97ca873695c44987b4f69f519/chrome/browser/chromeos/power/power_data_collector.h
[modify] https://crrev.com/cc799d40f9b62fb97ca873695c44987b4f69f519/chrome/browser/chromeos/power/process_data_collector.h
[modify] https://crrev.com/cc799d40f9b62fb97ca873695c44987b4f69f519/chrome/browser/chromeos/power/renderer_freezer.h
[modify] https://crrev.com/cc799d40f9b62fb97ca873695c44987b4f69f519/chrome/browser/chromeos/printing/external_printers.h
[modify] https://crrev.com/cc799d40f9b62fb97ca873695c44987b4f69f519/chrome/browser/chromeos/system/input_device_settings.h
[modify] https://crrev.com/cc799d40f9b62fb97ca873695c44987b4f69f519/chromeos/BUILD.gn
[modify] https://crrev.com/cc799d40f9b62fb97ca873695c44987b4f69f519/chromeos/components/drivefs/pending_connection_manager.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/368a1c87a6e58031623896eb7b86c29de6c6d2a9

commit 368a1c87a6e58031623896eb7b86c29de6c6d2a9
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jan 11 20:45:22 2019

Move chromeos/accelerometer -> ash

src/chromeos/accelerometer is only used in src/, and it has a //ui
dependency, so move the code to src/ash.

Bug:  918682 
Change-Id: Ic87abd39d494628d747d7b97da009a3e2fa8b70c
Reviewed-on: https://chromium-review.googlesource.com/c/1406270
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622134}
[modify] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/ash/BUILD.gn
[modify] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/ash/DEPS
[rename] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/ash/accelerometer/accelerometer_reader.cc
[rename] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/ash/accelerometer/accelerometer_reader.h
[rename] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/ash/accelerometer/accelerometer_types.cc
[rename] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/ash/accelerometer/accelerometer_types.h
[modify] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/ash/display/display_manager_unittest.cc
[modify] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/ash/display/display_prefs_unittest.cc
[modify] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/ash/display/screen_orientation_controller.cc
[modify] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/ash/display/screen_orientation_controller.h
[modify] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/ash/display/screen_orientation_controller_unittest.cc
[modify] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/ash/shell.cc
[modify] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/ash/system/power/power_button_controller.cc
[modify] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/ash/system/power/power_button_controller.h
[modify] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/ash/wm/tablet_mode/tablet_mode_controller.cc
[modify] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/ash/wm/tablet_mode/tablet_mode_controller.h
[modify] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/ash/wm/tablet_mode/tablet_mode_controller_test_api.cc
[modify] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/ash/wm/tablet_mode/tablet_mode_controller_unittest.cc
[modify] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/368a1c87a6e58031623896eb7b86c29de6c6d2a9/chromeos/BUILD.gn
[delete] https://crrev.com/7bf67d59f0bef40c7728dd39a9629dbc4100fd95/chromeos/accelerometer/DEPS

Marking this as done:
* All dbus dependencies have been removed from //chromeos.
* All source code (except chromeos_export.h) has been moved fom src/chromeos/.
* All subdirectries with a BUILD.gn file are separate components, not included as //chromeos deps.
* The folowing subdirectories remain part of //chromeos. We can remove them independently if needed :

chromeos/account_manager
chromeos/app_mode
chromeos/hugepage_text
chromeos/policy
chromeos/printing
chromeos/process_proxy
chromeos/system

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/714bbc541b87bba4dbd2b44313219b219945fde7

commit 714bbc541b87bba4dbd2b44313219b219945fde7
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Jan 16 01:59:33 2019

//chromeos GN cleanup

This CL:
* Moves system/devicetype to chromeos/constants to reduce dependencies
  for code that includes devicetype.h (which onbly depends on //base).
* Removes dependencies on //chromeos that are no longer necessary.
* Updates //chromeos and //chromeos/dbus dependencies in test targets
  to use :test_support.

For straightforward deps removal and file renames in:
    components/exo
    components/metrics
    components/pairing
    components/rlz
    components/sync
    content/shell
    device/bluetooth/bluez
    device/usb
    extensions/shell
    media/audio
    ui/keyboard
TBR=sky@chromium.org

Bug:  918682 
Change-Id: I4c83b5703303fc01f64d21c43a4b9b6690c79fef
Reviewed-on: https://chromium-review.googlesource.com/c/1407388
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623018}
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/chrome/browser/chromeos/extensions/info_private_api.cc
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/chrome/browser/chromeos/power/ml/adaptive_screen_brightness_manager.cc
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/chrome/browser/chromeos/power/ml/user_activity_controller.cc
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/chrome/browser/chromeos/power/ml/user_activity_manager.cc
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/chrome/test/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/chromeos/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/chromeos/components/drivefs/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/chromeos/components/multidevice/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/chromeos/components/multidevice/debug_webui/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/chromeos/components/proximity_auth/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/chromeos/components/tether/BUILD.gn
[rename] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/chromeos/constants/devicetype.cc
[rename] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/chromeos/constants/devicetype.h
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/chromeos/services/assistant/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/chromeos/services/machine_learning/public/cpp/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/components/exo/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/components/metrics/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/components/pairing/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/components/pairing/DEPS
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/components/pairing/bluetooth_host_pairing_controller.cc
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/components/rlz/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/components/sync/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/components/sync/base/get_session_name.cc
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/content/browser/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/content/shell/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/content/test/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/device/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/device/bluetooth/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/device/bluetooth/bluez/bluetooth_adapter_bluez.cc
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/device/usb/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/extensions/shell/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/media/audio/BUILD.gn
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/ui/chromeos/devicetype_utils.cc
[modify] https://crrev.com/714bbc541b87bba4dbd2b44313219b219945fde7/ui/keyboard/BUILD.gn