New issue
Advanced search Search tips

Issue 918681 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 10
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Update the button spec for Chrome

Project Member Reported by namratakannan@chromium.org, Jan 2

Issue description

Follow GM2 spec for secondary UI buttons on Mac.
Found here:
https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g3232c09376_10_328

@Alan: has the spec already implemented for Windows?
 
Description: Show this description
Re: "has the spec already implemented for Windows", it's the same code path.
Owner: lgrey@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c301f0abb8821646d3acea02aa73425360157d86

commit c301f0abb8821646d3acea02aa73425360157d86
Author: Leonard Grey <lgrey@chromium.org>
Date: Thu Jan 10 00:32:10 2019

Update MD buttons for MD refresh

This change fixes a few things that fell through the cracks in MD refresh,
as part of the work to enable dark mode. Specifically:

- Updates text colors
- Untethers non-prominent button border from text color
- Updates disabled prominent button appearance to use a grey background,
instead of shading the enabled background

Spec: https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g34d24941d1_37_5

Bug:  918681 
Change-Id: I5ef400ed35b5c85c90c9ee3b5c33703136bdc9b0
Reviewed-on: https://chromium-review.googlesource.com/c/1399044
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621391}
[modify] https://crrev.com/c301f0abb8821646d3acea02aa73425360157d86/chrome/browser/ui/libgtkui/native_theme_gtk.cc
[modify] https://crrev.com/c301f0abb8821646d3acea02aa73425360157d86/chrome/browser/ui/views/chrome_typography_provider.cc
[modify] https://crrev.com/c301f0abb8821646d3acea02aa73425360157d86/ui/native_theme/common_theme.cc
[modify] https://crrev.com/c301f0abb8821646d3acea02aa73425360157d86/ui/native_theme/native_theme.h
[modify] https://crrev.com/c301f0abb8821646d3acea02aa73425360157d86/ui/native_theme/native_theme_dark_aura.cc
[modify] https://crrev.com/c301f0abb8821646d3acea02aa73425360157d86/ui/views/controls/button/md_text_button.cc

Status: Fixed (was: Assigned)

Sign in to add a comment