Some symbols don't get demangled when printing a stack trace |
||
Issue descriptionThree symbols in the below stack trace don't get demangled properly: #0 0x7fe7cf995c3f base::debug::StackTrace::StackTrace() #1 0x5563c18b80f5 NotificationPlatformBridgeLinuxImpl::OnConnectionInitializationFinishedOnTaskRunner() #2 0x7fe7cf8ca0b4 base::(anonymous namespace)::BarrierInfo::Run() #3 0x7fe7caf31e18 _ZN4base8internal7InvokerINS0_9BindStateINS_12OnceCallbackIFvRKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEESC_bEEEJSA_SA_EEEFvbEE7RunOnceEPNS0_13BindStateBaseEb #4 0x7fe7caf2d612 base::internal::ReplyAdapter<>() #5 0x7fe7caf2d6c7 _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_12OnceCallbackIFvbEEEPNSt3__110unique_ptrIbNS6_14default_deleteIbEEEEEJS5_NS0_12OwnedWrapperISA_EEEEEFvvEE7RunOnceEPNS0_13BindStateBaseE #6 0x7fe7cf963f7e base::(anonymous namespace)::PostTaskAndReplyRelay::RunReply() #7 0x7fe7cf96400a _ZN4base8internal7InvokerINS0_9BindStateIPFvNS_12_GLOBAL__N_121PostTaskAndReplyRelayEEJS4_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE #8 0x7fe7cf8d6dc5 base::debug::TaskAnnotator::RunTask() #9 0x7fe7cf958a9d base::internal::TaskTracker::RunSkipOnShutdown() #10 0x7fe7cf95862b base::internal::TaskTracker::RunOrSkipTask() #11 0x7fe7cf9a58eb base::internal::TaskTrackerPosix::RunOrSkipTask() #12 0x7fe7cf957b2e base::internal::TaskTracker::RunAndPopNextTask() #13 0x7fe7cf94ecd9 base::internal::SchedulerWorker::RunWorker() #14 0x7fe7cf94eaf4 base::internal::SchedulerWorker::RunSharedWorker() #15 0x7fe7cf9a608e base::(anonymous namespace)::ThreadFunc() #16 0x7fe7c57f4494 start_thread #17 0x7fe7c3746a8f clone I've narrowed this down to a bug in glog's Demangle impl, patch coming soon. This bug is should track rolling the fix into Chromium
,
Jan 2
It would change a bunch of signature, but only of stacks with "bad" stacks. So I'd say it's still worth it.
,
Jan 2
Pull request opened: https://github.com/google/glog/pull/414
,
Jan 2
With change, the same stack trace now looks like: base::debug::StackTrace::StackTrace() NotificationPlatformBridgeLinuxImpl::OnConnectionInitializationFinishedOnTaskRunner() base::(anonymous namespace)::BarrierInfo::Run() base::internal::Invoker<>::RunOnce() base::internal::ReplyAdapter<>() base::internal::Invoker<>::RunOnce() base::(anonymous namespace)::PostTaskAndReplyRelay::RunReply() base::internal::Invoker<>::RunOnce() base::debug::TaskAnnotator::RunTask() base::internal::TaskTracker::RunSkipOnShutdown() base::internal::TaskTracker::RunOrSkipTask() base::internal::TaskTrackerPosix::RunOrSkipTask() base::internal::TaskTracker::RunAndPopNextTask() base::internal::SchedulerWorker::RunWorker() base::internal::SchedulerWorker::RunSharedWorker() base::(anonymous namespace)::ThreadFunc() start_thread
,
Jan 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/eb2944ac6bf45fffc866a70d3f0450f751c9e9d7 commit eb2944ac6bf45fffc866a70d3f0450f751c9e9d7 Author: Tom Anderson <thomasanderson@chromium.org> Date: Mon Jan 07 23:43:51 2019 Update glog symbolize to 5d46e1b BUG= 918678 R=thakis Change-Id: I488cec40cba2d4e56da636862d603d96f21969f4 Reviewed-on: https://chromium-review.googlesource.com/c/1398312 Reviewed-by: Nico Weber <thakis@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#620526} [modify] https://crrev.com/eb2944ac6bf45fffc866a70d3f0450f751c9e9d7/base/third_party/symbolize/README.chromium [modify] https://crrev.com/eb2944ac6bf45fffc866a70d3f0450f751c9e9d7/base/third_party/symbolize/demangle.cc
,
Jan 7
|
||
►
Sign in to add a comment |
||
Comment 1 by thomasanderson@chromium.org
, Jan 2