[BlinkGenPropertyTrees] Composited scrolling contents is not clipped |
||
Issue descriptionOpen the attached testcase with --enable-blink-features=BlinkGenPropertyTrees and notice the composited content is not clipped (see screenshot).
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/db3231465d3d1a4f05c68e05935ad2085f855e11 commit db3231465d3d1a4f05c68e05935ad2085f855e11 Author: Philip Rogers <pdr@chromium.org> Date: Thu Jan 03 21:01:30 2019 Account for layout overflow when omitting overflow clip When deciding whether an overflow clip paint property node is needed, we previously checked if the visual overflow extended beyond the overflow clip rect. This would miss cases when the visual overflow was empty (e.g., descendants with width: 0) but the content was still scrollable. This patch adds a check for layout overflow. While in the area, the condition for visual overflow has been refactored to make the self-painting PaintLayer case a little clearer. The early-out for PaintLayer descendants is required for correctness. Bug: 918675 Change-Id: I41fe5fd71a957f196b5b8095965d4e361e535196 Reviewed-on: https://chromium-review.googlesource.com/c/1393885 Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619749} [modify] https://crrev.com/db3231465d3d1a4f05c68e05935ad2085f855e11/third_party/blink/renderer/core/paint/paint_property_tree_builder.cc [modify] https://crrev.com/db3231465d3d1a4f05c68e05935ad2085f855e11/third_party/blink/renderer/core/paint/paint_property_tree_builder_test.cc [modify] https://crrev.com/db3231465d3d1a4f05c68e05935ad2085f855e11/third_party/blink/web_tests/flag-specific/enable-blink-features=LayoutNG/paint/invalidation/selection/text-selection-rect-in-overflow-expected.txt [modify] https://crrev.com/db3231465d3d1a4f05c68e05935ad2085f855e11/third_party/blink/web_tests/platform/win/paint/invalidation/overflow/overflow-delete-line-expected.txt
,
Jan 3
|
||
►
Sign in to add a comment |
||
Comment 1 by schenney@chromium.org
, Jan 3