macviews: checked checkboxes appear faded with blue accent & low contrast mode |
||||||||
Issue descriptionThey draw as though they are disabled. An easy way to reproduce this is to remove an extension via right-clicking its icon, then check the "Report abuse" checkbox - note that it becomes quite faded.
,
Jan 3
I think you're right - it returns 3f0067f4, which is a very vibrant blue with a very low alpha. I would have thought that this would have caused FocusRing to draw very lightly as well, but FocusRing forces the alpha to be 0x66 on the color it uses - on earlier platforms this was necessary because the focus ring color was the "base" color with no alpha, and on newer platforms it causes the very low alpha of keyboardFocusIndicatorColor to turn into a pleasing light blue. Setting the alpha to 0xff causes the checkbox to be "too blue". I'm actually pretty skeptical of using FocusedBorderColor here at all though - probably instead we should be using something from TypographyProvider.
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91445be6d6e4e36f5358282cdd030fe7e35727b8 commit 91445be6d6e4e36f5358282cdd030fe7e35727b8 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Thu Jan 03 19:50:42 2019 views: use correct color for enabled checkbox/radio images The existing code used FocusedBorderColor, which happened to be equal to ProminentButtonColor on non-Mac and close enough on Mac that nobody noticed the disparity. Mojave changed the color that underlies FocusedBorderColor, which made checkboxes start drawing very faintly. Bug: 918673 Change-Id: If73a4607bb5857e4b61d67cfd7e9f58ebd341021 Reviewed-on: https://chromium-review.googlesource.com/c/1394434 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#619724} [modify] https://crrev.com/91445be6d6e4e36f5358282cdd030fe7e35727b8/ui/views/controls/button/checkbox.cc
,
Jan 4
Requesting merge to M72 - merge risk is near zero here.
,
Jan 4
branch:3626
,
Jan 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb3cc750cd4157bcee31bc8f76fcaff6b70dd535 commit bb3cc750cd4157bcee31bc8f76fcaff6b70dd535 Author: Elly Fong-Jones <ellyjones@chromium.org> Date: Fri Jan 04 18:53:24 2019 views: use correct color for enabled checkbox/radio images The existing code used FocusedBorderColor, which happened to be equal to ProminentButtonColor on non-Mac and close enough on Mac that nobody noticed the disparity. Mojave changed the color that underlies FocusedBorderColor, which made checkboxes start drawing very faintly. Bug: 918673 Change-Id: If73a4607bb5857e4b61d67cfd7e9f58ebd341021 Reviewed-on: https://chromium-review.googlesource.com/c/1394434 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#619724}(cherry picked from commit 91445be6d6e4e36f5358282cdd030fe7e35727b8) Reviewed-on: https://chromium-review.googlesource.com/c/1395884 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#564} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/bb3cc750cd4157bcee31bc8f76fcaff6b70dd535/ui/views/controls/button/checkbox.cc
,
Jan 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bb3cc750cd4157bcee31bc8f76fcaff6b70dd535 Commit: bb3cc750cd4157bcee31bc8f76fcaff6b70dd535 Author: ellyjones@chromium.org Commiter: ellyjones@chromium.org Date: 2019-01-04 18:53:24 +0000 UTC views: use correct color for enabled checkbox/radio images The existing code used FocusedBorderColor, which happened to be equal to ProminentButtonColor on non-Mac and close enough on Mac that nobody noticed the disparity. Mojave changed the color that underlies FocusedBorderColor, which made checkboxes start drawing very faintly. Bug: 918673 Change-Id: If73a4607bb5857e4b61d67cfd7e9f58ebd341021 Reviewed-on: https://chromium-review.googlesource.com/c/1394434 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#619724}(cherry picked from commit 91445be6d6e4e36f5358282cdd030fe7e35727b8) Reviewed-on: https://chromium-review.googlesource.com/c/1395884 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#564} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 7
Able to reproduce this issue on Mac OS 10.14 on the build without Fix 73.0.3647.0 and the issue is fixed on the latest M-73 build 73.0.3664.0. 1. Launched Chrome and added Hangouts extension. 2. Right clicked on the Extension icon -> Remove from Chrome -> Checked Report Abuse checkbox. 3. Could observe that the checkbox is bright and not faded. Attached is the screen shot for reference. Hence adding TE verified labels as the fix is working as intended. Thanks..
,
Jan 7
,
Jan 9
Able to reproduce this issue on Mac OS 10.14 on the build without Fix 73.0.3647.0 and the issue is fixed on the latest M-72 build 72.0.3626.53. 1. Launched Chrome and added Hangouts extension. 2. Right clicked on the Extension icon -> Remove from Chrome -> Checked Report Abuse checkbox. 3. Could observe that the checkbox is bright and not faded. Attached is the screen shot for reference. Hence adding TE verified labels as the fix is working as intended. Thanks.. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by lgrey@chromium.org
, Jan 2case kColorId_FocusedBorderColor: return NSSystemColorToSkColor([NSColor keyboardFocusIndicatorColor]); Probably something up with the color returned for this in Mojave.