NOTREACHED reached in gl_image_ahardwarebuffer |
||||
Issue descriptionThis CL introduced new code, which triggers a NOTREACHED(): https://chromium-review.googlesource.com/c/chromium/src/+/1380820 Logs from right before the crash have it pass through this line: https://cs.corp.google.com/android/frameworks/av/media/ndk/NdkImageReader.cpp?l=450 Here are some logs that looked interesting: [...] V chromium: [VERBOSE1:ffmpeg_common.cc(734)] Unsupported AVPixelFormat: -1 [...] W MapperHal: buffer descriptor with invalid usage bits 0x2000 E OMX-VDEC-1080P: Does not handle dataspace request E OMXNodeInstance: getConfig(0xe5492544:qcom.decoder.avc, ??(0x7f00005e)) ERROR: UnsupportedSetting(0x80001019) E cnss-daemon: wlan_service_update_tcp_params: Unsupported throughput value 0 W MapperHal: buffer descriptor with invalid usage bits 0x2000 W MapperHal: buffer descriptor with invalid usage bits 0x2000 D NdkImageReader: acquireImageLocked: Overriding buffer format YUV_420_888 to 0x7fa30c06. F chromium: [FATAL:gl_image_ahardwarebuffer.cc(30)] Check failed: false. [...] Version: 73.0.366.0 Platform: Android Repro steps: - Navigate to http://storage.googleapis.com/watk/v - Play the first video - Chrome crashes
,
Jan 2
looking at it with high priority.
,
Jan 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8d3a7757f252b2c69586d683243a64dac4c4c36 commit b8d3a7757f252b2c69586d683243a64dac4c4c36 Author: Vikas Soni <vikassoni@chromium.org> Date: Wed Jan 02 22:44:21 2019 Fix GLImageAHardwareBuffer internal format. Remove NOTREACHED() from the internal format calculations for GLImageAHardwareBuffer. All the default buffer format should use GL_RGBA as internal format. Bug: 918661 Change-Id: Id15561161def1891674f8eb62bc8e189665991c5 Reviewed-on: https://chromium-review.googlesource.com/c/1393544 Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: vikas soni <vikassoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#619521} [modify] https://crrev.com/b8d3a7757f252b2c69586d683243a64dac4c4c36/ui/gl/gl_image_ahardwarebuffer.cc
,
Jan 2
,
Jan 2
Hi tguilbert@, I have fixed this issue. Thank you for helping to find this bug. can you please verify with ToT and close the bug. thanks
,
Jan 2
Built from ToT, and it works. Thank you for the quick fix! |
||||
►
Sign in to add a comment |
||||
Comment 1 by tguilbert@chromium.org
, Jan 2