New issue
Advanced search Search tips

Issue 918597 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 12
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.9%-24.6% regression in rendering.mobile/thread_total_all_cpu_time_per_frame at 618969:618992

Project Member Reported by lanwei@chromium.org, Jan 2

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=918597

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=fcdd403a4394fad05fc8660d7a50db64627e6ed990734dcba8164d6c1ec6f6e5


Bot(s) for this bug's original alert(s):

Android Nexus5X WebView Perf
Android Nexus6 WebView Perf

rendering.mobile - Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Cc: chrishtr@chromium.org
Owner: chrishtr@chromium.org
Status: Assigned (was: Untriaged)
📍 Found a significant difference after 1 commit.
https://pinpoint-dot-chromeperf.appspot.com/job/1451453c940000

Move visual overflow computation into the descendant-dependent tree walk. by chrishtr@chromium.org
https://chromium.googlesource.com/chromium/src/+/395a93a5ea18f0890a237d5e687a80b69f39a473
thread_total_all_cpu_time_per_frame: 7.843 → 10.95 (+3.103)

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions

Benchmark documentation link:
  https://bit.ly/rendering-benchmarks
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36665607b4f8ed9a692a142de420da8913805aaa

commit 36665607b4f8ed9a692a142de420da8913805aaa
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Fri Jan 11 18:21:28 2019

Move invalidation of compositing inputs when
setting needs overflow recalc to PaintLayer.

Bug:  918597 , 918598
Change-Id: I7736dc073deabdcf773d29574f6448c08cb699b1
Reviewed-on: https://chromium-review.googlesource.com/c/1405452
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622060}
[modify] https://crrev.com/36665607b4f8ed9a692a142de420da8913805aaa/third_party/blink/renderer/core/layout/layout_block.cc
[modify] https://crrev.com/36665607b4f8ed9a692a142de420da8913805aaa/third_party/blink/renderer/core/layout/layout_block_flow.cc
[modify] https://crrev.com/36665607b4f8ed9a692a142de420da8913805aaa/third_party/blink/renderer/core/layout/layout_list_item.cc
[modify] https://crrev.com/36665607b4f8ed9a692a142de420da8913805aaa/third_party/blink/renderer/core/layout/layout_multi_column_set.cc
[modify] https://crrev.com/36665607b4f8ed9a692a142de420da8913805aaa/third_party/blink/renderer/core/layout/layout_table.cc
[modify] https://crrev.com/36665607b4f8ed9a692a142de420da8913805aaa/third_party/blink/renderer/core/layout/layout_text_control_single_line.cc
[modify] https://crrev.com/36665607b4f8ed9a692a142de420da8913805aaa/third_party/blink/renderer/core/layout/ng/layout_ng_mixin.cc
[modify] https://crrev.com/36665607b4f8ed9a692a142de420da8913805aaa/third_party/blink/renderer/core/paint/paint_layer.cc
[modify] https://crrev.com/36665607b4f8ed9a692a142de420da8913805aaa/third_party/blink/renderer/core/paint/paint_layer.h
[modify] https://crrev.com/36665607b4f8ed9a692a142de420da8913805aaa/third_party/blink/renderer/core/scheduler/frame_throttling_test.cc

Status: Fixed (was: Assigned)
Cc: yhirano@chromium.org aee@chromium.org m...@chromium.org
 Issue 921171  has been merged into this issue.

Sign in to add a comment