New issue
Advanced search Search tips

Issue 918584 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

297.5 kb regression in resource_sizes (MonochromePublic.apk) at 618330:618330

Project Member Reported by estevenson@chromium.org, Jan 2

Issue description

Caused by "Upgrade to ARCore SDK 1.5"

Commit: dbf4acb16a15c8e3fa55a8b689d9571693aa34a9

This CL also caused method count and string count alerts, and corresponding downstream alerts.

This won't be shipped to stable, but filing a bug for reference anyway since the CL caused several alerts. 
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=918584

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=0acf1dc1ea669b0e38e61a101959488341e8ecc9fc43c6df29d639f98d89d204


Bot(s) for this bug's original alert(s):

Android Builder Perf
Owner: bialpio@chromium.org
Status: Assigned (was: Untriaged)
Assigning to bialpio@chromium.org because this is the only CL in range:
Upgrade to ARCore SDK 1.5

Remove ARCore SDK 1.1 now that we are switching to newer version.

android-binary-size trybot was complaining about growth of APK - this
is suppressed by adding "Binary-Size" explanation in the footer.

The size impact is 300369 additional bytes - it should be acceptable
since it only affects canary & dev channels (not present on stable).
Additionally, the AR support will be deployed as a DFM when we release
it, so the impact on on base APK size should be way smaller than what
is currently reported by trybots.


             is currently only packaged for dev, canary and default
             channels.

Bug: 887669
Change-Id: I56a2230f31b4e17925ddb4e2d2b20266e55c1091
Binary-Size: Increase is due to packaging ARCore into the APK. ARCore
Reviewed-on: https://chromium-review.googlesource.com/c/1357349
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618330}
Status: WontFix (was: Assigned)

Sign in to add a comment