New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 918582 link

Starred by 4 users

Issue metadata

Status: ExternalDependency
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Feature

Blocking:
issue 919961



Sign in to add a comment

[Dark mode] Support dark mode for the One Google Bar on the NTP

Project Member Reported by ramyan@chromium.org, Jan 2

Issue description

The Material OGB will soon support dark mode in its app switcher and notifications area, when requested. This tracks the Local NTP changes required to request dark_mode_enabled, and is dependent on b/120854278.

The user can switch to dark mode while the NTP is open - can we force a refresh of the OGB into dark mode?

Note: dark mode support for shortcut icons is tracked separately in  issue 914982 .
 
Blocking: 919961
Labels: KR-NTP-Dark-Mode
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/680ed8f316f5f4241b9a614043d88fa4f3ed8d83

commit 680ed8f316f5f4241b9a614043d88fa4f3ed8d83
Author: Kristi Park <kristipark@chromium.org>
Date: Fri Jan 18 20:09:39 2019

[NTP] Use white One Google Bar and white Google logo when in dark mode

If dark mode is enabled, use the white One Google Bar and white Google
logo. If a theme is installed, use the default theme values.

Bug: 919961, 918582
Change-Id: Id9fe74511a7f18e1256372ed3b782fd5266ca543
Reviewed-on: https://chromium-review.googlesource.com/c/1419362
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Kyle Milka <kmilka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624252}
[modify] https://crrev.com/680ed8f316f5f4241b9a614043d88fa4f3ed8d83/chrome/browser/resources/local_ntp/local_ntp.js

Sign in to add a comment