New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 918574 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

em100: Update ebuild to use coreboot version

Project Member Reported by sjg@chromium.org, Jan 2

Issue description

The current Chrome OS em100 code is pretty old. We should sync this with the coreboot version.

Also we should add support for the G2 version's ability to change between 1.8V and 3.3V.
 
Cc: rrangel@chromium.org reinauer@chromium.org
Owner: sjg@google.com
Status: Started (was: Untriaged)
Owner: sjg@chromium.org
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/em100/+/11f262ab3be6d3c96a74c60b5eb55957c41e7d05

commit 11f262ab3be6d3c96a74c60b5eb55957c41e7d05
Author: Simon Glass <sjg@chromium.org>
Date: Sun Jan 06 04:08:37 2019

Bring in upstream code from coreboot

The coreboot repository has a much newer version of this utility. Bring
in the current source code as a single commit.

This is commit 489da9f9 at http://review.coreboot.org/em100

The coreboot repo does not have any release tags so it is probably not
a good idea to update the ebuild to point directly to that repo. But once
the tool has been revised for -G2 support, we should consider setting up
a release procedure for that.

BUG=chromium:918574
TEST=sudo emerge --nodeps em100

Change-Id: Id251b1469c618a20900175602c5bc476d5303dac
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1393408
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Reviewed-by: Raul E Rangel <rrangel@chromium.org>

[add] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/makedpfw.c
[add] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/system.c
[modify] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/makechips.sh
[add] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/em100.h
[modify] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/protocol-notes.txt
[add] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/hexdump.c
[modify] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/Makefile
[modify] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/em100.c
[modify] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/em100pro_chips.h
[modify] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/makechips.c
[add] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/trace.c
[add] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/usb.c
[add] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/spi.c
[modify] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/.gitignore
[add] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/usb-protocol.md
[modify] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/README
[add] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/firmware.c
[add] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/fpga.c
[add] https://crrev.com/11f262ab3be6d3c96a74c60b5eb55957c41e7d05/sdram.c

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/em100/+/3ddfd1779ecab8d1533a63ec96c5d347d87806d8

commit 3ddfd1779ecab8d1533a63ec96c5d347d87806d8
Author: Simon Glass <sjg@chromium.org>
Date: Tue Jan 15 10:54:45 2019

Allow selection of FPGA version for 1.8/3.3V

Add a -V flag to change the FPGA version to use so that we can switch
between 1.8V and 3.3V. This is only supported on EM100-Pro-G2 units.

It should be possible to automatically change the voltage depending on
the selected SPI-flash chip, but I have not looked at that yet.

BUG=chromium:918574
TEST=em100 -V 1.8
See that it changes to 1.8V and reports that on start-up:
$ sudo ./em100
MCU version: 3.03
FPGA version: 2.10 (3.3V)
Serial number: DP142535
SPI flash database: 4.3.01
EM100Pro currently stopped
EM100Pro hold pin currently low

$ sudo ./em100 -V 1.8
MCU version: 3.03
FPGA version: 2.10 (3.3V)
Serial number: DP142535
SPI flash database: 4.3.01
EM100Pro currently stopped
EM100Pro hold pin currently low

Voltage set to 1.8
$ sudo ./em100
MCU version: 3.03
FPGA version: 2.10 (1.8V)
Serial number: DP142535
SPI flash database: 4.3.01
EM100Pro currently stopped
EM100Pro hold pin currently low

Change-Id: I9a8ea932027978129d021ec166dc7fbd126b0f1e
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-on: https://chromium-review.googlesource.com/1393563
Reviewed-by: Raul E Rangel <rrangel@chromium.org>

[modify] https://crrev.com/3ddfd1779ecab8d1533a63ec96c5d347d87806d8/em100.c
[modify] https://crrev.com/3ddfd1779ecab8d1533a63ec96c5d347d87806d8/em100.h
[modify] https://crrev.com/3ddfd1779ecab8d1533a63ec96c5d347d87806d8/fpga.c

Sign in to add a comment