New issue
Advanced search Search tips

Issue 918560 link

Starred by 4 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug



Sign in to add a comment

It's possible to end up with an omnibox that looks focused but isn't; this is per-tab and switching to an infected tab and then to a new tab infects the new tab

Project Member Reported by thakis@chromium.org, Jan 2

Issue description

What steps will reproduce the problem?
1. ???
2. Have a tab that has an omnibox that looks focused but isn't (keyboard focus is in the web contents)
3. Switch to another tab
4. New tab also is in this bad state
5. Quickly have all N tabs in your browser window infected, always have the omnibox look focused

What is the expected result?

Omnibox only looks focused when it is.


What happens instead of that?

Infectious ghost omnibox.


I don't know what I did to end up with my first ghost omnibox, but once that's there the bug is pretty annoying.

Doing `cmd-l` (lowercase-L) followed by a click in the contents area heals a tab, but switching to an infected tab and back infects it again. I could probably go through my window and heal all tabs and then I'll be happy, but I'll wait with doing that in case anyone wants me to do any experiments.
 
Screen Shot 2019-01-02 at 12.28.06 PM.png
760 KB View Download
Cc: a...@chromium.org
In the screenshot you've posted, where actually is keyboard focus? I don't see a focused control in the web contents.

I'm wondering if this is related to the strange way focus gets shuffled around when changing tabs (i.e. issue 804184) - +cc avi@
It's "the web contents" -- if I hit space the page scrolls, etc.
FYI, I had a similar problem on a YouTube page earlier today.  All my typing went to the youtube video.  I could click other places, but none got focus.  I clicked in the URL bar, no good.  I clicked other places on the web page, no good.  When I tried something like control-f, to open a find within page, instead YouTube got the keystroke (which it read as "f") and switched the video to full screen.

I closed the tab to fix it.  (I did not try switching tabs, sorry.)

Chrome 71 on Mac

(If this report and thakis@'s are related, this might not be an "omnibox" issue at all, more about whole-platform focus handling.)
That sounds like fairly different symptoms tbh. My focus works fine, clicks and cmd-L and so on work fine, it's just that the omnibox looks like it has focus when it doesn't.
Labels: Needs-Feedback
This is probably Omnibox specific, since we have custom focus logic and a separate flag tracking focus in OmniboxEditModel.

If we can come up with repro-steps to produce this "infectious focus" bug, we can probably fix it quickly.

https://cs.chromium.org/chromium/src/chrome/browser/ui/views/location_bar/location_bar_view.cc?q=location_bar_view&sq=package:chromium&g=0&l=844-851

I had to restart my laptop for some reason, which healed all the tabs, but I ended up with this state again somehow within < 30 min of using the laptop. Still don't know how though.

Sign in to add a comment