New issue
Advanced search Search tips

Issue 918557 link

Starred by 2 users
Status: Fixed
Owner:
jlebel@chromium.org
Closed: Jan 3
Cc:
ios-bugs@chromium.org
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 3
Type: Bug

Blocking:
issue 827072



Sign in to add a comment

[Unity] Assert when sign-in using

Project Member Reported by jlebel@chromium.org, Jan 2 
What steps will reproduce the problem?
(1) Turn on Unity
(2) Sign-in

  DCHECK_EQ(IDENTITY_PICKER_STATE, _currentState); fails in -[ChromeSigninViewController unifiedConsentCoordinatorDidReachBottom:]
https://cs.chromium.org/chromium/src/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm?l=1172

With stacktrace:
  * frame #0: 0x0000000110e256e4 Chromium`base::debug::BreakDebugger() at debugger_posix.cc:274
    frame #1: 0x0000000110c1e3ec Chromium`logging::LogMessage::~LogMessage(this=0x00007ffee14e5888) at logging.cc:876
    frame #2: 0x0000000110c1cca5 Chromium`logging::LogMessage::~LogMessage(this=0x00007ffee14e5888) at logging.cc:586
    frame #3: 0x000000010ffb244c Chromium`::-[ChromeSigninViewController unifiedConsentCoordinatorDidReachBottom:](self=0x00007ffe238e7a00, _cmd="unifiedConsentCoordinatorDidReachBottom:", coordinator=0x000060000121d9e0) at chrome_signin_view_controller.mm:1172
    frame #4: 0x000000010ffca58c Chromium`::-[UnifiedConsentCoordinator unifiedConsentViewControllerDidReachBottom:](self=0x000060000121d9e0, _cmd="unifiedConsentViewControllerDidReachBottom:", controller=0x00007ffe224a8890) at unified_consent_coordinator.mm:133
    frame #5: 0x000000010ffd4baf Chromium`::-[UnifiedConsentViewController sendDidReachBottomIfReached](self=0x00007ffe224a8890, _cmd="sendDidReachBottomIfReached") at unified_consent_view_controller.mm:462
    frame #6: 0x000000010ffd4dc0 Chromium`::-[UnifiedConsentViewController scrollViewDidScroll:](self=0x00007ffe224a8890, _cmd="scrollViewDidScroll:", scrollView=0x00007ffe23022800) at unified_consent_view_controller.mm:470
    frame #7: 0x000000012a986966 UIKitCore`-[UIScrollView(UIScrollViewInternal) _notifyDidScroll] + 66
    frame #8: 0x000000012a96d02c UIKitCore`-[UIScrollView setContentOffset:] + 1007
    frame #9: 0x000000012a98f2fb UIKitCore`-[UIScrollView(UIScrollViewInternal) _adjustContentOffsetIfNecessary] + 53
    frame #10: 0x000000012a9889a2 UIKitCore`-[UIScrollView(UIScrollViewInternal) _stopScrollingNotify:pin:tramplingDragFlags:] + 453
    frame #11: 0x000000012a96e99c UIKitCore`-[UIScrollView _didMoveFromWindow:toWindow:] + 120
    frame #12: 0x000000012ac6c9ab UIKitCore`-[UIView(Internal) _didMoveFromWindow:toWindow:] + 706
    frame #13: 0x000000012ac6c9ab UIKitCore`-[UIView(Internal) _didMoveFromWindow:toWindow:] + 706
    frame #14: 0x000000012ac5f091 UIKitCore`__45-[UIView(Hierarchy) _postMovedFromSuperview:]_block_invoke + 151
    frame #15: 0x0000000123c8e55a Foundation`-[NSISEngine withBehaviors:performModifications:] + 110
    frame #16: 0x000000012ac5ef8b UIKitCore`-[UIView(Hierarchy) _postMovedFromSuperview:] + 831
    frame #17: 0x000000012ac5ceec UIKitCore`__UIViewWasRemovedFromSuperview + 172
    frame #18: 0x000000012ac5c9c7 UIKitCore`-[UIView(Hierarchy) removeFromSuperview] + 493
    frame #19: 0x000000012a8c39ec UIKitCore`__71-[UIPresentationController _initViewHierarchyForPresentationSuperview:]_block_invoke.678 + 405
    frame #20: 0x000000012a8bce80 UIKitCore`-[UIPresentationController transitionDidFinish:] + 102
    frame #21: 0x000000012ae42a35 UIKitCore`-[_UICurrentContextPresentationController transitionDidFinish:] + 41
    frame #22: 0x000000012a8c15f0 UIKitCore`__56-[UIPresentationController runTransitionForCurrentState]_block_invoke.440 + 183
    frame #23: 0x000000012acb7ed9 UIKitCore`-[_UIViewControllerTransitionContext completeTransition:] + 102
    frame #24: 0x000000012ac27e8a UIKitCore`-[UITransitionView notifyDidCompleteTransition:] + 251
    frame #25: 0x000000012ac27b01 UIKitCore`-[UITransitionView _didCompleteTransition:] + 1383
    frame #26: 0x000000012ac2a0f4 UIKitCore`-[UITransitionView _transitionDidStop:finished:] + 104
    frame #27: 0x000000012ac3bff5 UIKitCore`-[UIViewAnimationState sendDelegateAnimationDidStop:finished:] + 343
    frame #28: 0x000000012ac3c635 UIKitCore`-[UIViewAnimationState animationDidStop:finished:] + 293
    frame #29: 0x000000012ac3c6e9 UIKitCore`-[UIViewAnimationState animationDidStop:finished:] + 473
    frame #30: 0x0000000126131ed1 QuartzCore`CA::Layer::run_animation_callbacks(void*) + 323
    frame #31: 0x000000012c92163e libdispatch.dylib`_dispatch_client_callout + 8
    frame #32: 0x000000012c92e9d6 libdispatch.dylib`_dispatch_main_queue_callback_4CF + 1541
    frame #33: 0x0000000122b857f9 CoreFoundation`__CFRUNLOOP_IS_SERVICING_THE_MAIN_DISPATCH_QUEUE__ + 9
    frame #34: 0x0000000122b7fe86 CoreFoundation`__CFRunLoopRun + 2342
    frame #35: 0x0000000122b7f221 CoreFoundation`CFRunLoopRunSpecific + 625
    frame #36: 0x000000012f4de1dd GraphicsServices`GSEventRunModal + 62
    frame #37: 0x000000012a55d115 UIKitCore`UIApplicationMain + 140
    frame #38: 0x000000010e718d73 Chromium`(anonymous namespace)::RunUIApplicationMain(argc=1, argv=0x00007ffee14e8140) at chrome_exe_main.mm:54
    frame #39: 0x000000010e718841 Chromium`main(argc=1, argv=0x00007ffee14e8140) at chrome_exe_main.mm:78
    frame #40: 0x000000012a08b551 libdyld.dylib`start + 1

Comment 1 by jlebel@chromium.org, Jan 2

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 3 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fe60fb56e017b046cbab1cff5834d70a312d3c93

commit fe60fb56e017b046cbab1cff5834d70a312d3c93
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Thu Jan 03 11:04:45 2019

[iOS] UnifiedConsentCoordinator needs to be released after being dismissed

|_unifiedConsentCoordinator| should be removed once the sign-in is done
and the user consent is recorded.
This is to avoid to receive notifications related to the UIScrollView
in UnifiedConsentViewController, like:
-[ChromeSigninViewController unifiedConsentCoordinatorDidReachBottom:]

Bug:  918557 
Change-Id: I9d57dbf4d9f37f636fa44105f268d7089e192abf
Reviewed-on: https://chromium-review.googlesource.com/c/1393372
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619615}
[modify] https://crrev.com/fe60fb56e017b046cbab1cff5834d70a312d3c93/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm

Comment 3 by jlebel@chromium.org, Jan 3

Status: Fixed (was: Started)
►

Sign in to add a comment