New issue
Advanced search Search tips

Issue 918556 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

0% regression in sizes at 618755:618756

Project Member Reported by chiniforooshan@chromium.org, Jan 2

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=918556

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=fab1683675872c97e0bea2b7e86f800f464881f1204d81df427e34c628a33e70


Bot(s) for this bug's original alert(s):

Google Chrome Win

Comment 2 by chiniforooshan@chromium.org, Yesterday (38 hours ago)

Components: Blink>JavaScript

Comment 3 by hablich@chromium.org, Today (21 hours ago)

Cc: jarin@chromium.org
Owner: verwa...@chromium.org
Status: Assigned (was: Untriaged)
I doubt given the range and the lag to the commit we can do anything. feel free to close.

Comment 4 by verwa...@chromium.org, Today (14 hours ago)

Cc: clemensh@chromium.org
+clemensh

I have a vague suspicion that it might be due to disabling noexcept on msvc in https://chromium-review.googlesource.com/c/v8/v8/+/1386869.

Comment 5 by verwa...@chromium.org, Today (14 hours ago)

There is no similar regression in d8 on my linux workstation.

Comment 6 by clemensh@chromium.org, Today (13 hours ago)

We should try to bisect to a single CL.
If it's really the noexcept annotation, we can do something about it. We would basically have to wrap each standard container and mark the constructors and assignment operators noexcept. That's doable with a single template. It would be a bit ugly because we have to identify all locations where it's actually needed. Some fields would be declared as:

base::NoExcept<std::vector<Foo>>

On non-msvc, that would be a nop-typedef:

namespace base {
template<typename T>
using NoExcept = T;
}

But as I said, before doing this, we should bisect the size increase.

Sign in to add a comment