Note: A label "SingleProcessMash enabled" will appear on the desktop
wallpaper to let developers and QA know the feature is enabled.
The label will be removed in a separate CL before this feature
goes to dev channel. Otherwise there are no visible changes.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/badd8a0fab485b41aee70b4ed463868b7e218359

commit badd8a0fab485b41aee70b4ed463868b7e218359
Author: James Cook <jamescook@chromium.org>
Date: Wed Jan 02 22:02:06 2019

chromeos: Enable SingleProcessMash (in-proc window service) by default

Turns on the window service (code in //services/ws) and uses it to back
aura and views (code in //ui/aura/mus and //ui/views/mus). Runs the
window service in-process.

A label "SingleProcessMash enabled" will appear on the desktop
wallpaper to let developers and QA know the feature is enabled.
The label will be removed in a separate CL before this feature
goes to dev channel. Otherwise there are no visible changes.

Flips the former "single_process_mash_*" bot configs to
"non_single_process_mash_*" and runs them with the feature disabled.
This should keep the old code paths working until we're sure this
feature will stick.

TBR=sky@chromium.org

BUG=918537
TEST=single_process_mash_* bots

Change-Id: I58a30fd81ea12645b1aabc049c7e697ef1d9e72a
Reviewed-on: https://chromium-review.googlesource.com/c/1393467
Reviewed-by: Jun Mukai <mukai@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619508}
[modify] https://crrev.com/badd8a0fab485b41aee70b4ed463868b7e218359/ash/main.cc
[modify] https://crrev.com/badd8a0fab485b41aee70b4ed463868b7e218359/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/badd8a0fab485b41aee70b4ed463868b7e218359/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/badd8a0fab485b41aee70b4ed463868b7e218359/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/badd8a0fab485b41aee70b4ed463868b7e218359/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/badd8a0fab485b41aee70b4ed463868b7e218359/ui/base/ui_base_features.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/908a62bf055bca31313d18dcc31617241df80b69

commit 908a62bf055bca31313d18dcc31617241df80b69
Author: James Cook <jamescook@chromium.org>
Date: Fri Jan 04 23:26:30 2019

Revert "chromeos: Enable SingleProcessMash (in-proc window service) by default"

This reverts commit badd8a0fab485b41aee70b4ed463868b7e218359.

Reason for revert: Breaks the Wi-Fi network password entry field
 http://crbug.com/919183 

Original change's description:
> chromeos: Enable SingleProcessMash (in-proc window service) by default
> 
> Turns on the window service (code in //services/ws) and uses it to back
> aura and views (code in //ui/aura/mus and //ui/views/mus). Runs the
> window service in-process.
> 
> A label "SingleProcessMash enabled" will appear on the desktop
> wallpaper to let developers and QA know the feature is enabled.
> The label will be removed in a separate CL before this feature
> goes to dev channel. Otherwise there are no visible changes.
> 
> Flips the former "single_process_mash_*" bot configs to
> "non_single_process_mash_*" and runs them with the feature disabled.
> This should keep the old code paths working until we're sure this
> feature will stick.
> 
> TBR=sky@chromium.org
> 
> BUG=918537
> TEST=single_process_mash_* bots
> 
> Change-Id: I58a30fd81ea12645b1aabc049c7e697ef1d9e72a
> Reviewed-on: https://chromium-review.googlesource.com/c/1393467
> Reviewed-by: Jun Mukai <mukai@chromium.org>
> Reviewed-by: James Cook <jamescook@chromium.org>
> Commit-Queue: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#619508}

TBR=jamescook@chromium.org,mukai@chromium.org,sky@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 918537,  919183 
Change-Id: Ic3b5f0dd5b941d6383fd7290a0a55b60eedce30d
Reviewed-on: https://chromium-review.googlesource.com/c/1396702
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620103}
[modify] https://crrev.com/908a62bf055bca31313d18dcc31617241df80b69/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/908a62bf055bca31313d18dcc31617241df80b69/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/908a62bf055bca31313d18dcc31617241df80b69/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/908a62bf055bca31313d18dcc31617241df80b69/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/908a62bf055bca31313d18dcc31617241df80b69/ui/base/ui_base_features.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1833187d51fa0caaeafc3088f0f37065fc9fece8

commit 1833187d51fa0caaeafc3088f0f37065fc9fece8
Author: James Cook <jamescook@chromium.org>
Date: Mon Jan 07 23:58:31 2019

chromeos: Add "SingleProcessMash enabled" text to lock and login screen

So it will be easier to see the mode if there are problems with those
screens.

This also makes the version string visible on linux-chromeos builds
(with the platform string "linux-chromeos") and removes a trailing
space that was added in 2011 as a WebUI login screen workaround.

Bug: 918537
Test: Run with --login-manager --enable-features=SingleProcessMash
Change-Id: I77bc04490684ad412d9cae254cca325d250327ac
Reviewed-on: https://chromium-review.googlesource.com/c/1399571
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620539}
[modify] https://crrev.com/1833187d51fa0caaeafc3088f0f37065fc9fece8/ash/login/ui/lock_contents_view.cc
[modify] https://crrev.com/1833187d51fa0caaeafc3088f0f37065fc9fece8/chrome/browser/chromeos/login/version_info_updater.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1aa56c256936f433f6e9393e844b33fda6bd7bec

commit 1aa56c256936f433f6e9393e844b33fda6bd7bec
Author: James Cook <jamescook@chromium.org>
Date: Wed Jan 09 15:53:46 2019

Reland "chromeos: Enable SingleProcessMash (in-proc window service) by default"

This reverts commit 908a62bf055bca31313d18dcc31617241df80b69.

Reason for revert: Text input and omnibox issues are fixed.

Original change's description:
> Revert "chromeos: Enable SingleProcessMash (in-proc window service) by default"
>
> This reverts commit badd8a0fab485b41aee70b4ed463868b7e218359.
>
> Reason for revert: Breaks the Wi-Fi network password entry field
>  http://crbug.com/919183 
>
> Original change's description:
> > chromeos: Enable SingleProcessMash (in-proc window service) by default
> >
> > Turns on the window service (code in //services/ws) and uses it to back
> > aura and views (code in //ui/aura/mus and //ui/views/mus). Runs the
> > window service in-process.
> >
> > A label "SingleProcessMash enabled" will appear on the desktop
> > wallpaper to let developers and QA know the feature is enabled.
> > The label will be removed in a separate CL before this feature
> > goes to dev channel. Otherwise there are no visible changes.
> >
> > Flips the former "single_process_mash_*" bot configs to
> > "non_single_process_mash_*" and runs them with the feature disabled.
> > This should keep the old code paths working until we're sure this
> > feature will stick.
> >
> > TBR=sky@chromium.org
> >
> > BUG=918537
> > TEST=single_process_mash_* bots
> >
> > Change-Id: I58a30fd81ea12645b1aabc049c7e697ef1d9e72a
> > Reviewed-on: https://chromium-review.googlesource.com/c/1393467
> > Reviewed-by: Jun Mukai <mukai@chromium.org>
> > Reviewed-by: James Cook <jamescook@chromium.org>
> > Commit-Queue: James Cook <jamescook@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#619508}
>
> TBR=jamescook@chromium.org,mukai@chromium.org,sky@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 918537,  919183 
> Change-Id: Ic3b5f0dd5b941d6383fd7290a0a55b60eedce30d
> Reviewed-on: https://chromium-review.googlesource.com/c/1396702
> Reviewed-by: James Cook <jamescook@chromium.org>
> Reviewed-by: Jun Mukai <mukai@chromium.org>
> Commit-Queue: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#620103}

TBR=jamescook@chromium.org,mukai@chromium.org,sky@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 918537,  919183 
Change-Id: Ie8ec5125558124d756e76d8fdef20e9b3c982e53
Reviewed-on: https://chromium-review.googlesource.com/c/1399296
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621156}
[modify] https://crrev.com/1aa56c256936f433f6e9393e844b33fda6bd7bec/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/1aa56c256936f433f6e9393e844b33fda6bd7bec/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/1aa56c256936f433f6e9393e844b33fda6bd7bec/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/1aa56c256936f433f6e9393e844b33fda6bd7bec/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/1aa56c256936f433f6e9393e844b33fda6bd7bec/ui/base/ui_base_features.cc

Hello! Recently my tast tests for the virtual keyboard have started to fail: https://stainless.corp.google.com/search?exclude_retried=false&first_date=2019-01-08&master_builder_name=&builder_name_number=&shard=&exclude_acts=false&builder_name=&master_builder_name_number=&owner=&retry=&exclude_cts=false&exclude_non_production=false&hostname=&board=&branch=%5Emaster%24&test=tast.ui.VirtualKeyboardOmnibox&suite=&build=&status=FAIL&status=ERROR&status=ABORT&reason=&waterfall=&exclude_not_run=false&last_date=2019-01-10&exclude_non_release=false&exclude_au=false&model=&view=list&queued_date=%5E20190110%24

After some debugging, it seems like the chrome automation API cannot find the virtual keyboard or any of its buttons anymore? I can repro locally and I noticed that the device has SingleProcessMash enabled, so I was wondering if it's related to that? I ran the test with --disable-features=SingleProcessMash and it passes. Sorry!

CC'ing stevenjb@ for virtual keyboard expertise, is there a separate bug filed for this failure?

Do you have a link to the test source?

I'm not familiar with the automation API. Do you know if it assumes it can reach into ash's aura window hierarchy to grab the VK window? That might break with SingleProcessMash.

Is this blocking the commit queue on the Chrome OS side?

Test is using this:
cs/chromeos_public/src/platform/tast-tests/src/chromiumos/tast/local/bundles/cros/ui/vkb/vkb.go?sq=package:%5Echromeos_public$&g=0

I think that's the a11y automation API, which might be broken or racy. Can you file a new bug, assign to me and mark it blocking this one? We can follow up there.

We have accumulated enough bugs this cycle, I am disabling it again: https://chromium-review.googlesource.com/c/chromium/src/+/1407777

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3ddd534adc33cada51560d862d209f8a3abb1451

commit 3ddd534adc33cada51560d862d209f8a3abb1451
Author: James Cook <jamescook@chromium.org>
Date: Sat Jan 12 00:12:06 2019

Revert "chromeos: Enable SingleProcessMash (in-proc window service) by default""

This reverts commit 1aa56c256936f433f6e9393e844b33fda6bd7bec.

Reason for revert: Various window and input related issues, see
blockers of crbug.com/918537

Original change's description:
> Reland "chromeos: Enable SingleProcessMash (in-proc window service) by default"
> 
> This reverts commit 908a62bf055bca31313d18dcc31617241df80b69.
> 
> Reason for revert: Text input and omnibox issues are fixed.
> 
> Original change's description:
> > Revert "chromeos: Enable SingleProcessMash (in-proc window service) by default"
> >
> > This reverts commit badd8a0fab485b41aee70b4ed463868b7e218359.
> >
> > Reason for revert: Breaks the Wi-Fi network password entry field
> >  http://crbug.com/919183 
> >
> > Original change's description:
> > > chromeos: Enable SingleProcessMash (in-proc window service) by default
> > >
> > > Turns on the window service (code in //services/ws) and uses it to back
> > > aura and views (code in //ui/aura/mus and //ui/views/mus). Runs the
> > > window service in-process.
> > >
> > > A label "SingleProcessMash enabled" will appear on the desktop
> > > wallpaper to let developers and QA know the feature is enabled.
> > > The label will be removed in a separate CL before this feature
> > > goes to dev channel. Otherwise there are no visible changes.
> > >
> > > Flips the former "single_process_mash_*" bot configs to
> > > "non_single_process_mash_*" and runs them with the feature disabled.
> > > This should keep the old code paths working until we're sure this
> > > feature will stick.
> > >
> > > TBR=sky@chromium.org
> > >
> > > BUG=918537
> > > TEST=single_process_mash_* bots
> > >
> > > Change-Id: I58a30fd81ea12645b1aabc049c7e697ef1d9e72a
> > > Reviewed-on: https://chromium-review.googlesource.com/c/1393467
> > > Reviewed-by: Jun Mukai <mukai@chromium.org>
> > > Reviewed-by: James Cook <jamescook@chromium.org>
> > > Commit-Queue: James Cook <jamescook@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#619508}
> >
> > TBR=jamescook@chromium.org,mukai@chromium.org,sky@chromium.org
> >
> > # Not skipping CQ checks because original CL landed > 1 day ago.
> >
> > Bug: 918537,  919183 
> > Change-Id: Ic3b5f0dd5b941d6383fd7290a0a55b60eedce30d
> > Reviewed-on: https://chromium-review.googlesource.com/c/1396702
> > Reviewed-by: James Cook <jamescook@chromium.org>
> > Reviewed-by: Jun Mukai <mukai@chromium.org>
> > Commit-Queue: James Cook <jamescook@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#620103}
> 
> TBR=jamescook@chromium.org,mukai@chromium.org,sky@chromium.org
> 
> # Not skipping CQ checks because original CL landed > 1 day ago.
> 
> Bug: 918537,  919183 
> Change-Id: Ie8ec5125558124d756e76d8fdef20e9b3c982e53
> Reviewed-on: https://chromium-review.googlesource.com/c/1399296
> Reviewed-by: James Cook <jamescook@chromium.org>
> Commit-Queue: James Cook <jamescook@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#621156}

TBR=jamescook@chromium.org,mukai@chromium.org,sky@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 918537,  919183 
Change-Id: I3ba65c42be2d1b9747dac544cd73cd2c17f4f000
Reviewed-on: https://chromium-review.googlesource.com/c/1407777
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622233}
[modify] https://crrev.com/3ddd534adc33cada51560d862d209f8a3abb1451/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/3ddd534adc33cada51560d862d209f8a3abb1451/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/3ddd534adc33cada51560d862d209f8a3abb1451/testing/buildbot/test_suite_exceptions.pyl
[modify] https://crrev.com/3ddd534adc33cada51560d862d209f8a3abb1451/testing/buildbot/test_suites.pyl
[modify] https://crrev.com/3ddd534adc33cada51560d862d209f8a3abb1451/ui/base/ui_base_features.cc