Missing lgtm when author is only OWNER |
|||||||
Issue descriptionWhen trying to land https://crrev.com/c/1377435, I repeatedly received this presubmit error: ** Presubmit ERRORS ** Missing LGTM from an OWNER for these files: chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java The frustrating part: I am OWNER for that file. Besides owners of parent directories, I am the only one. git cl land did work and it seems to work in similar cases (e.g. https://crrev.com/c/1202562).
,
Jan 10
Hit this, too: https://crrev.com/c/1390002. John, can you please help triaging this?
,
Jan 10
+ehmaldonado and +DevX troopers for triage
,
Jan 10
,
Jan 11
A better workaround for this bug: TBR the CL. This way, it won't bypass the CQ as `git cl land` does.
,
Jan 17
(5 days ago)
Hit this again with https://crrev.com/c/1417592: https://ci.chromium.org/p/chromium/builders/luci.chromium.try/chromium_presubmit/333361. Bumping up the priority.
,
Jan 17
(5 days ago)
Sorry, I don't think this affects enough users to be a P1. Also, on the last CL you linked, you don't appear to be an OWNER of chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java Will try to get to it this week.
,
Jan 18
(4 days ago)
On https://crrev.com/c/1417592, there is an LGTM from treib@ who's owner of chrome/android/java/src/org/chromium/chrome/browser/sync/ui/SyncCustomizationFragment.java. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by estaab@chromium.org
, Jan 2