New issue
Advanced search Search tips

Issue 918516 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Handle missing anchor positions for BubbleBorder bounds calculation

Project Member Reported by tmonius...@opera.com, Jan 2

Issue description

Not all anchor positions are handled in views::BubbleBorder::GetBounds.

 
I'm attaching screenshots of views_examples without and with https://chromium-review.googlesource.com/c/chromium/src/+/1386432 patch. Only cases not previously handled have changed.
top_left.png
14.2 KB View Download
top_center.png
18.8 KB View Download
top_right.png
15.4 KB View Download
right_top.png
31.5 KB View Download
right_center.png
24.7 KB View Download
right_bottom.png
32.6 KB View Download
bottom_right.png
17.8 KB View Download
bottom_center.png
13.1 KB View Download
bottom_left.png
13.9 KB View Download
left_bottom.png
17.4 KB View Download
left_center.png
15.0 KB View Download
left_top.png
15.7 KB View Download
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5499c0794054577e184a73245e0f435e219e5cdb

commit 5499c0794054577e184a73245e0f435e219e5cdb
Author: Tomasz Moniuszko <tmoniuszko@opera.com>
Date: Thu Jan 03 08:24:32 2019

Handle missing anchor positions for BubbleBorder bounds calculation

Bug:  918516 
Change-Id: Id97aac57ef7e4bc64e312712068d8500f1d2f4e2
Reviewed-on: https://chromium-review.googlesource.com/c/1386432
Commit-Queue: Tomasz Moniuszko <tmoniuszko@opera.com>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619602}
[modify] https://crrev.com/5499c0794054577e184a73245e0f435e219e5cdb/ui/views/bubble/bubble_border.cc
[modify] https://crrev.com/5499c0794054577e184a73245e0f435e219e5cdb/ui/views/bubble/bubble_border_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment