New issue
Advanced search Search tips

Issue 918488 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

List: the behavior is wrong when insert text as firstchild of an list item with height

Project Member Reported by cathiec...@igalia.com, Jan 2

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36

Steps to reproduce the problem:
1. Open li-with-height.html
2. "xx" should be in the second line
3. 

What is the expected behavior?

What went wrong?
xx is no in the second line.

Did this work before? N/A 

Chrome version: 71.0.3578.98  Channel: stable
OS Version: 71.0.3578.98
Flash Version:
 
li-with-height.html
620 bytes View Download
Cc: cathiec...@igalia.com r...@igalia.com
Components: Blink>Layout
Status: Started (was: Unconfirmed)
cathiechen@ is working on it (she still needs the edit bug permissions to get assigned to the bug).
Owner: cathiec...@igalia.com
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b164f84322a9f70eb7b86eabc0145aa688118c12

commit b164f84322a9f70eb7b86eabc0145aa688118c12
Author: cathiechen <cathiechen@igalia.com>
Date: Thu Jan 03 16:44:10 2019

To restore the height of marker container it should be auto

If the zero-height marker container is triggered in the previous layout
pass, and in this layout pass, marker become inside or marker container
has other child, we need recover from zero-height, the height of marker
container should be restored to auto not the height of li.
This test passes in Firefox, WebKit as well as LayoutNG.

Bug:  918488 
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I3c65a2d27f1b8dfef13c41bfe804cd1f9aab89c5
Reviewed-on: https://chromium-review.googlesource.com/c/1393129
Commit-Queue: cathie chen <cathiechen@igalia.com>
Reviewed-by: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#619658}
[modify] https://crrev.com/b164f84322a9f70eb7b86eabc0145aa688118c12/third_party/blink/renderer/core/layout/layout_list_item.cc
[add] https://crrev.com/b164f84322a9f70eb7b86eabc0145aa688118c12/third_party/blink/web_tests/external/wpt/css/css-lists/li-with-height-001-ref.html
[add] https://crrev.com/b164f84322a9f70eb7b86eabc0145aa688118c12/third_party/blink/web_tests/external/wpt/css/css-lists/li-with-height-001.html

Status: Fixed (was: Started)

Sign in to add a comment