New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 918481 link

Starred by 2 users
Status: Fixed
Owner:
kristip...@chromium.org
Closed: Jan 11
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: [NTP] Thumbnail Monogram is not center aligned after creating a shortcut.

Project Member Reported by sany...@virtusa.com, Jan 2 
Chrome Version: 73.0.3659.0 (Official Build) Revision	a6fc3fde6b59c620c152911a4a3e7c683bed5144-refs/branch-heads/3659@{#1} (64-bit)
OS: Mac(10.13.1, 10.13.6, 10.14.3)

Pre-condition: Enabled 'Enable using the Google local NTP' and 'New Tab Page Custom Links' flag from chrome://flags

What steps will reproduce the problem?
1. Launch chrome, open NTP and zoom out to 67%.
2. Click on Add shortcut to open the overlay and create a shortcut.
3. Observe the Thumbnail Monogram.

Actual: Thumbnail Monogram is not center aligned after creating a shortcut on zooming out to 67% and beyond.
Expected: Thumbnail Monogram should be center aligned after creating a shortcut on zooming out to 67% and beyond.

This is a regression issue, broken in 'M-73', and below is the bisect info:

Good Build:73.0.3629.0 (Revision: 612973)
Bad Build: 73.0.3630.0 (Revision: 613368)

You are probably looking for a change made after 613172 (known good), but no later than 613237 (first known bad).

CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/1d497322e9fd8d9ab1da00767e30c618186151c6..399ea6ea824f2f355315c2a1ad5d50676b52ddd0?pretty=fuller&n=10000

Suspecting: r613194 ?

@kristipark: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: 
1.Unable to provide 'per-revision' bisect as it shows "Error running the gsutil command: AccessDeniedException: 403" error message,Tried on other machines but still getting the same error again.
2.Issue is not reproducible on Win(7,8,8.1,10) and Linux(14.04 LTS)

Thank you.
Actual_Behaviour.mov
2.5 MB View Download
Expected_Behaviour.mov
2.2 MB View Download

Comment 1 by kristip...@chromium.org, Jan 7

Labels: -Pri-1 Needs-Feedback Pri-3
Status: Started (was: Assigned)
The screencast for actual behavior is a bit difficult to see, but it looks like the monogram is off-center slightly up and to the left. Suspecting that this happens when the monogram pixel size is odd.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a71135f6cdc0740fdbbff780301b40f4b8011258

commit a71135f6cdc0740fdbbff780301b40f4b8011258
Author: Kristi Park <kristipark@chromium.org>
Date: Fri Jan 11 02:12:02 2019

[NTP] Use only even pixel sizes for the custom link icons

Do not use odd pixel sizes for NTP icons. The combination of an odd
fallback monogram width and an even total icon width (and vice versa)
causes an off by 1 effect when centering. Hence the fallback monogram
will be slightly up and to the left instead of centered.

Before: https://screenshot.googleplex.com/AMXrPCaQ9B2.png
After: https://screenshot.googleplex.com/VG0rZbnRnH3.png

Bug:  918481 
Change-Id: I6537f8f585fcc136eed6e93a3c5bc4e7279a51a4
Reviewed-on: https://chromium-review.googlesource.com/c/1400261
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621870}
[modify] https://crrev.com/a71135f6cdc0740fdbbff780301b40f4b8011258/chrome/browser/search/ntp_icon_source.cc

Comment 3 by kristip...@chromium.org, Jan 11

Status: Fixed (was: Started)
►

Sign in to add a comment