New issue
Advanced search Search tips

Issue 918474 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug

Blocking:
issue 827072



Sign in to add a comment

[Unity] Needs to reload Google services settings when sync service state changes

Project Member Reported by jlebel@chromium.org, Jan 2

Issue description

Google services settings needs to observe sync service state notification.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1cfa8e38cc5272f72baa2847cf36fc7c011d9982

commit 1cfa8e38cc5272f72baa2847cf36fc7c011d9982
Author: Jérôme Lebel <jlebel@chromium.org>
Date: Wed Jan 02 14:07:13 2019

[iOS] Reload Google services settings when sync state changes

Needs to reload the sync error item when the sync state changes.

Bug introduced with cleanup in: crrev.com/c/1390004

Bug: 918474
Change-Id: I868ec7358de6741c75970c4003dacf54fa11bdfd
Reviewed-on: https://chromium-review.googlesource.com/c/1392948
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619395}
[modify] https://crrev.com/1cfa8e38cc5272f72baa2847cf36fc7c011d9982/ios/chrome/browser/ui/settings/google_services_settings_coordinator.mm
[modify] https://crrev.com/1cfa8e38cc5272f72baa2847cf36fc7c011d9982/ios/chrome/browser/ui/settings/google_services_settings_mediator.h
[modify] https://crrev.com/1cfa8e38cc5272f72baa2847cf36fc7c011d9982/ios/chrome/browser/ui/settings/google_services_settings_mediator.mm

Sign in to add a comment