New issue
Advanced search Search tips

Issue 918465 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Blue focus ring appears faint for 'Filter' text box in console section of devtools.

Reported by rp...@virtusa.com, Jan 2

Issue description

Chrome Version: 73.0.3658.0 (Official Build) Revision 72280ac8d7a76270f5a73ddb8d20726e2d368fa4-refs/branch-heads/3658@{#1}(32/64-bit)
OS: Windows (7,8,8.1,10),Mac OS X(10.14.3,10.13.1,10.13.6)and Linux(14.04 LTs).

What steps will reproduce the problem?
(1) Launch chrome, open NTP and open devtools.
(2) Now go to 'Console' section and click on 'Filter' text box and observe focus ring

Actual: Blue focus ring appears faint for 'Filter' text box.
Expected: Blue focus ring should be seen properly for 'Filter' text box.

This is a regression issue, broken in 'M73', and below is the bisect info:
Good Build:73.0.3648.0 (Revision : 618636)
Bad Build: 73.0.3649.0 (Revision : 618770)

You are probably looking for a change made after 618685 (known good), but no later than 618712 (first known bad).

CHANGE-LOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/5ad4e08d15110e8212fae941d4638e2e4df7e4c1..f48817a9e97b8231abae8764d45c0a0409443a79?pretty=fuller&n=10000

Suspect: r618701 

@pfeldman: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1.Unable to provide 'per-revision' bisect as it shows "Error running the gsutil command: AccessDeniedException: 403" error message,Tried on other machines but still getting the same error again,Hence providing Chromium bisect.
2. Issue is also seen on M-73 Dev build #73.0.3642.0

Kindly refer the attached screen-cast for reference.

Thank You!
 
Actual_video.mov
2.6 MB View Download
Expected_video.mov
2.9 MB View Download
Owner: alph@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b83b749c684f65d90950cbe597fb819930a3ea3a

commit b83b749c684f65d90950cbe597fb819930a3ea3a
Author: Alexei Filippov <alph@chromium.org>
Date: Mon Jan 07 20:29:57 2019

DevTools: Bring back blue selection color.

BUG= 918465 

Change-Id: I1431ff30e2dbddbc16ce7031ee5440e716ace0bb
Reviewed-on: https://chromium-review.googlesource.com/c/1398311
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620450}
[modify] https://crrev.com/b83b749c684f65d90950cbe597fb819930a3ea3a/third_party/blink/renderer/devtools/front_end/ui/inspectorStyle.css

Status: Fixed (was: Assigned)
Labels: TE-Verified-M73 TE-Verified-73.0.3665.0
---------
Update :
---------
Verified above issue in latest Canary build #73.0.3665.0 on Mac(10.13.1, 10.13.6, 10.14.3), Windows(7,8,8.1,10) & Linux(14.04 LTS) OS and the issue is fixed. Hence adding TE-Verified labels, kindly review an attached screen-cast for reference.

Thank you..!
Canary_behaviour.mov
4.8 MB View Download
Cc: pfeldman@chromium.org
 Issue 919790  has been merged into this issue.

Sign in to add a comment