New issue
Advanced search Search tips

Issue 918455 link

Starred by 2 users
Status: Fixed
Owner:
adanilo@chromium.org
Closed: Jan 18
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

'More actions' being shown when no sub-menu items available

Project Member Reported by adan...@google.com, Jan 2 
Chrome Version: 73.0.3636.0 (Developer build)
OS: ChromeOS

What steps will reproduce the problem?
(1) select a file in 'Downloads' with a single share option
(2) click the 'share menu icon'

What is the expected result?
Menu with a single option appears, and the 'More actions' option
is hidden

What happens instead?
'More actions' shows, despite there being nothing on the sub-menu.


This is a side effect from the sub-menu implementation in https://bugs.chromium.org/p/chromium/issues/detail?id=762662
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 2 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/349908cd155f0faaeb226298f632c4691a215a10

commit 349908cd155f0faaeb226298f632c4691a215a10
Author: Alex Danilo <adanilo@chromium.org>
Date: Wed Jan 02 06:01:25 2019

Fix 'More actions' appearing with no sub menu.

The share menu was changed to allow a 'More actions'
item to appear when the menu was populated into a
main action menu plus a sub-menu when there are too
many actions for a single menu. A side effect of that
change was the 'More actions' item appearing even
when there are no entries in the sub-menu. This
corrects that by checking for non-zero sub-menu
entries.

Bug:  918455 
Tests: Ran all browser tests, closure coompile and manual check.
Change-Id: I0ff2a013cacd4beb40cef37b6855de8129e46985
Reviewed-on: https://chromium-review.googlesource.com/c/1392701
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Commit-Queue: Alex Danilo <adanilo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619370}
[modify] https://crrev.com/349908cd155f0faaeb226298f632c4691a215a10/ui/file_manager/file_manager/foreground/js/task_controller.js

Comment 2 by adanilo@chromium.org, Jan 18 (5 days ago)

Status: Fixed (was: Started)
►

Sign in to add a comment