New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 918436 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Last visit 21 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Explore sites personalization

Project Member Reported by chili@chromium.org, Jan 1

Issue description

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51217e700c7157acf1966fcd33cf51cf9964c0d8

commit 51217e700c7157acf1966fcd33cf51cf9964c0d8
Author: Cathy Li <chili@chromium.org>
Date: Wed Jan 09 01:28:09 2019

[Explore Sites]: Schema change for personalization tables.

Bug: 918436
Change-Id: I9111d1c4763aee83242b6c45aaae986c73810aaa
Reviewed-on: https://chromium-review.googlesource.com/c/1394389
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620982}
[modify] https://crrev.com/51217e700c7157acf1966fcd33cf51cf9964c0d8/chrome/browser/android/explore_sites/explore_sites_schema.cc
[modify] https://crrev.com/51217e700c7157acf1966fcd33cf51cf9964c0d8/chrome/browser/android/explore_sites/explore_sites_schema.h
[modify] https://crrev.com/51217e700c7157acf1966fcd33cf51cf9964c0d8/chrome/browser/android/explore_sites/explore_sites_schema_unittest.cc
[modify] https://crrev.com/51217e700c7157acf1966fcd33cf51cf9964c0d8/chrome/browser/android/explore_sites/explore_sites_types.h
[add] https://crrev.com/51217e700c7157acf1966fcd33cf51cf9964c0d8/components/test/data/explore_sites/version_schemas/v1.data
[add] https://crrev.com/51217e700c7157acf1966fcd33cf51cf9964c0d8/components/test/data/explore_sites/version_schemas/v1.sql
[add] https://crrev.com/51217e700c7157acf1966fcd33cf51cf9964c0d8/components/test/data/explore_sites/version_schemas/v2.data
[add] https://crrev.com/51217e700c7157acf1966fcd33cf51cf9964c0d8/components/test/data/explore_sites/version_schemas/v2.sql

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0bb9fa132bffe6be961480d74168ffe6893b35af

commit 0bb9fa132bffe6be961480d74168ffe6893b35af
Author: Cathy Li <chili@chromium.org>
Date: Mon Jan 14 20:07:17 2019

[Explore sites]: Modify backend tasks to read from new activity table

Bug: 918436
Change-Id: I3994b6eb937e4e676467380205bfdca522e947c3
Reviewed-on: https://chromium-review.googlesource.com/c/1400349
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622564}
[modify] https://crrev.com/0bb9fa132bffe6be961480d74168ffe6893b35af/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategory.java
[modify] https://crrev.com/0bb9fa132bffe6be961480d74168ffe6893b35af/chrome/android/javatests/src/org/chromium/chrome/browser/explore_sites/ExploreSitesPageTest.java
[modify] https://crrev.com/0bb9fa132bffe6be961480d74168ffe6893b35af/chrome/android/junit/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryUnitTest.java
[modify] https://crrev.com/0bb9fa132bffe6be961480d74168ffe6893b35af/chrome/browser/android/explore_sites/blacklist_site_task.cc
[modify] https://crrev.com/0bb9fa132bffe6be961480d74168ffe6893b35af/chrome/browser/android/explore_sites/blacklist_site_task_unittest.cc
[modify] https://crrev.com/0bb9fa132bffe6be961480d74168ffe6893b35af/chrome/browser/android/explore_sites/explore_sites_bridge.cc
[modify] https://crrev.com/0bb9fa132bffe6be961480d74168ffe6893b35af/chrome/browser/android/explore_sites/explore_sites_types.cc
[modify] https://crrev.com/0bb9fa132bffe6be961480d74168ffe6893b35af/chrome/browser/android/explore_sites/explore_sites_types.h
[modify] https://crrev.com/0bb9fa132bffe6be961480d74168ffe6893b35af/chrome/browser/android/explore_sites/get_catalog_task.cc
[modify] https://crrev.com/0bb9fa132bffe6be961480d74168ffe6893b35af/chrome/browser/android/explore_sites/get_catalog_task_unittest.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/09afdc0d9d8dbeda62de9a62f66b59b97524da7d

commit 09afdc0d9d8dbeda62de9a62f66b59b97524da7d
Author: Jian Li <jianli@chromium.org>
Date: Mon Jan 14 20:45:59 2019

[EoS]: Keep ntp click/shown counts when updating catalog

Bug: 918436
Change-Id: I2f3ced8d1823fe0be69b1b60a56b500d90fcfe42
Reviewed-on: https://chromium-review.googlesource.com/c/1407921
Reviewed-by: Cathy Li <chili@chromium.org>
Commit-Queue: Jian Li <jianli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622591}
[modify] https://crrev.com/09afdc0d9d8dbeda62de9a62f66b59b97524da7d/chrome/browser/android/explore_sites/import_catalog_task.cc
[modify] https://crrev.com/09afdc0d9d8dbeda62de9a62f66b59b97524da7d/chrome/browser/android/explore_sites/import_catalog_task_unittest.cc

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edd6707fc1d9e3032d374d6c35db6c6ef129e40a

commit edd6707fc1d9e3032d374d6c35db6c6ef129e40a
Author: Jian Li <jianli@chromium.org>
Date: Wed Jan 16 23:02:59 2019

EoS: Clear activities when chrome history is being cleared

Bug: 918436
Change-Id: I7c09d5a476ba207cd78cea3e6384f8039be0c33d
Reviewed-on: https://chromium-review.googlesource.com/c/1410279
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623426}
[modify] https://crrev.com/edd6707fc1d9e3032d374d6c35db6c6ef129e40a/chrome/browser/BUILD.gn
[add] https://crrev.com/edd6707fc1d9e3032d374d6c35db6c6ef129e40a/chrome/browser/android/explore_sites/clear_activities_task.cc
[add] https://crrev.com/edd6707fc1d9e3032d374d6c35db6c6ef129e40a/chrome/browser/android/explore_sites/clear_activities_task.h
[add] https://crrev.com/edd6707fc1d9e3032d374d6c35db6c6ef129e40a/chrome/browser/android/explore_sites/clear_activities_task_unittest.cc
[modify] https://crrev.com/edd6707fc1d9e3032d374d6c35db6c6ef129e40a/chrome/browser/android/explore_sites/explore_sites_service.h
[modify] https://crrev.com/edd6707fc1d9e3032d374d6c35db6c6ef129e40a/chrome/browser/android/explore_sites/explore_sites_service_impl.cc
[modify] https://crrev.com/edd6707fc1d9e3032d374d6c35db6c6ef129e40a/chrome/browser/android/explore_sites/explore_sites_service_impl.h
[modify] https://crrev.com/edd6707fc1d9e3032d374d6c35db6c6ef129e40a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/edd6707fc1d9e3032d374d6c35db6c6ef129e40a/chrome/test/BUILD.gn

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/edd6707fc1d9e3032d374d6c35db6c6ef129e40a

commit edd6707fc1d9e3032d374d6c35db6c6ef129e40a
Author: Jian Li <jianli@chromium.org>
Date: Wed Jan 16 23:02:59 2019

EoS: Clear activities when chrome history is being cleared

Bug: 918436
Change-Id: I7c09d5a476ba207cd78cea3e6384f8039be0c33d
Reviewed-on: https://chromium-review.googlesource.com/c/1410279
Commit-Queue: Jian Li <jianli@chromium.org>
Reviewed-by: Cathy Li <chili@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623426}
[modify] https://crrev.com/edd6707fc1d9e3032d374d6c35db6c6ef129e40a/chrome/browser/BUILD.gn
[add] https://crrev.com/edd6707fc1d9e3032d374d6c35db6c6ef129e40a/chrome/browser/android/explore_sites/clear_activities_task.cc
[add] https://crrev.com/edd6707fc1d9e3032d374d6c35db6c6ef129e40a/chrome/browser/android/explore_sites/clear_activities_task.h
[add] https://crrev.com/edd6707fc1d9e3032d374d6c35db6c6ef129e40a/chrome/browser/android/explore_sites/clear_activities_task_unittest.cc
[modify] https://crrev.com/edd6707fc1d9e3032d374d6c35db6c6ef129e40a/chrome/browser/android/explore_sites/explore_sites_service.h
[modify] https://crrev.com/edd6707fc1d9e3032d374d6c35db6c6ef129e40a/chrome/browser/android/explore_sites/explore_sites_service_impl.cc
[modify] https://crrev.com/edd6707fc1d9e3032d374d6c35db6c6ef129e40a/chrome/browser/android/explore_sites/explore_sites_service_impl.h
[modify] https://crrev.com/edd6707fc1d9e3032d374d6c35db6c6ef129e40a/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/edd6707fc1d9e3032d374d6c35db6c6ef129e40a/chrome/test/BUILD.gn

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/72d8743550ff6a19afb05d0b1a9b7c0b867a3a5f

commit 72d8743550ff6a19afb05d0b1a9b7c0b867a3a5f
Author: Cathy Li <chili@chromium.org>
Date: Fri Jan 18 14:59:32 2019

[Explore sites]: Update activity table when there is a site click.

Bug: 918436
Change-Id: I88fb3e7fe53d4418ff5f749e31e5f2a7b7d1b783
Reviewed-on: https://chromium-review.googlesource.com/c/1415816
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624122}
[modify] https://crrev.com/72d8743550ff6a19afb05d0b1a9b7c0b867a3a5f/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java
[modify] https://crrev.com/72d8743550ff6a19afb05d0b1a9b7c0b867a3a5f/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesCategoryCardView.java
[modify] https://crrev.com/72d8743550ff6a19afb05d0b1a9b7c0b867a3a5f/chrome/browser/BUILD.gn
[modify] https://crrev.com/72d8743550ff6a19afb05d0b1a9b7c0b867a3a5f/chrome/browser/android/explore_sites/explore_sites_bridge.cc
[modify] https://crrev.com/72d8743550ff6a19afb05d0b1a9b7c0b867a3a5f/chrome/browser/android/explore_sites/explore_sites_service.h
[modify] https://crrev.com/72d8743550ff6a19afb05d0b1a9b7c0b867a3a5f/chrome/browser/android/explore_sites/explore_sites_service_impl.cc
[modify] https://crrev.com/72d8743550ff6a19afb05d0b1a9b7c0b867a3a5f/chrome/browser/android/explore_sites/explore_sites_service_impl.h
[add] https://crrev.com/72d8743550ff6a19afb05d0b1a9b7c0b867a3a5f/chrome/browser/android/explore_sites/record_site_click_task.cc
[add] https://crrev.com/72d8743550ff6a19afb05d0b1a9b7c0b867a3a5f/chrome/browser/android/explore_sites/record_site_click_task.h
[add] https://crrev.com/72d8743550ff6a19afb05d0b1a9b7c0b867a3a5f/chrome/browser/android/explore_sites/record_site_click_task_unittest.cc
[modify] https://crrev.com/72d8743550ff6a19afb05d0b1a9b7c0b867a3a5f/chrome/test/BUILD.gn

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 19 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/016987e258abed385a55c0801052a1a068ddd6e8

commit 016987e258abed385a55c0801052a1a068ddd6e8
Author: Cathy Li <chili@chromium.org>
Date: Sat Jan 19 04:35:06 2019

[Explore sites]: Change which categories are displayed based on activity and shown count.

Bug: 918436
Change-Id: I6e5ddc11ac86ca128d35b1d71b0bb461889e9d16
Reviewed-on: https://chromium-review.googlesource.com/c/1401619
Commit-Queue: Cathy Li <chili@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624444}
[modify] https://crrev.com/016987e258abed385a55c0801052a1a068ddd6e8/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesBridge.java
[modify] https://crrev.com/016987e258abed385a55c0801052a1a068ddd6e8/chrome/android/java/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSection.java
[modify] https://crrev.com/016987e258abed385a55c0801052a1a068ddd6e8/chrome/android/java_sources.gni
[add] https://crrev.com/016987e258abed385a55c0801052a1a068ddd6e8/chrome/android/junit/src/org/chromium/chrome/browser/explore_sites/ExploreSitesSectionUnitTest.java
[modify] https://crrev.com/016987e258abed385a55c0801052a1a068ddd6e8/chrome/browser/BUILD.gn
[modify] https://crrev.com/016987e258abed385a55c0801052a1a068ddd6e8/chrome/browser/android/explore_sites/explore_sites_bridge.cc
[modify] https://crrev.com/016987e258abed385a55c0801052a1a068ddd6e8/chrome/browser/android/explore_sites/explore_sites_service.h
[modify] https://crrev.com/016987e258abed385a55c0801052a1a068ddd6e8/chrome/browser/android/explore_sites/explore_sites_service_impl.cc
[modify] https://crrev.com/016987e258abed385a55c0801052a1a068ddd6e8/chrome/browser/android/explore_sites/explore_sites_service_impl.h
[add] https://crrev.com/016987e258abed385a55c0801052a1a068ddd6e8/chrome/browser/android/explore_sites/increment_shown_count_task.cc
[add] https://crrev.com/016987e258abed385a55c0801052a1a068ddd6e8/chrome/browser/android/explore_sites/increment_shown_count_task.h
[add] https://crrev.com/016987e258abed385a55c0801052a1a068ddd6e8/chrome/browser/android/explore_sites/increment_shown_count_task_unittest.cc
[modify] https://crrev.com/016987e258abed385a55c0801052a1a068ddd6e8/chrome/test/BUILD.gn

Sign in to add a comment