Issue metadata
Sign in to add a comment
|
hterm: cloned parent page in firefox
Reported by
mikolajc...@gmail.com,
Dec 31
|
||||||||||||||||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64; rv:64.0) Gecko/20100101 Firefox/64.0 Steps to reproduce the problem: 1. Go to the demo page of hterm - hterm.org in Firefox (chrome works just fine) 2. Inspect the elements What is the expected behavior? Only one iframe should be rendered, displaying the terminal contents What went wrong? There are two iframes rendered. First one is an outer iframe, which clones the hterm.org website. You can easily recognize it by the copy of a div with id="terminal" inside. then, the second iframe is rendered which contains the desired terminal content. I think the problem appears inside the decorate() function where the "src" attribute of the frame is set to "#" (there's a sentinel for Firefox). when I inspected the frames in the debug window, they have a baseURL of the parent website and a # sign so that's what I think is causing the page to be cloned because from the browser's perspective the url is not just "#" but rather hterm.org/# Did this work before? Yes Firefox releases prior to november 2018 Does this work in other browsers? N/A Chrome version: <Copy from: 'about:version'> Channel: n/a OS Version: Flash Version: I am not sure whether I submitted the bug correctly. I tried selecting an hterm component ( component:Platform>Apps>Default>Hterm ) but it was not available on the components selection. If this is possible, please redirect this bug there.
,
Jan 2
I have been able to fix the problem. I need to clean it up a bit and then I'll post the solution here.
,
Jan 8
,
Jan 8
i think this CL fixes the issue you highlighted: https://chromium-review.googlesource.com/1381751 but it's waiting for feedback to be addressed. could you check that ?
,
Jan 8
ah, it looks very similar to what I had done, although milion times better. basically, I've never heard of .push() and so what I had done was I translated hterm initialization into an asynchronous mode, which I was certain you would not like. I've also used a load event for that ;) Thanks so much! I also have problem with Ctrl-V not producing a paste event, also only on firefox. Of course I know that this is a separate issue, but where can I actually file it ? When I was submitting this issue, I wasn't able to select hterm component from the available components list. kind regards, toudi
,
Jan 8
i'm big on moving away from callbacks to Promises, but there's a lot of code that needs to be adapted. i'm not keen on async/await because those can't be Polyfilled :/. firefox paste issues should be fixed by: https://chromium-review.googlesource.com/1396037
,
Jan 8
sigh. I feel so dumb. Thank you once again, have a great evening!
,
Jan 10
we've merged that CL, so hterm-1.84 should work again
,
Today
(9 hours ago)
hmm sorry for being the messenger with bad news, but I'm affraid it's not fixed.. Unless that's a desired effect ? The two iframes look different than in v. 1.83 (they are not nested) but then again, there aren't any two iframes in chrome.. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 Deleted