New issue
Advanced search Search tips

Issue 918218 link

Starred by 2 users
Status: Started
Owner:
benjhayden@chromium.org
Cc:
simonhatch@chromium.org
seanmccullough@chromium.org
benjhayden@chromium.org
crouleau@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Compute tag maps in update_test_suite_descriptors

Project Member Reported by benjhayden@chromium.org, Dec 29 
Currently, Telemetry adds TagMap diagnostics to metrics results in order to allow users of the chromeperf dashboard to select groups of test cases (aka stories). Telemetry also adds diagnostics containing individual stories' tags.
The system would be simpler overall if the chromeperf dashboard computed tagmaps from the tags when it was collecting the test cases for the suite. This would allow removing TagMap diagnostics everywhere, at the cost of a few extra queries (1 query per test case to get its tags instead of 1 query per bot to get its tagmap).

Comment 1 by benjhayden@chromium.org, Jan 3

Owner: benjhayden@chromium.org
Status: Started (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/7aaead9d87cb03e2d88dac1dc1186962bff6233e

commit 7aaead9d87cb03e2d88dac1dc1186962bff6233e
Author: Ben Hayden <benjhayden@chromium.org>
Date: Fri Jan 11 00:28:43 2019

Use storyTags instead of tagMap in update_test_suite_descriptors.

This is simpler and will allow removing the TagMap diagnostic entirely, though
it requires 1 SparseDiagnostic query per test case instead of per bot. There are
only a few hundred test cases, and the queries are parallelized, so this
increase is negligible.
This has the added benefit of surfacing key:value tags, which do not appear in
TagMaps for some reason.

A followup CL will remove TagMap.

This chart monitors a logs-based metric for the mean wall-time to process a single
TestMetadata key. Collecting tags is aggregated into this as overhead.
https://app.google.stackdriver.com/dashboards/16092431051342960751?project=chromeperf

Bug: chromium:918218
Change-Id: I55c00058b0177461262d0d9126ab17007a04adc9
Reviewed-on: https://chromium-review.googlesource.com/c/1394567
Commit-Queue: Ben Hayden <benjhayden@chromium.org>
Reviewed-by: Sean McCullough <seanmccullough@chromium.org>

[modify] https://crrev.com/7aaead9d87cb03e2d88dac1dc1186962bff6233e/dashboard/dashboard/update_test_suite_descriptors_test.py
[modify] https://crrev.com/7aaead9d87cb03e2d88dac1dc1186962bff6233e/dashboard/dashboard/update_test_suite_descriptors.py
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/db27da7fa66e91086096b2b6083870b2ddbe6d3f

commit db27da7fa66e91086096b2b6083870b2ddbe6d3f
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Fri Jan 11 03:26:46 2019

Roll src/third_party/catapult 0cc582388fa2..0df132fe0a47 (6 commits)

https://chromium.googlesource.com/catapult.git/+log/0cc582388fa2..0df132fe0a47


git log 0cc582388fa2..0df132fe0a47 --date=short --no-merges --format='%ad %ae %s'
2019-01-11 benjhayden@chromium.org Use HistogramSet.ImportDicts in PageTestResults.
2019-01-11 benjhayden@chromium.org Use storyTags instead of tagMap in update_test_suite_descriptors.
2019-01-10 benjhayden@chromium.org Use the HTMLImports polyfill
2019-01-10 benjhayden@chromium.org Fix request-base-test with polyfilled html imports.
2019-01-10 dtu@chromium.org [pinpoint] Remove old code for OOBS and Swarming/Isolate server migrations.
2019-01-10 eroman@chromium.org Add mattm to OWNERS for netlog_viewer.


Created with:
  gclient setdep -r src/third_party/catapult@0df132fe0a47

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:918208,chromium:918218,chromium:867643
TBR=sullivan@chromium.org

Change-Id: I3ea68899d4f9fa4b5896f792ef2fc7f616cee8c2
Reviewed-on: https://chromium-review.googlesource.com/c/1406264
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#621888}
[modify] https://crrev.com/db27da7fa66e91086096b2b6083870b2ddbe6d3f/DEPS
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/b899089276dc4ecbde68ac00148eb9e24c2b16fd

commit b899089276dc4ecbde68ac00148eb9e24c2b16fd
Author: Ben Hayden <benjhayden@chromium.org>
Date: Fri Jan 11 23:18:06 2019

Remove TagMap.

Telemetry benchmarks can contain hundreds of test cases, so they tag them to
make it easier to filter them. The tags are stored in the storyTags GenericSet
diagnostic, which is used by results.html, and soon by the dashboard:
https://chromium-review.googlesource.com/c/catapult/+/1394567
Story tags are also stored in TagMap diagnostics, which map from tags to sets of
stories. TagMaps contain the same information as storyTags, just centralized in
a different data structure.
After that change to update_test_suite_descriptors, TagMaps will not be used
anywhere. This CL removes TagMaps entirely.

Bug: chromium:918218
Change-Id: Icc8e637db54a56c03f0010baf9d8b95ed50ad195
Reviewed-on: https://chromium-review.googlesource.com/c/1405392
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Commit-Queue: Ben Hayden <benjhayden@chromium.org>

[delete] https://crrev.com/8dc09eb0703647db9ca37b26f2d01a0a4dc0285c/tracing/tracing/value/diagnostics/tag_map.py
[modify] https://crrev.com/b899089276dc4ecbde68ac00148eb9e24c2b16fd/dashboard/dashboard/elements/test-picker.html
[delete] https://crrev.com/8dc09eb0703647db9ca37b26f2d01a0a4dc0285c/tracing/tracing/value/ui/tag_map_span.html
[modify] https://crrev.com/b899089276dc4ecbde68ac00148eb9e24c2b16fd/telemetry/telemetry/internal/story_runner.py
[delete] https://crrev.com/8dc09eb0703647db9ca37b26f2d01a0a4dc0285c/tracing/tracing/value/diagnostics/tag_map_test.html
[modify] https://crrev.com/b899089276dc4ecbde68ac00148eb9e24c2b16fd/tracing/tracing/value/diagnostics/reserved_names.html
[delete] https://crrev.com/8dc09eb0703647db9ca37b26f2d01a0a4dc0285c/tracing/tracing/value/diagnostics/tag_map_unittest.py
[modify] https://crrev.com/b899089276dc4ecbde68ac00148eb9e24c2b16fd/dashboard/dashboard/add_histograms.py
[modify] https://crrev.com/b899089276dc4ecbde68ac00148eb9e24c2b16fd/tracing/tracing/value/histogram.py
[delete] https://crrev.com/8dc09eb0703647db9ca37b26f2d01a0a4dc0285c/tracing/tracing/value/diagnostics/tag_map.html
[modify] https://crrev.com/b899089276dc4ecbde68ac00148eb9e24c2b16fd/tracing/tracing/value/diagnostics/add_reserved_diagnostics_unittest.py
[delete] https://crrev.com/8dc09eb0703647db9ca37b26f2d01a0a4dc0285c/tracing/tracing/value/ui/tag_map_span_test.html
[delete] https://crrev.com/8dc09eb0703647db9ca37b26f2d01a0a4dc0285c/dashboard/dashboard/elements/story_tag_filter.html
[modify] https://crrev.com/b899089276dc4ecbde68ac00148eb9e24c2b16fd/tracing/tracing/value/diagnostics/reserved_infos.py
[modify] https://crrev.com/b899089276dc4ecbde68ac00148eb9e24c2b16fd/tracing/tracing/value/diagnostics/all_diagnostics.html
[modify] https://crrev.com/b899089276dc4ecbde68ac00148eb9e24c2b16fd/tracing/tracing/value/diagnostics/diagnostic_map.html
[modify] https://crrev.com/b899089276dc4ecbde68ac00148eb9e24c2b16fd/tracing/tracing/value/ui/diagnostic_span.html
[modify] https://crrev.com/b899089276dc4ecbde68ac00148eb9e24c2b16fd/dashboard/dashboard/get_diagnostics_test.py
[modify] https://crrev.com/b899089276dc4ecbde68ac00148eb9e24c2b16fd/dashboard/dashboard/elements/test-picker-test.html
[delete] https://crrev.com/8dc09eb0703647db9ca37b26f2d01a0a4dc0285c/dashboard/dashboard/elements/story_tag_filter_test.html
[modify] https://crrev.com/b899089276dc4ecbde68ac00148eb9e24c2b16fd/tracing/tracing/value/diagnostics/all_diagnostics.py
[modify] https://crrev.com/b899089276dc4ecbde68ac00148eb9e24c2b16fd/telemetry/telemetry/internal/story_runner_unittest.py
[modify] https://crrev.com/b899089276dc4ecbde68ac00148eb9e24c2b16fd/tracing/trace_viewer.gni
[modify] https://crrev.com/b899089276dc4ecbde68ac00148eb9e24c2b16fd/tracing/tracing/value/diagnostics/add_reserved_diagnostics.py
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/50be11941d86ab4ced27d8cef646024572d7cf12

commit 50be11941d86ab4ced27d8cef646024572d7cf12
Author: Juan Antonio Navarro Pérez <perezju@chromium.org>
Date: Tue Jan 15 10:40:53 2019

Revert "Remove TagMap."

This reverts commit b899089276dc4ecbde68ac00148eb9e24c2b16fd.

Reason for revert: Blocking catapult roll.

Original change's description:
> Remove TagMap.
> 
> Telemetry benchmarks can contain hundreds of test cases, so they tag them to
> make it easier to filter them. The tags are stored in the storyTags GenericSet
> diagnostic, which is used by results.html, and soon by the dashboard:
> https://chromium-review.googlesource.com/c/catapult/+/1394567
> Story tags are also stored in TagMap diagnostics, which map from tags to sets of
> stories. TagMaps contain the same information as storyTags, just centralized in
> a different data structure.
> After that change to update_test_suite_descriptors, TagMaps will not be used
> anywhere. This CL removes TagMaps entirely.
> 
> Bug: chromium:918218
> Change-Id: Icc8e637db54a56c03f0010baf9d8b95ed50ad195
> Reviewed-on: https://chromium-review.googlesource.com/c/1405392
> Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
> Commit-Queue: Ben Hayden <benjhayden@chromium.org>

TBR=benjhayden@chromium.org,crouleau@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:918218
Change-Id: I6c9e52f81d293f303f037dcf6516d220435b6b57
Reviewed-on: https://chromium-review.googlesource.com/c/1411772
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>

[add] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/tracing/tracing/value/diagnostics/tag_map.py
[modify] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/dashboard/dashboard/elements/test-picker.html
[add] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/tracing/tracing/value/ui/tag_map_span.html
[modify] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/telemetry/telemetry/internal/story_runner.py
[add] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/tracing/tracing/value/diagnostics/tag_map_test.html
[modify] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/tracing/tracing/value/diagnostics/reserved_names.html
[add] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/tracing/tracing/value/diagnostics/tag_map_unittest.py
[modify] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/dashboard/dashboard/add_histograms.py
[modify] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/tracing/tracing/value/histogram.py
[add] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/tracing/tracing/value/diagnostics/tag_map.html
[modify] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/tracing/tracing/value/diagnostics/add_reserved_diagnostics_unittest.py
[add] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/tracing/tracing/value/ui/tag_map_span_test.html
[add] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/dashboard/dashboard/elements/story_tag_filter.html
[modify] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/tracing/tracing/value/diagnostics/reserved_infos.py
[modify] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/tracing/tracing/value/diagnostics/all_diagnostics.html
[modify] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/tracing/tracing/value/diagnostics/diagnostic_map.html
[modify] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/tracing/tracing/value/ui/diagnostic_span.html
[modify] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/dashboard/dashboard/get_diagnostics_test.py
[modify] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/dashboard/dashboard/elements/test-picker-test.html
[add] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/dashboard/dashboard/elements/story_tag_filter_test.html
[modify] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/tracing/tracing/value/diagnostics/all_diagnostics.py
[modify] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/telemetry/telemetry/internal/story_runner_unittest.py
[modify] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/tracing/trace_viewer.gni
[modify] https://crrev.com/50be11941d86ab4ced27d8cef646024572d7cf12/tracing/tracing/value/diagnostics/add_reserved_diagnostics.py
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9d39cb7402e371e19d1485f07270953c266d4cd

commit c9d39cb7402e371e19d1485f07270953c266d4cd
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Wed Jan 16 02:43:37 2019

Roll src/third_party/catapult 96320b515106..78448d90081e (17 commits)

https://chromium.googlesource.com/catapult.git/+log/96320b515106..78448d90081e


git log 96320b515106..78448d90081e --date=short --no-merges --format='%ad %ae %s'
2019-01-15 vollick@chromium.org Plumb the trace buffer size for atrace
2019-01-15 perezju@chromium.org Revert "[py_utils] Add modules_util.RequireVersion"
2019-01-15 taylori@google.com Fix handling of perfetto protobuf on mac
2019-01-15 perezju@chromium.org [dashboard] Remove dead code in start_try_job.py
2019-01-15 perezju@chromium.org Revert "Remove TagMap."
2019-01-15 perezju@chromium.org [Telemetry] Add list_of_scalar_values.mean
2019-01-15 dtu@chromium.org [pinpoint] Add Tags field to try job dialog.
2019-01-15 dtu@chromium.org [pinpoint] Ignore cached isolate hashes over 8 weeks old.
2019-01-14 eroman@chromium.org Fix import of new NetExport generated logs.
2019-01-14 bsheedy@chromium.org Fix gtest conversion multiplier
2019-01-14 eyaich@google.com Adding timeToFirstViewportReady metric
2019-01-14 perezju@chromium.org [py_utils] Add modules_util.RequireVersion
2019-01-14 perezju@chromium.org Remove GetNetworkData methods
2019-01-14 perezju@chromium.org [cli services] Add buildbucket_service
2019-01-14 perezju@chromium.org [Telemetry] Remove TBMv1 metrics.SmoothnessMetric
2019-01-11 benjhayden@chromium.org Remove TagMap.
2019-01-11 benjhayden@chromium.org Truncate serialized floats in HistogramSet JSON.


Created with:
  gclient setdep -r src/third_party/catapult@78448d90081e

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:776709,chromium:777865,chromium:918218,chromium:921616,chromium:874940,chromium:916877, chromium:917273 ,chromium:921342,chromium:904879,chromium:776709,chromium:777865,chromium:480512, chromium:919093 , chromium:691581 ,chromium:921000,chromium:918218,chromium:918208
TBR=sullivan@chromium.org

Change-Id: I75c07d8719f5668f9b4a95a9757cf6c25412b547
Reviewed-on: https://chromium-review.googlesource.com/c/1413252
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#623062}
[modify] https://crrev.com/c9d39cb7402e371e19d1485f07270953c266d4cd/DEPS

Comment 7 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 8 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry
Project Member

Comment 9 by bugdroid1@chromium.org, Today (9 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/348883443fd3b08e1a3e66007fd4e9fd890b52bc

commit 348883443fd3b08e1a3e66007fd4e9fd890b52bc
Author: benshayden <benjhayden@chromium.org>
Date: Tue Jan 22 20:47:29 2019

Reland Remove TagMap.

Telemetry benchmarks can contain hundreds of test cases, so they tag them to
make it easier to filter them. The tags are stored in the storyTags GenericSet
diagnostic, which is used by results.html, and soon by the dashboard:
https://chromium-review.googlesource.com/c/catapult/+/1394567
Story tags are also stored in TagMap diagnostics, which map from tags to sets of
stories. TagMaps contain the same information as storyTags, just centralized in
a different data structure.
After that change to update_test_suite_descriptors, TagMaps will not be used
anywhere. This CL removes TagMaps entirely.

Initial CL: https://chromium-review.googlesource.com/c/catapult/+/1405392
Revert: https://chromium-review.googlesource.com/c/catapult/+/1411772

Bug: chromium:918218
Change-Id: Ib03a20a0b49a73ffdd85fa33189f095a5d9765b4
Reviewed-on: https://chromium-review.googlesource.com/c/1411925
Reviewed-by: Caleb Rouleau <crouleau@chromium.org>
Reviewed-by: Simon Hatch <simonhatch@chromium.org>
Commit-Queue: Ben Hayden <benjhayden@chromium.org>

[delete] https://crrev.com/42feef6ebcf840287133138ed5b906effd040dc1/tracing/tracing/value/diagnostics/tag_map.py
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/tracing/tracing/value/histogram_set.html
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/dashboard/dashboard/elements/test-picker.html
[delete] https://crrev.com/42feef6ebcf840287133138ed5b906effd040dc1/tracing/tracing/value/ui/tag_map_span.html
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/telemetry/telemetry/internal/story_runner.py
[delete] https://crrev.com/42feef6ebcf840287133138ed5b906effd040dc1/tracing/tracing/value/diagnostics/tag_map_test.html
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/tracing/tracing/value/diagnostics/reserved_names.html
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/tracing/tracing/value/histogram_set.py
[delete] https://crrev.com/42feef6ebcf840287133138ed5b906effd040dc1/tracing/tracing/value/diagnostics/tag_map_unittest.py
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/dashboard/dashboard/add_histograms.py
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/tracing/tracing/value/histogram.py
[delete] https://crrev.com/42feef6ebcf840287133138ed5b906effd040dc1/tracing/tracing/value/diagnostics/tag_map.html
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/tracing/tracing/value/diagnostics/add_reserved_diagnostics_unittest.py
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/tracing/tracing/value/histogram_set_test.html
[delete] https://crrev.com/42feef6ebcf840287133138ed5b906effd040dc1/tracing/tracing/value/ui/tag_map_span_test.html
[delete] https://crrev.com/42feef6ebcf840287133138ed5b906effd040dc1/dashboard/dashboard/elements/story_tag_filter.html
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/tracing/tracing/value/diagnostics/reserved_infos.py
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/tracing/tracing/value/diagnostics/all_diagnostics.html
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/tracing/tracing/value/diagnostics/diagnostic_map.html
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/tracing/tracing/value/ui/diagnostic_span.html
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/dashboard/dashboard/get_diagnostics_test.py
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/dashboard/dashboard/elements/test-picker-test.html
[delete] https://crrev.com/42feef6ebcf840287133138ed5b906effd040dc1/dashboard/dashboard/elements/story_tag_filter_test.html
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/tracing/tracing/value/diagnostics/all_diagnostics.py
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/telemetry/telemetry/internal/story_runner_unittest.py
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/tracing/tracing/value/histogram_set_unittest.py
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/tracing/trace_viewer.gni
[modify] https://crrev.com/348883443fd3b08e1a3e66007fd4e9fd890b52bc/tracing/tracing/value/diagnostics/add_reserved_diagnostics.py
Project Member

Comment 10 by bugdroid, Today (7 hours ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/85aa3ad261742268dc85dfbbe98f0632edec9e82

commit 85aa3ad261742268dc85dfbbe98f0632edec9e82
Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Date: Tue Jan 22 22:48:07 2019

Roll src/third_party/catapult 42feef6ebcf8..348883443fd3 (1 commits)

https://chromium.googlesource.com/catapult.git/+log/42feef6ebcf8..348883443fd3


git log 42feef6ebcf8..348883443fd3 --date=short --no-merges --format='%ad %ae %s'
2019-01-22 benjhayden@chromium.org Reland Remove TagMap.


Created with:
  gclient setdep -r src/third_party/catapult@348883443fd3

The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:918218
TBR=sullivan@chromium.org

Change-Id: I33dd17a3522ce924698d13c527fe1f213d6ad484
Reviewed-on: https://chromium-review.googlesource.com/c/1427700
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#624974}
[modify] https://crrev.com/85aa3ad261742268dc85dfbbe98f0632edec9e82/DEPS
►

Sign in to add a comment