The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/264bf2822f04ff93989b25e1cb8330ebd48f1b0f

commit 264bf2822f04ff93989b25e1cb8330ebd48f1b0f
Author: khmel@chromium.org <khmel@chromium.org>
Date: Thu Jan 03 01:14:31 2019

shelf: Drop pin import from prefs.

We are 2+ years using shelf pins supported by sync. Now we can drop
import from prefs code. As a side effect this fixes several DCHECKs.
This also makes pin positions for default apps and apps, pinned by
policy deterministic and not-dependent from installation order.

TEST=Locally + unit_tests. Logic of unit tests is not changed.
BUG= 918203 
BUG= 907221 

Change-Id: I11d1cd7f1f0192719b48adfd3fa9e56c9dc1429b
Reviewed-on: https://chromium-review.googlesource.com/c/1392280
Commit-Queue: Yury Khmel <khmel@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619552}
[modify] https://crrev.com/264bf2822f04ff93989b25e1cb8330ebd48f1b0f/chrome/browser/ui/ash/chrome_launcher_prefs.cc
[modify] https://crrev.com/264bf2822f04ff93989b25e1cb8330ebd48f1b0f/chrome/browser/ui/ash/chrome_launcher_prefs.h
[modify] https://crrev.com/264bf2822f04ff93989b25e1cb8330ebd48f1b0f/chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc
[modify] https://crrev.com/264bf2822f04ff93989b25e1cb8330ebd48f1b0f/chrome/browser/ui/ash/launcher/chrome_launcher_controller.h
[modify] https://crrev.com/264bf2822f04ff93989b25e1cb8330ebd48f1b0f/chrome/browser/ui/ash/launcher/chrome_launcher_controller_unittest.cc
[modify] https://crrev.com/264bf2822f04ff93989b25e1cb8330ebd48f1b0f/chrome/common/pref_names.cc
[modify] https://crrev.com/264bf2822f04ff93989b25e1cb8330ebd48f1b0f/chrome/common/pref_names.h