[Dark mode] UI Changes to dark mode |
|||||||||||||||||||
Issue description1. The button "Turn on Sync" text should be in GG900 2. For the outline buttons, the outline should be GG700 3. The line separator should be black for sync promo 4. Sign out button for user menu should be like the other outline buttons 5. Overflow menu separators should match the separator treatment elsewhere 6. Link treatment: Should be Google Blue 300 7. Notification icon should be Google Grey 500 (As all other icons) and the cross icon should white 87% (here and everywhere else) 8. Pair button is disabled and should have disabled button treatment as in spec https://docs.google.com/presentation/d/1kJoBzf_HGYK_FAJPAjD67TW8224dCPLA6dAhlDmysk/edit#slide=id.g471d243f08_0_559
,
Jan 2
,
Jan 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35620f964d11fa3478eb04787927c6628cf81d02 commit 35620f964d11fa3478eb04787927c6628cf81d02 Author: Leonard Grey <lgrey@chromium.org> Date: Wed Jan 02 22:22:41 2019 Dark mode: set link color Bug: 918194 Change-Id: I4ffe380241ebaf46adac236535e8138729bfd227 Reviewed-on: https://chromium-review.googlesource.com/c/1393523 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#619516} [modify] https://crrev.com/35620f964d11fa3478eb04787927c6628cf81d02/ui/native_theme/common_theme.cc
,
Jan 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b68d203e9baddf7b26b0f236f200f654630971cf commit b68d203e9baddf7b26b0f236f200f654630971cf Author: Leonard Grey <lgrey@chromium.org> Date: Wed Jan 02 22:39:34 2019 Set explicit color for bubble close button Made in service of dark mode, but also setting one for light mode after consulting with UX. Bug: 918194 Change-Id: Ie4a5c76cd8ba833d5e518a65fea1ff21d0f8b28d Reviewed-on: https://chromium-review.googlesource.com/c/1393022 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#619520} [modify] https://crrev.com/b68d203e9baddf7b26b0f236f200f654630971cf/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc [modify] https://crrev.com/b68d203e9baddf7b26b0f236f200f654630971cf/ui/views/bubble/bubble_frame_view.cc [modify] https://crrev.com/b68d203e9baddf7b26b0f236f200f654630971cf/ui/views/bubble/bubble_frame_view.h
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/031d7fa5ace7bf5102404a97eb938d37efda3000 commit 031d7fa5ace7bf5102404a97eb938d37efda3000 Author: Leonard Grey <lgrey@chromium.org> Date: Thu Jan 03 20:59:12 2019 Use CONTEXT_BUTTON_MD for Dice promo buttons One might ask: why do even have this lever? I agree, so I filed https://crbug.com/918911 Bug: 918194 Change-Id: I0ea816a50d840e71bc6f8c5684877c8353cb0c11 Reviewed-on: https://chromium-review.googlesource.com/c/1394734 Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#619748} [modify] https://crrev.com/031d7fa5ace7bf5102404a97eb938d37efda3000/chrome/browser/ui/views/sync/dice_signin_button_view.cc
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5af9bac2f00eee2f65bd1e6ec4a5c686666c3122 commit 5af9bac2f00eee2f65bd1e6ec4a5c686666c3122 Author: Leonard Grey <lgrey@chromium.org> Date: Thu Jan 03 22:10:34 2019 Dark mode: add color for footnote view separator Bug: 918194 Change-Id: I6572c33b8e1a607b612b6dbf5c7a5a9f369862d6 Reviewed-on: https://chromium-review.googlesource.com/c/1394739 Reviewed-by: Michael Wasserman <msw@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#619777} [modify] https://crrev.com/5af9bac2f00eee2f65bd1e6ec4a5c686666c3122/ui/views/bubble/footnote_container_view.cc
,
Jan 5
Some my thoughts about dark mode colors: - on images 2,3 and 1,4 buttons contrast is too low, it should be dark text on light blue background or white text on dark blue background. - on image 8 the link color differs from buttons colors, more vibrant looks better. - overall the color scheme for buttons looks sad, maybe background color for buttons should stay dark blue with light text and blue text and borders should be more vibrant (see the attachment)?
,
Jan 14
|
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by lgrey@chromium.org
, Jan 2